Devicetree
 help / color / mirror / Atom feed
From: Vishnu Santhosh <vishnu.santhosh@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Kumar Patro <bibek.patro@oss.qualcomm.com>,
	Komal Bajaj <komal.bajaj@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Deepak Kumar Singh <deepak.singh@oss.qualcomm.com>
Subject: Re: [PATCH v3] dt-bindings: remoteproc: qcom,shikra-pas: Allow bam-dmux subnode
Date: Wed, 19 Aug 2026 16:53:36 +0530	[thread overview]
Message-ID: <b523b910-c645-44b1-9e76-1d25fac16468@oss.qualcomm.com> (raw)
In-Reply-To: <20260814-modest-rose-salmon-7bb60b@quoll>


On 14-08-2026 02:35 pm, Krzysztof Kozlowski wrote:
> On Thu, Aug 13, 2026 at 04:55:54PM +0530, Vishnu Santhosh wrote:
>> Allow an optional bam-dmux subnode under qcom,shikra-mpss-pas by
>> referencing qcom,bam-dmux.yaml.
> I still miss the answer why. Last time you said in present tense that
> this node exists there, which I objected. The answer to my objections is
> to provide proper reason why you are adding this, why you are doing it.
> Answer almost never is: repeat what the diff is doing.
>
> You change something in the bindings because something exists in the
> hardware and it was missed in initial submission, and you explain the
> impact of that "missing".
>
> Best regards,
> Krzysztof

Understood. The reason is not that there is already an in-tree DTS that
fails validation today. Rather, it is driven by the intended Shikra MPSS
topology.

In the earlier Shikra BAM-DMUX DTS posting, the bam-dmux node was initially
placed outside the modem remoteproc node. Based on review feedback from
Stephan [1], it was requested that bam-dmux be moved under the modem remoteproc
node instead. The rationale was that placing the bam-dmux node at the top level
makes it impossible for userspace to associate it with a remoteproc instance
(in this case, the modem). This binding change therefore exists to describe
the intended Shikra MPSS child-node topology.

The DTS user of this binding has not been merged yet. Its next revision is being
held until a separate discussion regarding an XPU violation is concluded. Our
intention is to get the required binding changes merged first so that the DT patch
can be sent once those discussions are complete.

Please let me know if adding the above context to the commit message is what you
are expecting.

[1] https://lore.kernel.org/all/airpBYZ2pRdNaE1v@linaro.org/

Thanks,
Vishnu

>

      reply	other threads:[~2026-08-19 11:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13 11:25 [PATCH v3] dt-bindings: remoteproc: qcom,shikra-pas: Allow bam-dmux subnode Vishnu Santhosh
2026-08-14  9:05 ` Krzysztof Kozlowski
2026-08-19 11:23   ` Vishnu Santhosh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b523b910-c645-44b1-9e76-1d25fac16468@oss.qualcomm.com \
    --to=vishnu.santhosh@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=bibek.patro@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=deepak.singh@oss.qualcomm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=komal.bajaj@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox