From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56DE8C4338F for ; Sun, 8 Aug 2021 16:51:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 26DDC60EB5 for ; Sun, 8 Aug 2021 16:51:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231199AbhHHQwN (ORCPT ); Sun, 8 Aug 2021 12:52:13 -0400 Received: from smtprelay0022.hostedemail.com ([216.40.44.22]:38654 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230201AbhHHQwM (ORCPT ); Sun, 8 Aug 2021 12:52:12 -0400 Received: from omf10.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay07.hostedemail.com (Postfix) with ESMTP id D6620181D302B; Sun, 8 Aug 2021 16:51:52 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf10.hostedemail.com (Postfix) with ESMTPA id 684482351F4; Sun, 8 Aug 2021 16:51:51 +0000 (UTC) Message-ID: Subject: Re: [PATCH v5 1/5] iio: adc: ad7949: define and use bitfield names From: Joe Perches To: Liam Beguin , lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, charles-antoine.couret@essensium.com, Nuno.Sa@analog.com Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org Date: Sun, 08 Aug 2021 09:51:50 -0700 In-Reply-To: <20210808015659.2955443-2-liambeguin@gmail.com> References: <20210808015659.2955443-1-liambeguin@gmail.com> <20210808015659.2955443-2-liambeguin@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.0-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 684482351F4 X-Stat-Signature: ddw8bkdreeyu6mbshx3jbmc5jirr99wu X-Rspamd-Server: rspamout02 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1/tA4iFDvhMsYDj0WcE4jvt7feIyi5W9k8= X-HE-Tag: 1628441511-89359 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, 2021-08-07 at 21:56 -0400, Liam Beguin wrote: > Replace raw configuration register values by using FIELD_PREP and > defines to improve readability. [] > diff --git a/drivers/iio/adc/ad7949.c b/drivers/iio/adc/ad7949.c [] +#define AD7949_CFG_BIT_INCC GENMASK(12, 10) I think the naming is a bit confusing as it appears as if these bitfield ranges are single bits. > +/* REF: reference/buffer selection */ > +#define AD7949_CFG_BIT_REF GENMASK(5, 3) [] > +/* SEQ: channel sequencer. Allows for scanning channels */ > +#define AD7949_CFG_BIT_SEQ GENMASK(2, 1) >