From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Nitin Rawat <quic_nitirawa@quicinc.com>,
Manivannan Sadhasivam <mani@kernel.org>
Cc: agross@kernel.org, andersson@kernel.org, alim.akhtar@samsung.com,
bvanassche@acm.org, robh+dt@kernel.org, avri.altman@wdc.com,
cros-qcom-dts-watchers@chromium.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH V1 2/2] arm64: dts: qcom: sc7280: Add UFS host controller and phy nodes
Date: Tue, 26 Sep 2023 19:29:30 +0200 [thread overview]
Message-ID: <b54d43b5-89fe-4801-9eff-57bd795cfed5@linaro.org> (raw)
In-Reply-To: <593fa9be-9f55-3649-e825-1dee31ac5c21@quicinc.com>
On 26.09.2023 18:24, Nitin Rawat wrote:
>
>
> On 8/22/2023 12:38 PM, Manivannan Sadhasivam wrote:
>> On Mon, Aug 21, 2023 at 03:19:37PM +0530, Nitin Rawat wrote:
>>> Add UFS host controller and PHY nodes for sc7280.
>>>
>>
>> You should split this patch into 2. One for SoC and another for board.
> Updated in Latest Patchset.
>
>>
>>> Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com>
>>> ---
>>> arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 19 +++++++
>>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 64 ++++++++++++++++++++++++
>>> 2 files changed, 83 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>>> index 2ff549f4dc7a..c60cdd511222 100644
>>> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>>> @@ -451,6 +451,25 @@
>>> status = "okay";
>>> };
>>>
>>> +&ufs_mem_hc {
>>> + reset-gpios = <&tlmm 175 GPIO_ACTIVE_LOW>;
>>> + vcc-supply = <&vreg_l7b_2p9>;
>>> + vcc-max-microamp = <800000>;
>>> + vccq-supply = <&vreg_l9b_1p2>;
>>> + vccq-max-microamp = <900000>;
>>> + vccq2-supply = <&vreg_l9b_1p2>;
>>> + vccq2-max-microamp = <900000>;
>>> +
>>> + status = "okay";
>>> +};
>>> +
>>> +&ufs_mem_phy {
>>> + vdda-phy-supply = <&vreg_l10c_0p8>;
>>> + vdda-pll-supply = <&vreg_l6b_1p2>;
>>> +
>>> + status = "okay";
>>> +};
>>> +
>>> &sdhc_1 {
>>> status = "okay";
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>> index 925428a5f6ae..d4a15d56b384 100644
>>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>> @@ -908,6 +908,70 @@
>>> };
>>> };
>>>
>>> + ufs_mem_phy: phy@1d87000 {
>>
>> Please sort the nodes in ascending order.
> Updated in Latest Patchset.
>
>>
>>> + compatible = "qcom,sc7280-qmp-ufs-phy";
>>> + reg = <0x0 0x01d87000 0x0 0xe00>;
>>> + clocks = <&rpmhcc RPMH_CXO_CLK>,
>>> + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>,
>>> + <&gcc GCC_UFS_1_CLKREF_EN>;
>>> + clock-names = "ref", "ref_aux", "qref";
>>> +
>>> + resets = <&ufs_mem_hc 0>;
>>> + reset-names = "ufsphy";
>>> +
>>> + #clock-cells = <1>;
>>> + #phy-cells = <0>;
>>> +
>>> + status = "disabled";
>>> +
>>> + };
>>> +
>>> + ufs_mem_hc: ufs@1d84000 {
>>> + compatible = "qcom,sc7280-ufshc", "qcom,ufshc",
>>> + "jedec,ufs-2.0";
>>> + reg = <0x0 0x01d84000 0x0 0x3000>;
>>> + interrupts = <GIC_SPI 265 IRQ_TYPE_LEVEL_HIGH>;
>>> + phys = <&ufs_mem_phy>;
>>> + phy-names = "ufsphy";
>>> + lanes-per-direction = <2>;
>>> + #reset-cells = <1>;
>>> + resets = <&gcc GCC_UFS_PHY_BCR>;
>>> + reset-names = "rst";
>>> +
>>> + power-domains = <&gcc GCC_UFS_PHY_GDSC>;
>>> + required-opps = <&rpmhpd_opp_nom>;
>>> +
>>> + iommus = <&apps_smmu 0x80 0x0>;
>>> + dma-coherent;
>>> +
>>> + clock-names = "core_clk",
>>> + "bus_aggr_clk",
>>> + "iface_clk",
>>> + "core_clk_unipro",
>>> + "ref_clk",
>>> + "tx_lane0_sync_clk",
>>> + "rx_lane0_sync_clk",
>>> + "rx_lane1_sync_clk";
>>
>> "clocks" property should come first.
> DT binding shows clock-names first followed by clocks.
> Let me know if see still see concern, would update .
The dt bindings example is rarely useful.. perhaps we should
change that..
The general consensus there is to have
property
property-names
Konrad
prev parent reply other threads:[~2023-09-26 17:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 9:49 [PATCH V1 0/2] Add UFS host controller and Phy nodes for sc7280 Nitin Rawat
2023-08-21 9:49 ` [PATCH V1 1/2] scsi: ufs: qcom: dt-bindings: Add SC7280 compatible string Nitin Rawat
2023-08-21 12:14 ` Krzysztof Kozlowski
2023-08-21 14:15 ` Bao D. Nguyen
2023-08-22 7:09 ` Manivannan Sadhasivam
2023-08-21 9:49 ` [PATCH V1 2/2] arm64: dts: qcom: sc7280: Add UFS host controller and phy nodes Nitin Rawat
2023-08-22 7:08 ` Manivannan Sadhasivam
2023-09-26 16:24 ` Nitin Rawat
2023-09-26 17:29 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b54d43b5-89fe-4801-9eff-57bd795cfed5@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=quic_nitirawa@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).