From: Krzysztof Kozlowski <krzk@kernel.org>
To: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Neeraj Soni <neeraj.soni@oss.qualcomm.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-crypto@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 2/4] soc: qcom: ice: Add OPP-based clock scaling support for ICE
Date: Thu, 5 Feb 2026 12:26:25 +0100 [thread overview]
Message-ID: <b556cc32-2b8e-4451-b333-aec2eddee7b1@kernel.org> (raw)
In-Reply-To: <aYBE/VljJTUNx3LK@hu-arakshit-hyd.qualcomm.com>
On 02/02/2026 07:32, Abhinaba Rakshit wrote:
> On Wed, Jan 28, 2026 at 12:04:26PM +0100, Krzysztof Kozlowski wrote:
>> On Wed, Jan 28, 2026 at 02:16:41PM +0530, Abhinaba Rakshit wrote:
>>> struct qcom_ice *engine;
>>> + struct dev_pm_opp *opp;
>>> + int err;
>>> + unsigned long rate;
>>>
>>> if (!qcom_scm_is_available())
>>> return ERR_PTR(-EPROBE_DEFER);
>>> @@ -584,6 +651,46 @@ static struct qcom_ice *qcom_ice_create(struct device *dev,
>>> if (IS_ERR(engine->core_clk))
>>> return ERR_CAST(engine->core_clk);
>>>
>>> + /* Register the OPP table only when ICE is described as a standalone
>>
>> This is not netdev...
>
> Okay, if I understand it correct, its not conventional to use of_device_is_compatible
> outside netdev subsystem. Will update as mentioned below.
No, please read entire coding style, although the comment was about
comment style.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-05 11:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 8:46 [PATCH v4 0/4] Enable ICE clock scaling Abhinaba Rakshit
2026-01-28 8:46 ` [PATCH v4 1/4] dt-bindings: crypto: ice: add operating-points-v2 property for QCOM ICE Abhinaba Rakshit
2026-01-28 11:00 ` Krzysztof Kozlowski
2026-02-02 6:37 ` Abhinaba Rakshit
2026-01-28 8:46 ` [PATCH v4 2/4] soc: qcom: ice: Add OPP-based clock scaling support for ICE Abhinaba Rakshit
2026-01-28 11:04 ` Krzysztof Kozlowski
2026-02-02 6:32 ` Abhinaba Rakshit
2026-02-02 9:23 ` Konrad Dybcio
2026-02-02 9:33 ` Abhinaba Rakshit
2026-02-05 11:26 ` Krzysztof Kozlowski [this message]
2026-02-06 13:23 ` Abhinaba Rakshit
2026-01-28 8:46 ` [PATCH v4 3/4] ufs: host: Add ICE clock scaling during UFS clock changes Abhinaba Rakshit
2026-01-28 13:59 ` Manivannan Sadhasivam
2026-01-28 8:46 ` [PATCH v4 4/4] soc: qcom: ice: Set ICE clk to TURBO on probe Abhinaba Rakshit
2026-01-29 12:17 ` [PATCH v4 0/4] Enable ICE clock scaling Konrad Dybcio
2026-02-02 6:36 ` Abhinaba Rakshit
2026-02-02 15:01 ` Konrad Dybcio
2026-02-06 12:03 ` Abhinaba Rakshit
2026-02-06 12:14 ` Konrad Dybcio
2026-02-06 13:22 ` Abhinaba Rakshit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b556cc32-2b8e-4451-b333-aec2eddee7b1@kernel.org \
--to=krzk@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=abhinaba.rakshit@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=neeraj.soni@oss.qualcomm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox