From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF6D4C001DC for ; Wed, 26 Jul 2023 07:24:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232326AbjGZHYO (ORCPT ); Wed, 26 Jul 2023 03:24:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232909AbjGZHXY (ORCPT ); Wed, 26 Jul 2023 03:23:24 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA8CF3C3E for ; Wed, 26 Jul 2023 00:21:45 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-51e429e1eabso9394676a12.2 for ; Wed, 26 Jul 2023 00:21:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690356104; x=1690960904; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=UrTqErO65WLHrYUraJkdfgcweJjKzl2A3sDrYCY0pMs=; b=GDBBvZGm09WoDOPISnjfiJwbT+bPfauPoIxRMeiuCUlS0CKzY5Agh0lcmF957c5zSP 8AL1cGTF3TCIqcYl1dRwzB6gjKk4urdulkwM/i/uTM+UVLqVLG8h49jUtiTHAunxPZLU wZhuxNaLI8tBXcjlBExFy49gnQvPzLa3o1SQpHZB/29pS11jrLy8mQesQb5AB5S6jk/9 9YCajLJ22k3KXOKGxvY1sjVEqy+0uTzBWybAeICqTWGozfS7FTrrNgbtIjkkigc/mXk4 pP7w+zLWE7IHW/KMQ0y3JfG9JswRKcBHYPs7AvaMhKmv+JcVVqnUNhV+wquBJvZKseuU LzJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690356104; x=1690960904; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UrTqErO65WLHrYUraJkdfgcweJjKzl2A3sDrYCY0pMs=; b=V+0BB61pSsDUQHlHmmIzX/G+j6Dj40ZYBm92MrLiEUmvKC2k36FlTw5dbIOu4TgCZe qPdyaOQK25YkS48pD1+D6hujHMYUq2+QN0FoR6TGeDemZTNjweuVnfUlEZ6/YLL+O+Aj cz/yowIF1YV9LHcb5wM4xUhOxHkfYI3K2aUa5j245YB7C05Sy/q3Fzuv8hF+aisMsGs9 IKCktbS0mDm25I8gEUR6Rt7egEhn8FKz7bzTDZ1AuGdoFRuHnnNYz8mOP7htMwnI0BZK CMqUQeBMYNFrqOz9+7vYFKp+bMHOGH5gek+fplrwaZnkMrniob+IK4wg1ATz2tSPhRIb niQQ== X-Gm-Message-State: ABy/qLZYZy2JPGXib3qdL2V5JUyY16fYXlh8gssFYIHhvJWhlur4rWcM KQzUgnm7MOYlButuEQ2iMeP5mw== X-Google-Smtp-Source: APBJJlHED6CFwSf1C2CIxq2MUjNUPgXXqBV7hLcoaMIh1GpTlJNo0udbQBixolhBapdmsueQoxfcEA== X-Received: by 2002:aa7:cf8e:0:b0:522:30d5:6065 with SMTP id z14-20020aa7cf8e000000b0052230d56065mr755052edx.21.1690356104092; Wed, 26 Jul 2023 00:21:44 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id l27-20020a056402345b00b0052279f773e3sm109247edc.32.2023.07.26.00.21.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jul 2023 00:21:43 -0700 (PDT) Message-ID: Date: Wed, 26 Jul 2023 09:21:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom: document AL02-Cx and AL03-C2 boards based on IPQ9574 family To: Sridharan S N , Konrad Dybcio , agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230720084534.6461-1-quic_sridsn@quicinc.com> <20230720084534.6461-2-quic_sridsn@quicinc.com> <87c3a3db-d172-bc98-cf83-89b874c9fee7@linaro.org> <9e401641-1334-c0bc-c49a-481a8a9af2de@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26/07/2023 07:03, Sridharan S N wrote: > > On 7/20/2023 3:18 PM, Konrad Dybcio wrote: >> On 20.07.2023 10:49, Krzysztof Kozlowski wrote: >>> On 20/07/2023 10:45, Sridharan S N wrote: >>>> Document the below listed (Reference Design Platform) RDP boards based on IPQ9574 >>>> family of SoCs. >>>> >>>> AL02-C3 - rdp437 >>>> AL02-C7 - rdp433-mht-phy >>>> AL02-C10 - rdp433-mht-switch >>>> AL02-C11 - rdp467 >>>> AL02-C12 - rdp455 >>>> AL02-C13 - rdp459 >>>> AL02-C15 - rdp457 >>>> AL02-C16 - rdp456 >>>> AL02-C17 - rdp469 >>>> AL02-C19 - rdp461 >>>> AL03-C2 - rdp458 >>>> >>>> Signed-off-by: Sridharan S N >>>> --- >>>> .../devicetree/bindings/arm/qcom.yaml | 20 +++++++++++++++++++ >>>> 1 file changed, 20 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml >>>> index dd66fd872c31..d992261da691 100644 >>>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml >>>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml >>>> @@ -89,10 +89,20 @@ description: | >>>> adp >>>> ap-al01-c1 >>>> ap-al02-c2 >>>> + ap-al02-c3 >>>> ap-al02-c6 >>>> ap-al02-c7 >>>> ap-al02-c8 >>>> ap-al02-c9 >>>> + ap-al02-c10 >>>> + ap-al02-c11 >>>> + ap-al02-c12 >>>> + ap-al02-c13 >>>> + ap-al02-c15 >>>> + ap-al02-c16 >>>> + ap-al02-c17 >>>> + ap-al02-c19 >>> Why? I asked once, but there was no feedback from Qualcomm. >>> >>> Why do we need to do this? What's the point? >> Another question would be, whether these boards are just one-off test >> prototypes of which there exist like 5-10 units, or are they actually >> going to be supported and useful. >> >> If it's the former, I don't think it makes sense to keep the device >> trees upstream. >> >> Konrad > > These are all not test rdps and each rdps has its own configurations. > IPQ9574 has four pcie instances and one QDSP processor. Not all rdps use > all of the interfaces and it will vary for each rdp. In next version , > will post with each rdp's configuration explicitly So still no answer why do we need to list it as possible boards. Especially that it messes with compatible style, because c[1-9] looks like board version. I suggest don't add these board types and drop existing ones. Best regards, Krzysztof