From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 794C0C4320A for ; Sun, 25 Jul 2021 22:18:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 577E960EB4 for ; Sun, 25 Jul 2021 22:18:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229604AbhGYVhs (ORCPT ); Sun, 25 Jul 2021 17:37:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229531AbhGYVhr (ORCPT ); Sun, 25 Jul 2021 17:37:47 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EAA4C061757; Sun, 25 Jul 2021 15:18:17 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id u20so8733705ljo.0; Sun, 25 Jul 2021 15:18:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=dUhRXsVILafLbrcPB/Q67vmty0U4fF9veTlHlCnEtoE=; b=VqTyDZKeiBNSF6NY6wJ0B3QVeonvwGYiWYwC/C+IuteaaqkDUxehCSd2G/mtnhHTzK msMphgqw2cM+0qROxPr9ph2omWLOSammr3kv9gt6Pzne55jLwsy8F661PhND3T1ry3IR fiEczxO0OAxsr0J86IZC8tDYg3kGw5091+yXSjCCd8qY+2oPTTSqwEgsIG036W1+nm1d nvvicSsBF5LENUTy0jv61/AyHP5ZHVn89lxtg9cgZQFhNPqBqjqejjViGXATG+VmapkP YAfPXk49SibWv8wMQZx3teBdNxz8TRBdOEpEBVu/nU7Ek9hcINlrpu70/2/zpkmvlPvT 0eqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=dUhRXsVILafLbrcPB/Q67vmty0U4fF9veTlHlCnEtoE=; b=MjK2W99mWYGhUxUtHWyvqLW1oXDqF1wxAvR7so9nobsKo6iMtwPghAo7Lzu4xcRwX7 O/8BnWxouVGrYyhJUpAAFpc266GcpOqohUQ9UsVJH7wHSZrUoiT/TLDC0KfyZkIBVuhe RqoibgPZ9ZwoKsbu+4KUEcN3G9qQaK4xzNQXqVNtpz72WR8Vtgot1y0Gz6/KlSei1Z8S f3kHmPV+lhubIn/qsBH7YmctSOiBTTMaW1PpGgBh8FRV/h1V4z51szMwZ7f9/k283v2C /NUnsJySxpUtOkVHs4/Iryomve/5/m8hne+oiUei423TqAxphIdXCIRp7oS925L2Km98 3jMg== X-Gm-Message-State: AOAM5326x/9M9lcb/ttBHNO2BvrlzxpckU5hNy8JCeVR/1Do1n/t2+Vp irQMTCD51XNbPqfiduIK+7s= X-Google-Smtp-Source: ABdhPJy6QvaawejBf4U+EnmKUnrnqwaUPLrkiynHcuqhsBM2ozdPNtDPQ0xlDMFv7kw7Q1HxHuogjQ== X-Received: by 2002:a2e:8110:: with SMTP id d16mr10417607ljg.42.1627251495466; Sun, 25 Jul 2021 15:18:15 -0700 (PDT) Received: from [192.168.1.6] ([194.79.5.201]) by smtp.gmail.com with ESMTPSA id 10sm2867285lfz.115.2021.07.25.15.18.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Jul 2021 15:18:15 -0700 (PDT) Subject: Re: [PATCH v2 3/3] drm/panel-simple: add Gopher 2b LCD panel To: Sam Ravnborg Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, paul@crapouillou.net, robh+dt@kernel.org, thierry.reding@gmail.com References: <20210724103358.1632020-1-akawolf0@gmail.com> <20210724103358.1632020-4-akawolf0@gmail.com> From: Artjom Vejsel Message-ID: Date: Mon, 26 Jul 2021 01:18:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, Sam! Thanks for commentaries, I've sent v3. On 25/07/2021 23.23, Sam Ravnborg wrote: > On Sat, Jul 24, 2021 at 01:33:58PM +0300, Artjom Vejsel wrote: >> The Gopher 2b LCD panel is used in Gopher 2b handhelds. >> It's simple panel with NewVision NV3047 driver, but SPI lines are not connected. >> It has no specific name, since it's unique to that handhelds. >> lot name at AliExpress: 4.3 inch 40PIN TFT LCD Screen COG NV3047 Drive IC 480(RGB)*272 No Touch 24Bit RGB Interface >> >> Signed-off-by: Artjom Vejsel >> --- >> drivers/gpu/drm/panel/panel-simple.c | 43 ++++++++++++++++++++++++++++ >> 1 file changed, 43 insertions(+) >> >> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c >> index 9b286bd4444f..9676e25accb3 100644 >> --- a/drivers/gpu/drm/panel/panel-simple.c >> +++ b/drivers/gpu/drm/panel/panel-simple.c >> @@ -4306,6 +4306,46 @@ static const struct panel_desc yes_optoelectronics_ytc700tlag_05_201c = { >> .connector_type = DRM_MODE_CONNECTOR_LVDS, >> }; >> >> +static const struct drm_display_mode qishenglong_gopher2b_lcd_panel_modes[] = { >> + { /* 60 Hz */ >> + .clock = 10800, >> + .hdisplay = 480, >> + .hsync_start = 480 + 77, >> + .hsync_end = 480 + 77 + 41, >> + .htotal = 480 + 77 + 41 + 2, >> + .vdisplay = 272, >> + .vsync_start = 272 + 16, >> + .vsync_end = 272 + 16 + 10, >> + .vtotal = 272 + 16 + 10 + 2, >> + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, >> + }, >> + { /* 50 Hz */ >> + .clock = 10800, >> + .hdisplay = 480, >> + .hsync_start = 480 + 17, >> + .hsync_end = 480 + 17 + 41, >> + .htotal = 480 + 17 + 41 + 2, >> + .vdisplay = 272, >> + .vsync_start = 272 + 116, >> + .vsync_end = 272 + 116 + 10, >> + .vtotal = 272 + 116 + 10 + 2, >> + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, >> + }, >> +}; >> + >> +static const struct panel_desc qishenglong_gopher2b_lcd_panel = { >> + .modes = qishenglong_gopher2b_lcd_panel_modes, >> + .num_modes = ARRAY_SIZE(qishenglong_gopher2b_lcd_panel_modes), >> + .bpc = 8, >> + .size = { >> + .width = 95, >> + .height = 54, >> + }, >> + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, >> + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE, >> + .connector_type = DRM_MODE_CONNECTOR_DPI, >> +}; >> + >> static const struct drm_display_mode arm_rtsm_mode[] = { >> { >> .clock = 65000, >> @@ -4753,6 +4793,9 @@ static const struct of_device_id platform_of_match[] = { >> }, { >> .compatible = "yes-optoelectronics,ytc700tlag-05-201c", >> .data = &yes_optoelectronics_ytc700tlag_05_201c, >> + }, { >> + .compatible = "qishenglong,gopher2b-lcd-panel", >> + .data = &qishenglong_gopher2b_lcd_panel, >> }, { > This list shall also be sorted alphabetically, after the compatible. > Same goes for the definition of the variable &qishenglong_gopher2b_lcd_panel > that shall be listed in the same order as here. > > Sorry for the nit-picking - but if we do not ask to have it fixed then > we quickly have a mess. > > Sam