From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com>,
dmitry.torokhov@gmail.com, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
jikos@kernel.org, benjamin.tissoires@redhat.co,
dianders@google.com, hsinyi@google.com
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: display: panel-simple-dsi: add Starry-er88577 DSI panel bindings
Date: Sat, 15 Jun 2024 12:05:39 +0200 [thread overview]
Message-ID: <b5932295-9b37-414f-b3a6-9667514e7076@linaro.org> (raw)
In-Reply-To: <20240614145609.25432-2-lvzhaoxiong@huaqin.corp-partner.google.com>
On 14/06/2024 16:56, Zhaoxiong Lv wrote:
> This add the bindings for the 1280x800 TFT LCD Starry-er88577 DSI panel
A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
> to panel-simple-dsi.
>
> Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com>
> ---
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> index db5acd2807ed..1f04acefba4e 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> @@ -60,6 +60,8 @@ properties:
> - samsung,sofef00
> # Shangai Top Display Optoelectronics 7" TL070WSH30 1024x600 TFT LCD panel
> - tdo,tl070wsh30
> + # The Starry-er88577 is a 10.1" WXGA TFT-LCD panel
> + - starry,er88577
Don't add to the end of lists, but keep proper alphabetical order.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-15 10:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 14:56 [PATCH v3 0/2] Support Starry er88577 MIPI-DSI panel Zhaoxiong Lv
2024-06-14 14:56 ` [PATCH v3 1/2] dt-bindings: display: panel-simple-dsi: add Starry-er88577 DSI panel bindings Zhaoxiong Lv
2024-06-15 10:05 ` Krzysztof Kozlowski [this message]
2024-06-14 14:56 ` [PATCH v3 2/2] drm/panel: starry-er88577: add new panel driver Zhaoxiong Lv
2024-06-14 17:25 ` Dmitry Baryshkov
2024-06-20 9:08 ` zhaoxiong lv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5932295-9b37-414f-b3a6-9667514e7076@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=benjamin.tissoires@redhat.co \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hsinyi@google.com \
--cc=jikos@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvzhaoxiong@huaqin.corp-partner.google.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).