From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.forwardemail.net (smtp.forwardemail.net [149.28.215.223]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCAD226B0AE for ; Thu, 13 Feb 2025 16:09:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=149.28.215.223 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739462997; cv=none; b=rqhTgEuTHi3ZLBphWwB3lfakAwS2ZTDXIyRQiXqk+uAVHYoM2QUZhw1iMZ9e/GNgIdHHNazvpwgA8egcp4r/ieSB2ZQHbI2FwNKIC6pusRKIhgC1LYpBKkwvbjDm38cqqI0UYbTejd2bENx/k4m5KdyPeoUR0OA5f3dmEQzDswY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739462997; c=relaxed/simple; bh=aZFJkkj4PtEl8L9lHvWWk+I1PNHQuKnT37w57jFX4/0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lndKsEaxbU7W9FTQhaDW+YV7pYRbl0IDJEDqrXYd/aSf8CToCxQgqwHd0mDEB/InyHJKj828QIH5B9u2wo0Bjdeg6PnszlgAu02tz8BTCw2thIwCe6VnE7adTQJsCCM4RItes+jBrZTfpLHG6hNP1z0Nd5NNLfi8XmPRXe03kaQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kwiboo.se; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b=hFRbf5mp; arc=none smtp.client-ip=149.28.215.223 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kwiboo.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b="hFRbf5mp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: From: References: Cc: To: Subject: MIME-Version: Date: Message-ID; q=dns/txt; s=fe-e1b5cab7be; t=1739462994; bh=OSqEFJEPXbKrFf4UCRw4Rj9UNsiFiIqusumOACEFv68=; b=hFRbf5mpafQtW6BFE17ed7yRnJx4vHhqlaFKf80aE9kOhz4kV81vFQRCPnwt+eVpQ4ydruotT Ia4HIRtsKKiBAmXB9nmnMmqXQL1PM04lTIqPSZSpvw3pAOIdl4iHpzvNgyZ4jtgyuVE0F2t8lld WYMzlWVYhOLAQ72Xnv93RlJpnIkLovva4WL8ELMdn1PBVR9nJDUNTQ0ihWAI6toXuMhtEPjnsJi kmODbQEcWDZSzJfOZ9vXqnZTSZrWXrSza8Npu1FumWuTXMNya7btNH2/IP2kVTq/YEqlnqE1qY2 cyvSqGPJ74Q6bcJZj6boMxwYBotnNSwV6IJgIoOTe5Bw== X-Forward-Email-ID: 67ae1441eeea92be259cebf3 X-Forward-Email-Sender: rfc822; jonas@kwiboo.se, smtp.forwardemail.net, 149.28.215.223 X-Forward-Email-Version: 0.4.40 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Report-Abuse-To: abuse@forwardemail.net Message-ID: Date: Thu, 13 Feb 2025 16:48:10 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] arm64: dts: rockchip: Add Radxa ROCK 4D device tree To: Detlev Casanova Cc: linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Dragan Simic , Chris Morgan , Kever Yang , Tim Lunn , FUKAUMI Naoki , Michael Riesch , Weizhao Ouyang , Elon Zhang , Alexey Charkov , Stephen Chen , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@collabora.com References: <20250213145921.133412-1-detlev.casanova@collabora.com> <20250213145921.133412-3-detlev.casanova@collabora.com> Content-Language: en-US From: Jonas Karlman In-Reply-To: <20250213145921.133412-3-detlev.casanova@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Detlev, On 2025-02-13 15:57, Detlev Casanova wrote: > From: Stephen Chen > > The Radxa ROCK 4D board is based on the Rockchip rk3576 SoC. > > The device tree adds support for basic devices: > - UART > - SD Card > - Ethernet > - USB > - RTC > > It has 4 USB ports but only 3 are usable as the top left one is used > for maskrom. > > It has a USB-C port that is only used for powering the board. > > Signed-off-by: Stephen Chen > Signed-off-by: Detlev Casanova > --- > arch/arm64/boot/dts/rockchip/Makefile | 1 + > .../boot/dts/rockchip/rk3576-rock-4d.dts | 651 ++++++++++++++++++ > 2 files changed, 652 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts > > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile > index def1222c1907e..a112aeb37948a 100644 > --- a/arch/arm64/boot/dts/rockchip/Makefile > +++ b/arch/arm64/boot/dts/rockchip/Makefile > @@ -132,6 +132,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5-display-vz.dtbo > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5-io-expander.dtbo > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-armsom-sige5.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-evb1-v10.dtb > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-rock-4d.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3582-radxa-e52c.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-armsom-sige7.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-armsom-w3.dtb > diff --git a/arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts b/arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts > new file mode 100644 > index 0000000000000..f356742f9d643 > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts > @@ -0,0 +1,651 @@ [snip] > +&gmac0 { > + phy-mode = "rgmii-id"; > + clock_in_out = "output"; > + > + snps,reset-gpio = <&gpio2 RK_PB5 GPIO_ACTIVE_LOW>; > + snps,reset-active-low; > + snps,reset-delays-us = <0 20000 100000>; The snps,reset- props are deprecated and should be changed to reset- props in the phy node. > + > + pinctrl-names = "default"; > + pinctrl-0 = <ð0m0_miim > + ð0m0_tx_bus2 > + ð0m0_rx_bus2 > + ð0m0_rgmii_clk > + ð0m0_rgmii_bus > + ðm0_clk0_25m_out>; > + > + phy-handle = <&rgmii_phy0>; > + status = "okay"; > +}; [snip] > +&mdio0 { > + rgmii_phy0: phy@1 { Maybe ethernet-phy@1 ? > + compatible = "ethernet-phy-ieee802.3-c22"; > + reg = <0x1>; > + clocks = <&cru REFCLKO25M_GMAC0_OUT>; Please add reset- props here. Changing to use reset- props may cause issue if a RTL8211F PHY is used on the board. Use a ethernet-phy-id compatible or mainline U-Boot to ensure the Ethernet PHY can be discovered during probe. Regards, Jonas > + }; > +}; > + [snip]