[PATCH v2] scsi: ufs: qcom: dt-bindings: Document the Eliza UFS controller

[PATCH v2] scsi: ufs: qcom: dt-bindings: Document the Eliza UFS controller

[Abel Vesa]

Document the UFS Controller on the Eliza Platform.

The IP block version here is 6.0.0, exactly the same as on SM8650.

Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
Changes in v2:
- Rebased on next-20260309.
- Mentioned the IP revision, as Manivannan requested.
- Link to v1: https://patch.msgid.link/20260223-eliza-bindings-ufs-v1-1-c4059596337f@oss.qualcomm.com
---
 Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml b/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml
index cea84ab2204f..80550144f932 100644
--- a/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml
+++ b/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml
@@ -15,6 +15,7 @@ select:
     compatible:
       contains:
         enum:
+          - qcom,eliza-ufshc
           - qcom,kaanapali-ufshc
           - qcom,sm8650-ufshc
           - qcom,sm8750-ufshc
@@ -25,6 +26,7 @@ properties:
   compatible:
     items:
       - enum:
+          - qcom,eliza-ufshc
           - qcom,kaanapali-ufshc
           - qcom,sm8650-ufshc
           - qcom,sm8750-ufshc

---
base-commit: 343f51842f4ed7143872f3aa116a214a5619a4b9
change-id: 20260221-eliza-bindings-ufs-2aa269f9c72f

Best regards,
--  
Abel Vesa <abel.vesa@oss.qualcomm.com>

Re: [PATCH v2] scsi: ufs: qcom: dt-bindings: Document the Eliza UFS controller

[Krzysztof Kozlowski]

On Tue, Mar 10, 2026 at 12:44:42PM +0200, Abel Vesa wrote:
> Document the UFS Controller on the Eliza Platform.
> 
> The IP block version here is 6.0.0, exactly the same as on SM8650.
> 
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---
> Changes in v2:
> - Rebased on next-20260309.
> - Mentioned the IP revision, as Manivannan requested.
> - Link to v1: https://patch.msgid.link/20260223-eliza-bindings-ufs-v1-1-c4059596337f@oss.qualcomm.com
> ---
>  Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml b/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml
> index cea84ab2204f..80550144f932 100644
> --- a/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml
> +++ b/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml
> @@ -15,6 +15,7 @@ select:
>      compatible:
>        contains:
>          enum:
> +          - qcom,eliza-ufshc
>            - qcom,kaanapali-ufshc
>            - qcom,sm8650-ufshc
>            - qcom,sm8750-ufshc
> @@ -25,6 +26,7 @@ properties:
>    compatible:
>      items:
>        - enum:
> +          - qcom,eliza-ufshc
>            - qcom,kaanapali-ufshc
>            - qcom,sm8650-ufshc
>            - qcom,sm8750-ufshc

You need constraints for minItems: 2 for reg and reg-names. MCQ is
required. The mistake was doone for Kaanapali, but that patch was
applied without review, so it is not a correct example to base on.

Best regards,
Krzysztof

Re: [PATCH v2] scsi: ufs: qcom: dt-bindings: Document the Eliza UFS controller

[Abel Vesa]

On 26-03-11 09:33:03, Krzysztof Kozlowski wrote:
> On Tue, Mar 10, 2026 at 12:44:42PM +0200, Abel Vesa wrote:
> > Document the UFS Controller on the Eliza Platform.
> > 
> > The IP block version here is 6.0.0, exactly the same as on SM8650.
> > 
> > Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> > ---
> > Changes in v2:
> > - Rebased on next-20260309.
> > - Mentioned the IP revision, as Manivannan requested.
> > - Link to v1: https://patch.msgid.link/20260223-eliza-bindings-ufs-v1-1-c4059596337f@oss.qualcomm.com
> > ---
> >  Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml b/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml
> > index cea84ab2204f..80550144f932 100644
> > --- a/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml
> > +++ b/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml
> > @@ -15,6 +15,7 @@ select:
> >      compatible:
> >        contains:
> >          enum:
> > +          - qcom,eliza-ufshc
> >            - qcom,kaanapali-ufshc
> >            - qcom,sm8650-ufshc
> >            - qcom,sm8750-ufshc
> > @@ -25,6 +26,7 @@ properties:
> >    compatible:
> >      items:
> >        - enum:
> > +          - qcom,eliza-ufshc
> >            - qcom,kaanapali-ufshc
> >            - qcom,sm8650-ufshc
> >            - qcom,sm8750-ufshc
> 
> You need constraints for minItems: 2 for reg and reg-names. MCQ is
> required. The mistake was doone for Kaanapali, but that patch was
> applied without review, so it is not a correct example to base on.

OK, so something like the following then ?

@@ -68,6 +68,18 @@ required:

 allOf:
   - $ref: qcom,ufs-common.yaml
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,eliza-ufshc
+    then:
+      properties:
+        reg:
+          minItems: 2
+        reg-names:
+          minItems: 2

Re: [PATCH v2] scsi: ufs: qcom: dt-bindings: Document the Eliza UFS controller

[Krzysztof Kozlowski]

On 11/03/2026 11:27, Abel Vesa wrote:
>>
>> You need constraints for minItems: 2 for reg and reg-names. MCQ is
>> required. The mistake was doone for Kaanapali, but that patch was
>> applied without review, so it is not a correct example to base on.
> 
> OK, so something like the following then ?
> 
> @@ -68,6 +68,18 @@ required:
> 
>  allOf:
>    - $ref: qcom,ufs-common.yaml
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - qcom,eliza-ufshc
> +    then:
> +      properties:
> +        reg:
> +          minItems: 2
> +        reg-names:
> +          minItems: 2
> 

Yes

Best regards,
Krzysztof