From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFDFFF9DF for ; Fri, 13 Oct 2023 11:58:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HkMW88Sx" Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFB29E1 for ; Fri, 13 Oct 2023 04:58:27 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4066692ad35so20999135e9.1 for ; Fri, 13 Oct 2023 04:58:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697198306; x=1697803106; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tgV2gzqYojQbMlx+5ZmwJREcgFrUXpc8GvCSDnoGDaM=; b=HkMW88Sx6lyE2A1XutchhFPsdK6z5KmI++I/IA13rsQLddztBo+BrgRlk2VOWgR+Vk xVytAlEWWSk13wqdO2tQ8R7sR1VS7DUdCKEvVsp11zzC8U44D859oKp9vqZXn54COmtO /k9M+5yWQZXoQwAzGGyDP4PNsqajJ1aqUgPaKNfsnJBeCDSfq4QYUYR7Dc5UQTVw3i7u NZVSaPVnONxmEqFFwoBiRj2YtW6A9Tn5rjTAMpvQAgLjELzwKqYN9mmGalEvlMVtXl1H W1BKWQGpiCVlDWM0IB2rBL6ZUVc0BMJHa9GfL+evdXQhkbxAEoIIdliZpusodeOVfRcX /AMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697198306; x=1697803106; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tgV2gzqYojQbMlx+5ZmwJREcgFrUXpc8GvCSDnoGDaM=; b=qOBPVG1rhQ3nLBASrcz3GiFzRKVdMMGVzH8YwZWa4M82z7WNOHblAv+PFnp1TExg5N YyWMQoQYdzBcCMSxZsV25ZuI7WxkCdhcMDHSU1m3b0eMJE4gvdauf4UDY6inE6KUbyoE T/AC4ZWBtnNPdFXp9lVc/cGzbfb0N5QMqlFz28eZBrYKAp8Rt2ivVteVclxgQpYnWhbs kY5YClKD+24aUB87Ai9tTTsLkQoDVDYdbM4YG3iGCMWrQmC0A6Pp0Zag2SzPeIjwHi+m agdco0SmhUyVfBR0nciovlGz48LrMfv525uP4fBUgSDCU8re/yjG4t7OWt3yLXdUH7Xx x4LA== X-Gm-Message-State: AOJu0Yx/VdDR+ArkJoM2mZu0Y5c7byqSNy6Nt6PlUXmyl6VTkj4oguxi ONeT4u81gWISLdQxu981RfpNAA== X-Google-Smtp-Source: AGHT+IEWIBqUg2xwJeLIQ15honztZfDJFvI0sme1+oo5Q/s/yYw3Y8YP5lb58a8bJ17WYCkFXjTYag== X-Received: by 2002:adf:cc8a:0:b0:31f:f1f4:ca8e with SMTP id p10-20020adfcc8a000000b0031ff1f4ca8emr23061525wrj.36.1697198306215; Fri, 13 Oct 2023 04:58:26 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.100]) by smtp.gmail.com with ESMTPSA id w14-20020adfee4e000000b0032d2489a399sm3188452wro.49.2023.10.13.04.58.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Oct 2023 04:58:25 -0700 (PDT) Message-ID: Date: Fri, 13 Oct 2023 13:58:23 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/5] dt-bindings: nvmem: Convert xlnx,zynqmp-nvmem.txt to yaml Content-Language: en-US To: Michal Simek , Praveen Teja Kundanala , srinivas.kandagatla@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org References: <20231013101450.573-1-praveen.teja.kundanala@amd.com> <20231013101450.573-3-praveen.teja.kundanala@amd.com> <02d3fa42-75a3-4f4f-ade6-204c8146d694@linaro.org> <91d61e1a-abb0-4b31-aa22-aff72d582ebe@amd.com> <013e44c6-45f5-44c1-94b3-536955fae78f@amd.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <013e44c6-45f5-44c1-94b3-536955fae78f@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 13/10/2023 13:51, Michal Simek wrote: > > > On 10/13/23 13:46, Krzysztof Kozlowski wrote: >> On 13/10/2023 13:22, Michal Simek wrote: >>>> >>>>> + >>>>> +required: >>>>> + - compatible >>>> >>>> required: block goes after patternProperties: block >>>> >>>>> + >>>>> +patternProperties: >>>>> + "^soc_revision@0$": >>>> >>>> Why do you define individual memory cells? Is this part of a binding? >>>> IOW, OS/Linux requires this? >>> >>> nvmem has in kernel interface where you can reference to nodes. nvmem_cell_get() >>> calls. It means you should be able to describe internal layout that's why names >>> are used. And address in name is there because of reg property is used to >>> describe base offset and size. >> >> That's not really what I am asking. Why internal layout of memory must >> be part of the bindings? > > It doesn't need to be but offsets are hardcoded inside the driver itself and > they can't be different. Hm, where? I opened drivers/nvmem/zynqmp_nvmem.c and I do not see any hard-coded offsets. > On different nvmem locations like MAC location in > eeprom this can vary across boards but in this case location has to be only like > this. > I am fine if they don't need to be actually check but there is no any other way > how they can be composed. And also others are not valid that's why not to > describe only valid one. OK, that would be valid (if I find anywhere the offsets) and answers my questions but I wish it was documented somewhere. Because now you are making it a binding, so it cannot change (e.g. for different devices with same hardware but different firmware or manufacturing process, for future hardware sharing this binding). In any case the binding should have only items which are really fixed and OS depends on them. Neither this nor next commit answers this. Best regards, Krzysztof