From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AD79153BF9 for ; Fri, 21 Jun 2024 13:06:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718975176; cv=none; b=VW9htHiAqSG7CTvwLuFO14NUfA6Tr1vjPryZUsIoSbZuwbJkuHHfZ2nLXJ4Cgm/PPwpGMH6P6rMtCllwuhoMU1H/rCJoRIgT57FRUYeYJm9phjZtbUmsWEJPXBrM1Rl6qU2F8rqVCW9n7lNeq2DnGyHAHzRbzqA/NAYZdl7KwrU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718975176; c=relaxed/simple; bh=ecepSflotEsDaYe0vYyujtYj08BaRh2BO7y9YSwjKP0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EYu0KXpZb15YLnuV6sXyBfwuyYCUXKCpq8wYk+NGYaP54LgF9lhtEdFuYNIWQSc/Zb86cTdWL+aY1ItWHZ6C5NLK0pCX82Rz4gLBAQRBPMe3gl1nia/dw7o7S1xbF1kzLdlJtKqkClu383uCdN84jI+u17d+CkpjS5vcLu4Y3Co= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=VJPbVqyh; arc=none smtp.client-ip=209.85.208.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="VJPbVqyh" Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2ebed33cb65so21223831fa.2 for ; Fri, 21 Jun 2024 06:06:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1718975168; x=1719579968; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bIGxGr2DfVtUVvxkMCQXW8GR27lMFtnZISEUl68lRTU=; b=VJPbVqyhfxAF++Av1rrAgnfKEYJoHtcHHABsnV2YC1EA0Z1A4dg4vTBzB9wht6S4Nd h9sFUHhvqkDqVqUAeMj+pAgHnSwwzNa8fyDFF5dd8sVfQ/aUKmqXjol+CSSin+thHEe7 rBSvzu8nUakndoPPWaq65ewtnJ6q4dG+5TGvodICLdr5KIPD/+jhAnU/KkL0/9JflTSg cEYRuM832JlMY+AjCj3zz8j7U6VFwFEm5Ndb4rfRsxR4C70LESGN95KRzoLcjuPc6n2q LAI0phqfRkgZywREnEjfnuhmvLnQQ29gk6fwgeOwIwmXIlK+9P0J6EWAqCdDIjHDYWAw cqAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718975168; x=1719579968; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bIGxGr2DfVtUVvxkMCQXW8GR27lMFtnZISEUl68lRTU=; b=WjM0sGs8USCU/nsxmDuNmXo0/w+6GdhHjunIXoAzBldFxecpIakcBscZJrnFy/awXK hNB9tZ0aegtyW2pYUdzBz4+XhDfX8UqBwROtxl1nzO7LFBLLv4V8NsIijlnZlP7IWHhA lUf4ZF3NRtuvZzQs4zBellXEBjAXg9IewFr1jN4q014pFShM230ujk4dRHRIUMG/yLe/ /ohwJT7Fy0ZzRZtkMjVt+pYpfpWciyQdsmUjqRokQXPZ13LuMzlfZo0EKAAPbkr0u/eC TZdgJhIsFIRVyIMkf5obt3ferVAaQhAV4QMpyTExDaSv+rMWaSnQEGiRGf6jxrRtCANU w0Ew== X-Forwarded-Encrypted: i=1; AJvYcCU7hywleDJUa5/CA9odxkHaNVCbrl/NBJf5K4dbCYudXhKDNePO58tFd0pYS2fH4BXdle7JYcglBT7AsKUaLLRPUqS+3dZEEVmELw== X-Gm-Message-State: AOJu0Yxd+FiZSSLzD6BqKNkIbpdTnnTjLSxmz/B/1o1HHinC+6+HOb6M /beLe/Cvez4HLSK5ugfMtTL//mH65sBo0C5vOy2gVXISfkByFW9DoVsaiwQm8AA= X-Google-Smtp-Source: AGHT+IEzEZHfG4HSbJtR65LMHcgNXMLcbF1KDaFaigAXcFwvOQ9KCFWFHvxuNW2zkIvNGyAdChuUrQ== X-Received: by 2002:a2e:7d0b:0:b0:2ec:140c:8985 with SMTP id 38308e7fff4ca-2ec3cfe99dfmr60423631fa.36.1718975168436; Fri, 21 Jun 2024 06:06:08 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.70]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57d3042cca2sm929189a12.36.2024.06.21.06.06.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jun 2024 06:06:07 -0700 (PDT) Message-ID: Date: Fri, 21 Jun 2024 16:06:05 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 08/12] dt-bindings: i2c: renesas,riic: Document the R9A08G045 support Content-Language: en-US To: Biju Das , Chris Brandt , "andi.shyti@kernel.org" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "geert+renesas@glider.be" , "magnus.damm@gmail.com" , "mturquette@baylibre.com" , "sboyd@kernel.org" , "p.zabel@pengutronix.de" , "wsa+renesas@sang-engineering.com" Cc: "linux-renesas-soc@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-clk@vger.kernel.org" , Claudiu Beznea References: <20240621112303.1607621-1-claudiu.beznea.uj@bp.renesas.com> <20240621112303.1607621-9-claudiu.beznea.uj@bp.renesas.com> <0bc78e5e-de37-4ff6-ac74-571f615b97f9@tuxon.dev> From: claudiu beznea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 21.06.2024 15:56, Biju Das wrote: > > Hi claudiu, > >> -----Original Message----- >> From: claudiu beznea >> Sent: Friday, June 21, 2024 1:55 PM >> Subject: Re: [PATCH 08/12] dt-bindings: i2c: renesas,riic: Document the R9A08G045 support >> >> >> >> On 21.06.2024 15:34, Biju Das wrote: >>> Hi Claudiu, >>> >>>> -----Original Message----- >>>> From: Claudiu >>>> Sent: Friday, June 21, 2024 12:23 PM >>>> Subject: [PATCH 08/12] dt-bindings: i2c: renesas,riic: Document the >>>> R9A08G045 support >>>> >>>> From: Claudiu Beznea >>>> >>>> Document the Renesas RZ/G3S (R9A08G045) RIIC IP. This is compatible >>>> with the version available on Renesas RZ/V2H (R9A09G075). Most of the >>>> IP variants that the RIIC driver is working with supports fast mode plus. >>>> However, it happens that on the same SoC to have IP instatiations >>>> that support fast mode plus as well as IP instantiation that doesn't >>>> support it. For this, introduced the renesas,riic-no-fast- mode-plus property. >>>> >>>> Signed-off-by: Claudiu Beznea >>>> --- >>>> Documentation/devicetree/bindings/i2c/renesas,riic.yaml | 8 ++++++++ >>>> 1 file changed, 8 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml >>>> b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml >>>> index 91ecf17b7a81..c0964edbca69 100644 >>>> --- a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml >>>> +++ b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml >>>> @@ -25,6 +25,10 @@ properties: >>>> - renesas,riic-r9a07g054 # RZ/V2L >>>> - const: renesas,riic-rz # RZ/A or RZ/G2L >>>> >>>> + - items: >>>> + - const: renesas,riic-r9a08g045 # RZ/G3S >>>> + - const: renesas,riic-r9a09g057 >>>> + >>>> - const: renesas,riic-r9a09g057 # RZ/V2H(P) >>>> >>>> reg: >>>> @@ -66,6 +70,10 @@ properties: >>>> resets: >>>> maxItems: 1 >>>> >>>> + renesas,riic-no-fast-mode-plus: >>>> + description: specifies if fast mode plus is not supported >>>> + type: Boolean >>> >>> Can't this info, as part of device data?? Based on frequency and >>> device data is enough to derive this info?? >> >> We can't rely completely on device data because on RZ/G3S we have 2 RIIC channels that support fast >> mode plus and 2 that doesn't support it. > > Can't array of bits for this channels won't help?? Can you give an example? I'm not sure I understand how you would prefer me to use the array of bits. Thank you, Claudiu Beznea > Based on the bit info, you have that details and check against frequency defined in DT. > > Cheers, > Biju