From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Niklas Cassel <niklas.cassel@linaro.org>
Cc: rohkumar@qti.qualcomm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, bgoswami@codeaurora.org,
linux-arm-msm@vger.kernel.org, plai@codeaurora.org,
lgirdwood@gmail.com, robh+dt@kernel.org, tiwai@suse.com,
broonie@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 05/11] ASoC: qdsp6: q6asm: use of_platform_populate/depopulate()
Date: Tue, 26 Jun 2018 09:52:23 +0100 [thread overview]
Message-ID: <b5a41a84-162b-62dd-271c-066e42370a3e@linaro.org> (raw)
In-Reply-To: <20180625180159.GD10876@centauri.lan>
On 25/06/18 19:01, Niklas Cassel wrote:
> On Mon, Jun 25, 2018 at 03:31:09PM +0100, Srinivas Kandagatla wrote:
>> Now that the child nodes have there own compatible strings,
>> Use of_platform_populate/depopulate() instead of less common
>> of_platform_device_create()/destroy().
>>
>> Signed-off-by: Srinivas Kandagatla<srinivas.kandagatla@linaro.org>
>> ---
>> sound/soc/qcom/qdsp6/q6asm.c | 17 ++---------------
>> 1 file changed, 2 insertions(+), 15 deletions(-)
>>
>> diff --git a/sound/soc/qcom/qdsp6/q6asm.c b/sound/soc/qcom/qdsp6/q6asm.c
>> index 530852385cad..2b2c7233bb5f 100644
>> --- a/sound/soc/qcom/qdsp6/q6asm.c
>> +++ b/sound/soc/qcom/qdsp6/q6asm.c
>> @@ -174,10 +174,8 @@ struct q6asm {
>> struct device *dev;
>> struct q6core_svc_api_info ainfo;
>> wait_queue_head_t mem_wait;
>> - struct platform_device *pcmdev;
> Why is this removed?
> If it's a cleanup, perhaps it should be in a separate patch.
Thanks, I will move this to a separate patch.
--srini
>
next prev parent reply other threads:[~2018-06-26 8:52 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 14:31 [PATCH 00/11] ASoC: qdsp6: Fix dt based module loading Srinivas Kandagatla
2018-06-25 14:31 ` [PATCH 01/11] ASoC: q6adm: dt-bindings: add compatible string to routing Srinivas Kandagatla
2018-06-25 17:59 ` Niklas Cassel
2018-06-26 15:11 ` Applied "ASoC: q6adm: dt-bindings: add compatible string to routing" to the asoc tree Mark Brown
2018-06-25 14:31 ` [PATCH 02/11] ASoC: q6asm: dt-bindings: add compatible string to dais Srinivas Kandagatla
2018-06-25 18:00 ` Niklas Cassel
2018-06-26 15:11 ` Applied "ASoC: q6asm: dt-bindings: add compatible string to dais" to the asoc tree Mark Brown
2018-06-25 14:31 ` [PATCH 03/11] ASoC: q6afe: dt-bindings: add compatible string to dais Srinivas Kandagatla
2018-06-25 18:01 ` Niklas Cassel
2018-06-26 8:53 ` Srinivas Kandagatla
2018-06-25 14:31 ` [PATCH 04/11] ASoC: qdsp6: q6adm: use of_platform_populate/depopulate() Srinivas Kandagatla
2018-06-25 18:03 ` Niklas Cassel
2018-06-26 8:56 ` Srinivas Kandagatla
2018-06-25 14:31 ` [PATCH 05/11] ASoC: qdsp6: q6asm: " Srinivas Kandagatla
2018-06-25 18:01 ` Niklas Cassel
2018-06-26 8:52 ` Srinivas Kandagatla [this message]
2018-06-25 14:31 ` [PATCH 06/11] ASoC: qdsp6: q6afe: " Srinivas Kandagatla
2018-06-25 18:02 ` Niklas Cassel
2018-06-26 15:11 ` Applied "ASoC: qdsp6: q6afe: use of_platform_populate/depopulate()" to the asoc tree Mark Brown
2018-06-25 14:31 ` [PATCH 07/11] ASoC: qdsp6: q6afe-dai: support dt based module loading Srinivas Kandagatla
2018-06-25 18:03 ` Niklas Cassel
2018-06-26 8:56 ` Srinivas Kandagatla
2018-06-25 14:31 ` [PATCH 08/11] ASoC: qdsp6: q6asm-dai: " Srinivas Kandagatla
2018-06-25 14:31 ` [PATCH 09/11] ASoC: qdsp6: q6routing: " Srinivas Kandagatla
2018-06-25 14:31 ` [PATCH 10/11] ASoC: qcom: apq8096: remove redundant owner assignment Srinivas Kandagatla
2018-06-25 18:03 ` Niklas Cassel
2018-06-26 15:10 ` Applied "ASoC: qcom: apq8096: remove redundant owner assignment" to the asoc tree Mark Brown
2018-06-25 14:31 ` [PATCH 11/11] ASoC: qdsp6: q6routing: add proper error check Srinivas Kandagatla
2018-06-25 18:04 ` Niklas Cassel
2018-06-26 8:53 ` Srinivas Kandagatla
2018-06-26 15:10 ` Applied "ASoC: qdsp6: q6routing: add proper error check" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5a41a84-162b-62dd-271c-066e42370a3e@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rohkumar@qti.qualcomm.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).