[PATCH] arm64: dts: qcom: sc8180x: Add video clock controller node

[PATCH] arm64: dts: qcom: sc8180x: Add video clock controller node

[Satya Priya Kakitapalli]

Add device node for video clock controller on Qualcomm
SC8180X platform.

Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
---
Add device node for video clock controller on Qualcomm
SC8180X platform.
---
 arch/arm64/boot/dts/qcom/sc8180x.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
index b74ce3175d209b569e634073662307964158b340..4590c2ff68a9885d8047d728bbf2dea0236d5b8f 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
@@ -10,6 +10,7 @@
 #include <dt-bindings/clock/qcom,gpucc-sm8150.h>
 #include <dt-bindings/clock/qcom,rpmh.h>
 #include <dt-bindings/clock/qcom,sc8180x-camcc.h>
+#include <dt-bindings/clock/qcom,videocc-sm8150.h>
 #include <dt-bindings/interconnect/qcom,icc.h>
 #include <dt-bindings/interconnect/qcom,osm-l3.h>
 #include <dt-bindings/interconnect/qcom,sc8180x.h>
@@ -2943,6 +2944,19 @@ usb_sec_dwc3_ss: endpoint {
 			};
 		};
 
+		videocc: clock-controller@ab00000 {
+			compatible = "qcom,sm8150-videocc";
+			reg = <0 0x0ab00000 0 0x10000>;
+			clocks = <&gcc GCC_VIDEO_AHB_CLK>,
+				 <&rpmhcc RPMH_CXO_CLK>;
+			clock-names = "iface", "bi_tcxo";
+			power-domains = <&rpmhpd SC8180X_MMCX>;
+			required-opps = <&rpmhpd_opp_low_svs>;
+			#clock-cells = <1>;
+			#reset-cells = <1>;
+			#power-domain-cells = <1>;
+		};
+
 		camcc: clock-controller@ad00000 {
 			compatible = "qcom,sc8180x-camcc";
 			reg = <0 0x0ad00000 0 0x20000>;

---
base-commit: 5d4809e25903ab8e74034c1f23c787fd26d52934
change-id: 20250623-sc8180x-videocc-dt-4ec3c0761f8d

Best regards,
-- 
Satya Priya Kakitapalli <quic_skakitap@quicinc.com>

Re: [PATCH] arm64: dts: qcom: sc8180x: Add video clock controller node

[Krzysztof Kozlowski]

On 23/06/2025 10:14, Satya Priya Kakitapalli wrote:
> Add device node for video clock controller on Qualcomm
> SC8180X platform.
> 
> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
> ---
> Add device node for video clock controller on Qualcomm
> SC8180X platform.
> ---
>  arch/arm64/boot/dts/qcom/sc8180x.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
> index b74ce3175d209b569e634073662307964158b340..4590c2ff68a9885d8047d728bbf2dea0236d5b8f 100644
> --- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
> @@ -10,6 +10,7 @@
>  #include <dt-bindings/clock/qcom,gpucc-sm8150.h>
>  #include <dt-bindings/clock/qcom,rpmh.h>
>  #include <dt-bindings/clock/qcom,sc8180x-camcc.h>
> +#include <dt-bindings/clock/qcom,videocc-sm8150.h>
>  #include <dt-bindings/interconnect/qcom,icc.h>
>  #include <dt-bindings/interconnect/qcom,osm-l3.h>
>  #include <dt-bindings/interconnect/qcom,sc8180x.h>
> @@ -2943,6 +2944,19 @@ usb_sec_dwc3_ss: endpoint {
>  			};
>  		};
>  
> +		videocc: clock-controller@ab00000 {
Why are you adding the same multiple times? This was added A YEAR AGO,
so you clearly send us some complete outdated ancient tree!

Best regards,
Krzysztof

Re: [PATCH] arm64: dts: qcom: sc8180x: Add video clock controller node

[Konrad Dybcio]

On 6/23/25 10:44 AM, Krzysztof Kozlowski wrote:
> On 23/06/2025 10:14, Satya Priya Kakitapalli wrote:
>> Add device node for video clock controller on Qualcomm
>> SC8180X platform.
>>
>> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
>> ---
>> Add device node for video clock controller on Qualcomm
>> SC8180X platform.
>> ---
>>  arch/arm64/boot/dts/qcom/sc8180x.dtsi | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
>> index b74ce3175d209b569e634073662307964158b340..4590c2ff68a9885d8047d728bbf2dea0236d5b8f 100644
>> --- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
>> @@ -10,6 +10,7 @@
>>  #include <dt-bindings/clock/qcom,gpucc-sm8150.h>
>>  #include <dt-bindings/clock/qcom,rpmh.h>
>>  #include <dt-bindings/clock/qcom,sc8180x-camcc.h>
>> +#include <dt-bindings/clock/qcom,videocc-sm8150.h>
>>  #include <dt-bindings/interconnect/qcom,icc.h>
>>  #include <dt-bindings/interconnect/qcom,osm-l3.h>
>>  #include <dt-bindings/interconnect/qcom,sc8180x.h>
>> @@ -2943,6 +2944,19 @@ usb_sec_dwc3_ss: endpoint {
>>  			};
>>  		};
>>  
>> +		videocc: clock-controller@ab00000 {
> Why are you adding the same multiple times? This was added A YEAR AGO,
> so you clearly send us some complete outdated ancient tree!

It seems like you're confusing something, there is no videocc node in
sc8180x.dtsi

Konrad

Re: [PATCH] arm64: dts: qcom: sc8180x: Add video clock controller node

[Konrad Dybcio]

On 6/23/25 10:14 AM, Satya Priya Kakitapalli wrote:
> Add device node for video clock controller on Qualcomm
> SC8180X platform.
> 
> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
> ---
> Add device node for video clock controller on Qualcomm
> SC8180X platform.

Because you added this text under '---', it will not be included in
the commit log (and we want it to be there), please put the message
above your sign-off

> ---
>  arch/arm64/boot/dts/qcom/sc8180x.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
> index b74ce3175d209b569e634073662307964158b340..4590c2ff68a9885d8047d728bbf2dea0236d5b8f 100644
> --- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
> @@ -10,6 +10,7 @@
>  #include <dt-bindings/clock/qcom,gpucc-sm8150.h>
>  #include <dt-bindings/clock/qcom,rpmh.h>
>  #include <dt-bindings/clock/qcom,sc8180x-camcc.h>
> +#include <dt-bindings/clock/qcom,videocc-sm8150.h>
>  #include <dt-bindings/interconnect/qcom,icc.h>
>  #include <dt-bindings/interconnect/qcom,osm-l3.h>
>  #include <dt-bindings/interconnect/qcom,sc8180x.h>
> @@ -2943,6 +2944,19 @@ usb_sec_dwc3_ss: endpoint {
>  			};
>  		};
>  
> +		videocc: clock-controller@ab00000 {
> +			compatible = "qcom,sm8150-videocc";

If the blocks are truly 1:1 shared, with no additional software changes
required, please still include a 8180-specific compatible in the front,
with a 8150 fallback:

"qcom,sc8180x-videocc", "qcom,sm8150-videocc"

which will require a dt-bindings update

Konrad

Re: [PATCH] arm64: dts: qcom: sc8180x: Add video clock controller node

[Krzysztof Kozlowski]

On 23/06/2025 12:01, Konrad Dybcio wrote:
> On 6/23/25 10:44 AM, Krzysztof Kozlowski wrote:
>> On 23/06/2025 10:14, Satya Priya Kakitapalli wrote:
>>> Add device node for video clock controller on Qualcomm
>>> SC8180X platform.
>>>
>>> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
>>> ---
>>> Add device node for video clock controller on Qualcomm
>>> SC8180X platform.
>>> ---
>>>  arch/arm64/boot/dts/qcom/sc8180x.dtsi | 14 ++++++++++++++
>>>  1 file changed, 14 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
>>> index b74ce3175d209b569e634073662307964158b340..4590c2ff68a9885d8047d728bbf2dea0236d5b8f 100644
>>> --- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
>>> @@ -10,6 +10,7 @@
>>>  #include <dt-bindings/clock/qcom,gpucc-sm8150.h>
>>>  #include <dt-bindings/clock/qcom,rpmh.h>
>>>  #include <dt-bindings/clock/qcom,sc8180x-camcc.h>
>>> +#include <dt-bindings/clock/qcom,videocc-sm8150.h>
>>>  #include <dt-bindings/interconnect/qcom,icc.h>
>>>  #include <dt-bindings/interconnect/qcom,osm-l3.h>
>>>  #include <dt-bindings/interconnect/qcom,sc8180x.h>
>>> @@ -2943,6 +2944,19 @@ usb_sec_dwc3_ss: endpoint {
>>>  			};
>>>  		};
>>>  
>>> +		videocc: clock-controller@ab00000 {
>> Why are you adding the same multiple times? This was added A YEAR AGO,
>> so you clearly send us some complete outdated ancient tree!
> 
> It seems like you're confusing something, there is no videocc node in
> sc8180x.dtsi


Heh, I am... the line below:
	compatible = "qcom,sm8150-videocc";
confused me and I looked at wrong file.

Satya:
Still for obvious reasons: NAK. See writing bindings or internal guideline.

Best regards,
Krzysztof

Re: [PATCH] arm64: dts: qcom: sc8180x: Add video clock controller node

[Satya Priya Kakitapalli]

On 6/23/2025 3:55 PM, Krzysztof Kozlowski wrote:
> On 23/06/2025 12:01, Konrad Dybcio wrote:
>> On 6/23/25 10:44 AM, Krzysztof Kozlowski wrote:
>>> On 23/06/2025 10:14, Satya Priya Kakitapalli wrote:
>>>> Add device node for video clock controller on Qualcomm
>>>> SC8180X platform.
>>>>
>>>> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
>>>> ---
>>>> Add device node for video clock controller on Qualcomm
>>>> SC8180X platform.
>>>> ---
>>>>   arch/arm64/boot/dts/qcom/sc8180x.dtsi | 14 ++++++++++++++
>>>>   1 file changed, 14 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
>>>> index b74ce3175d209b569e634073662307964158b340..4590c2ff68a9885d8047d728bbf2dea0236d5b8f 100644
>>>> --- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
>>>> @@ -10,6 +10,7 @@
>>>>   #include <dt-bindings/clock/qcom,gpucc-sm8150.h>
>>>>   #include <dt-bindings/clock/qcom,rpmh.h>
>>>>   #include <dt-bindings/clock/qcom,sc8180x-camcc.h>
>>>> +#include <dt-bindings/clock/qcom,videocc-sm8150.h>
>>>>   #include <dt-bindings/interconnect/qcom,icc.h>
>>>>   #include <dt-bindings/interconnect/qcom,osm-l3.h>
>>>>   #include <dt-bindings/interconnect/qcom,sc8180x.h>
>>>> @@ -2943,6 +2944,19 @@ usb_sec_dwc3_ss: endpoint {
>>>>   			};
>>>>   		};
>>>>   
>>>> +		videocc: clock-controller@ab00000 {
>>> Why are you adding the same multiple times? This was added A YEAR AGO,
>>> so you clearly send us some complete outdated ancient tree!
>> It seems like you're confusing something, there is no videocc node in
>> sc8180x.dtsi
>
> Heh, I am... the line below:
> 	compatible = "qcom,sm8150-videocc";
> confused me and I looked at wrong file.
>
> Satya:
> Still for obvious reasons: NAK. See writing bindings or internal guideline.


Sure, I will add a new compatible for sc8180x and update the bindings 
accordingly in my next post.

Re: [PATCH] arm64: dts: qcom: sc8180x: Add video clock controller node

[Satya Priya Kakitapalli]

On 6/23/2025 3:38 PM, Konrad Dybcio wrote:
> On 6/23/25 10:14 AM, Satya Priya Kakitapalli wrote:
>> Add device node for video clock controller on Qualcomm
>> SC8180X platform.
>>
>> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
>> ---
>> Add device node for video clock controller on Qualcomm
>> SC8180X platform.
> Because you added this text under '---', it will not be included in
> the commit log (and we want it to be there), please put the message
> above your sign-off


I did not add this manually, seems it was appended by b4

https://b4.docs.kernel.org/en/latest/contributor/prep.html#what-if-the-series-only-has-a-single-patch


I have already mentioned the same message in the commit text above my 
sign-off.


>
>> ---
>>   arch/arm64/boot/dts/qcom/sc8180x.dtsi | 14 ++++++++++++++
>>   1 file changed, 14 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
>> index b74ce3175d209b569e634073662307964158b340..4590c2ff68a9885d8047d728bbf2dea0236d5b8f 100644
>> --- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
>> @@ -10,6 +10,7 @@
>>   #include <dt-bindings/clock/qcom,gpucc-sm8150.h>
>>   #include <dt-bindings/clock/qcom,rpmh.h>
>>   #include <dt-bindings/clock/qcom,sc8180x-camcc.h>
>> +#include <dt-bindings/clock/qcom,videocc-sm8150.h>
>>   #include <dt-bindings/interconnect/qcom,icc.h>
>>   #include <dt-bindings/interconnect/qcom,osm-l3.h>
>>   #include <dt-bindings/interconnect/qcom,sc8180x.h>
>> @@ -2943,6 +2944,19 @@ usb_sec_dwc3_ss: endpoint {
>>   			};
>>   		};
>>   
>> +		videocc: clock-controller@ab00000 {
>> +			compatible = "qcom,sm8150-videocc";
> If the blocks are truly 1:1 shared, with no additional software changes
> required, please still include a 8180-specific compatible in the front,
> with a 8150 fallback:
>
> "qcom,sc8180x-videocc", "qcom,sm8150-videocc"
>
> which will require a dt-bindings update


Sure, I will add the new compatible for sc8180x and update the bindings.