From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Frank Li <frank.li@nxp.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"festevam@gmail.com" <festevam@gmail.com>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
dl-linux-imx <linux-imx@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"shawnguo@kernel.org" <shawnguo@kernel.org>
Subject: Re: [EXT] Re: [PATCH v3 1/3] dt-bindings: usb: cdns-imx8qm: add imx8qm cdns3 glue bindings
Date: Wed, 22 Mar 2023 22:32:06 +0100 [thread overview]
Message-ID: <b5d67af0-ed08-e243-2c0c-92f1f002e552@linaro.org> (raw)
In-Reply-To: <AM6PR04MB483828FC1083E3C98930DF6488869@AM6PR04MB4838.eurprd04.prod.outlook.com>
On 22/03/2023 15:34, Frank Li wrote:
>
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Sent: Wednesday, March 22, 2023 2:32 AM
>> To: Frank Li <frank.li@nxp.
>>> + - const: usb3_aclk
>>> + - const: usb3_ipg_clk
>>> + - const: usb3_core_pclk
>>> +
>>> + assigned-clocks:
>>> + items:
>>> + - description: Phandle and clock specifoer of
>> IMX_SC_PM_CLK_MST_BUS.
>>
>> Drop useless pieces so "Phandle and clock specifoer of " and name the
>> hardware, not the syntax.
>>
>>> +
>>> + assigned-clock-rates:
>>> + items:
>>> + - description: Should be in Range 100 - 600 Mhz.
>>
>> That's better but I still do not understand why do you need it in the
>> bindings. You never actually answered this question.
>
> I am not sure 100% sure the reason.
> I think difference system target's axi bus frequency is difference,
> And just one time work, needn't software to manage it.
> Following other driver's code style may be another reason.
That's the reason of heaving it in DTS. But I am asking about bindings.
You do understand you define here interface?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-22 21:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 15:19 [PATCH v3 0/3] dts: imx8qxp add cdns usb3 port Frank Li
2023-03-21 15:19 ` [PATCH v3 1/3] dt-bindings: usb: cdns-imx8qm: add imx8qm cdns3 glue bindings Frank Li
2023-03-22 7:32 ` Krzysztof Kozlowski
2023-03-22 14:34 ` [EXT] " Frank Li
2023-03-22 21:32 ` Krzysztof Kozlowski [this message]
2023-03-22 21:36 ` Frank Li
2023-03-22 21:38 ` Krzysztof Kozlowski
2023-03-22 21:40 ` Frank Li
2023-03-22 21:42 ` Krzysztof Kozlowski
2023-03-22 21:57 ` Frank Li
2023-03-22 22:08 ` Krzysztof Kozlowski
2023-03-22 22:15 ` Frank Li
2023-03-23 6:33 ` Krzysztof Kozlowski
2023-03-21 15:19 ` [PATCH v3 2/3] arm64: dts: imx8qxp: add cadence usb3 support Frank Li
2023-03-21 15:19 ` [PATCH v3 3/3] arm64: dts: freescale: imx8qxp-mek: enable cadence usb3 Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5d67af0-ed08-e243-2c0c-92f1f002e552@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frank.li@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).