devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: agross@kernel.org, andersson@kernel.org,
	konrad.dybcio@linaro.org, djakov@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, benl@squareup.com,
	shawn.guo@linaro.org, fabien.parent@linaro.org,
	leo.yan@linaro.org, dmitry.baryshkov@linaro.org,
	Jun Nie <jun.nie@linaro.org>,
	James Willcox <jwillcox@squareup.com>,
	Joseph Gates <jgates@squareup.com>, Max Chen <mchen@squareup.com>,
	Zac Crosby <zac@squareup.com>,
	Vincent Knecht <vincent.knecht@mailoo.org>
Subject: Re: [PATCH v5 2/5] arm64: dts: qcom: Add msm8939 SoC
Date: Mon, 13 Feb 2023 00:04:36 +0000	[thread overview]
Message-ID: <b5f5cdbc-9b4b-3c86-86f6-c3944884cd1f@linaro.org> (raw)
In-Reply-To: <Y+kfuHDMZCu1vKsA@gerhold.net>

On 12/02/2023 17:19, Stephan Gerhold wrote:
> Huh?
> 
> We had this discussion several times before and once you mentioned that
> Shawn fixed this in your production kernel at some point. You just keep
> forgetting to apply the same change to your upstream tree. 😉
> 
> You can either change the timer interrupt numbers or (more easily) just
> fix the address to point to the timer of the other cluster (which has
> the same interrupt numbers as on 8916):

I must be getting old(er) to have no memory of that.

But you're right, we do have that in the production tree.

commit 91a842b81a713ede9ba76f3957e6fdd9067b5493
Author: Shawn Guo <shawn.guo@linaro.org>
Date:   Thu May 28 11:03:40 2020 +0800

     arm64: dts: msm8939: fix base address of memory mapped timer

-               timer@b020000 {
+               timer@b120000 {

Which I guess explains why it works after all.

Cheers.

---
bod

  reply	other threads:[~2023-02-13  0:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-06  1:23 [PATCH v5 0/5] Add MSM8939 SoC support with two devices Bryan O'Donoghue
2023-02-06  1:23 ` [PATCH v5 1/5] dt-bindings: vendor-prefixes: Add Square Bryan O'Donoghue
2023-02-06  7:51   ` Krzysztof Kozlowski
2023-02-06  1:23 ` [PATCH v5 2/5] arm64: dts: qcom: Add msm8939 SoC Bryan O'Donoghue
2023-02-09 13:47   ` Stephan Gerhold
2023-02-12 16:49     ` Bryan O'Donoghue
2023-02-12 17:19       ` Stephan Gerhold
2023-02-13  0:04         ` Bryan O'Donoghue [this message]
2023-02-06  1:23 ` [PATCH v5 3/5] arm64: dts: qcom: Add msm8939-pm8916.dtsi include Bryan O'Donoghue
2023-02-06  1:23 ` [PATCH v5 4/5] arm64: dts: qcom: Add Square apq8039-t2 board Bryan O'Donoghue
2023-02-06  1:23 ` [PATCH v5 5/5] arm64: dts: qcom: Add msm8939 Sony Xperia M4 Aqua Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b5f5cdbc-9b4b-3c86-86f6-c3944884cd1f@linaro.org \
    --to=bryan.odonoghue@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=benl@squareup.com \
    --cc=devicetree@vger.kernel.org \
    --cc=djakov@kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=fabien.parent@linaro.org \
    --cc=jgates@squareup.com \
    --cc=jun.nie@linaro.org \
    --cc=jwillcox@squareup.com \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mchen@squareup.com \
    --cc=robh+dt@kernel.org \
    --cc=shawn.guo@linaro.org \
    --cc=stephan@gerhold.net \
    --cc=vincent.knecht@mailoo.org \
    --cc=zac@squareup.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).