From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Magnus Damm <magnus.damm@gmail.com>,
Biju Das <biju.das.jz@bp.renesas.com>,
Wolfram Sang <wsa@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Jacopo Mondi <jacopo@jmondi.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: i2c: renesas,rzv2m: Fix SoC specific string
Date: Mon, 7 Nov 2022 19:39:59 +0100 [thread overview]
Message-ID: <b5f881b7-1f59-623a-a126-d7827dec85fe@linaro.org> (raw)
In-Reply-To: <20221107165027.54150-2-fabrizio.castro.jz@renesas.com>
On 07/11/2022 17:50, Fabrizio Castro wrote:
> The preferred form for Renesas' compatible strings is:
> "<vendor>,<family>-<module>"
>
> Somehow the compatible string for the r9a09g011 I2C IP was upstreamed
> as renesas,i2c-r9a09g011 instead of renesas,r9a09g011-i2c, which
> is really confusing, especially considering the generic fallback
> is renesas,rzv2m-i2c.
>
> The first user of renesas,i2c-r9a09g011 in the kernel is not yet in
> a kernel release, it will be in v6.1, therefore it can still be
> fixed in v6.1.
> Even if we don't fix it before v6.2, I don't think there is any
> harm in making such a change.
>
> s/renesas,i2c-r9a09g011/renesas,r9a09g011-i2c/g for consistency.
>
> Fixes: ba7a4d15e2c4 ("dt-bindings: i2c: Document RZ/V2M I2C controller")
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-07 18:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 16:50 [PATCH v2 0/2] Fix r9a09g011 specific I2C compatible string Fabrizio Castro
2022-11-07 16:50 ` [PATCH v2 1/2] dt-bindings: i2c: renesas,rzv2m: Fix SoC specific string Fabrizio Castro
2022-11-07 18:39 ` Krzysztof Kozlowski [this message]
2023-01-16 16:16 ` Fabrizio Castro
2023-01-16 21:41 ` Wolfram Sang
2023-01-17 17:48 ` Fabrizio Castro
2022-11-07 16:50 ` [PATCH v2 2/2] arm64: dts: renesas: r9a09g011: Fix I2C SoC specific strings Fabrizio Castro
2022-11-08 9:06 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5f881b7-1f59-623a-a126-d7827dec85fe@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=jacopo@jmondi.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).