[PATCH v4 0/6] Add support for ICSSG PA_STATS

[PATCH v4 0/6] Add support for ICSSG PA_STATS

[MD Danish Anwar]

Hi,

This series adds support for PA_STATS. Previously this series was a standalone
patch adding documentation for PA_STATS in dt-bindings file ti,pruss.yaml.

Nishanth Menon <nm@ti.com> had asked in v3 to post entire series. So adding
patches needed for entire series in this revision.

Inter dependency between patches:
*) Patch 2 can be applied to net-next tree without any error / warning.
*) Patch 3,4,5 and 6 can not be applied to their tree as it will result in
   dt-bindings check error. For these patches to cleanly apply, patch 1 is
   needed in the tree.
*) To avoid any confusion I have marked patch 2 - 6 as [DO NOT MERGE]. Only
   Patch 1 needs to be merged now.

Changes since v3:
*) Added full series as asked by Nishanth Menon <nm@ti.com>

Changes from v2 to v3:
*) Added RB tag of Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> to
   patch 2/2
*) Added patch 1/2 to the series as the binding file is orphan.

Changes from v1 to v2:
*) Added ^ in pa-stats as suggested by Krzysztof Kozlowski
   <krzk@kernel.org>
*) Moved additionalProperties: false to right after after type:object as
   suggested by Krzysztof Kozlowski <krzk@kernel.org>
*) Updated description of pa-stats to explain the purpose of PA_STATS
   module in context of ICSSG.

v1 https://lore.kernel.org/all/20240430121915.1561359-1-danishanwar@ti.com/
v2 https://lore.kernel.org/all/20240529115149.630273-1-danishanwar@ti.com/
v3 https://lore.kernel.org/all/20240625153319.795665-1-danishanwar@ti.com/

MD Danish Anwar (6):
  dt-bindings: soc: ti: pruss: Add documentation for PA_STATS support
  net: ti: icssg_prueth: Add support for PA Stats
  arm64: dts: ti: k3-am65-main: Add ti,pruss-pa-st node
  arm64: dts: ti: k3-am654-icssg2: Add ti,pa-stats property
  arm64: dts: ti: k3-am64-main: Add ti,pruss-pa-st node
  arm64: dts: ti: k3-am64: Add ti,pa-stats property

 .../devicetree/bindings/soc/ti/ti,pruss.yaml  | 20 ++++++++++++
 arch/arm64/boot/dts/ti/k3-am64-main.dtsi      | 10 ++++++
 arch/arm64/boot/dts/ti/k3-am642-evm.dts       |  1 +
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi      | 15 +++++++++
 arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso   |  1 +
 arch/arm64/boot/dts/ti/k3-am654-idk.dtso      |  2 ++
 drivers/net/ethernet/ti/icssg/icssg_ethtool.c | 11 ++++++-
 drivers/net/ethernet/ti/icssg/icssg_prueth.c  |  6 ++++
 drivers/net/ethernet/ti/icssg/icssg_prueth.h  |  5 ++-
 drivers/net/ethernet/ti/icssg/icssg_stats.c   | 12 +++++--
 drivers/net/ethernet/ti/icssg/icssg_stats.h   | 32 +++++++++++++++++++
 11 files changed, 111 insertions(+), 4 deletions(-)

-- 
2.34.1

[PATCH v4 1/6] dt-bindings: soc: ti: pruss: Add documentation for PA_STATS support

[MD Danish Anwar]

Add documentation for pa-stats node which is syscon regmap for
PA_STATS registers. This will be used to dump statistics maintained by
ICSSG firmware.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
---
 .../devicetree/bindings/soc/ti/ti,pruss.yaml  | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
index c402cb2928e8..3cb1471cc6b6 100644
--- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
+++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
@@ -278,6 +278,26 @@ patternProperties:
 
     additionalProperties: false
 
+  ^pa-stats@[a-f0-9]+$:
+    description: |
+      PA-STATS sub-module represented as a SysCon. PA_STATS is a set of
+      registers where different statistics related to ICSSG, are dumped by
+      ICSSG firmware. This syscon sub-module will help the device to
+      access/read/write those statistics.
+
+    type: object
+
+    additionalProperties: false
+
+    properties:
+      compatible:
+        items:
+          - const: ti,pruss-pa-st
+          - const: syscon
+
+      reg:
+        maxItems: 1
+
   interrupt-controller@[a-f0-9]+$:
     description: |
       PRUSS INTC Node. Each PRUSS has a single interrupt controller instance
-- 
2.34.1

[DO NOT MERGE][PATCH v4 2/6] net: ti: icssg_prueth: Add support for PA Stats

[MD Danish Anwar]

Add support for dumping PA stats registers

Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
---
 drivers/net/ethernet/ti/icssg/icssg_ethtool.c | 11 ++++++-
 drivers/net/ethernet/ti/icssg/icssg_prueth.c  |  6 ++++
 drivers/net/ethernet/ti/icssg/icssg_prueth.h  |  5 ++-
 drivers/net/ethernet/ti/icssg/icssg_stats.c   | 12 +++++--
 drivers/net/ethernet/ti/icssg/icssg_stats.h   | 32 +++++++++++++++++++
 5 files changed, 62 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/ti/icssg/icssg_ethtool.c b/drivers/net/ethernet/ti/icssg/icssg_ethtool.c
index 5688f054cec5..713ce95d5baf 100644
--- a/drivers/net/ethernet/ti/icssg/icssg_ethtool.c
+++ b/drivers/net/ethernet/ti/icssg/icssg_ethtool.c
@@ -90,6 +90,12 @@ static void emac_get_strings(struct net_device *ndev, u32 stringset, u8 *data)
 				p += ETH_GSTRING_LEN;
 			}
 		}
+
+		for (i = 0; i < ICSSG_NUM_PA_STATS; i++) {
+			memcpy(p, icssg_all_pa_stats[i].name, ETH_GSTRING_LEN);
+			p += ETH_GSTRING_LEN;
+		}
+
 		break;
 	default:
 		break;
@@ -100,13 +106,16 @@ static void emac_get_ethtool_stats(struct net_device *ndev,
 				   struct ethtool_stats *stats, u64 *data)
 {
 	struct prueth_emac *emac = netdev_priv(ndev);
-	int i;
+	int i, j;
 
 	emac_update_hardware_stats(emac);
 
 	for (i = 0; i < ARRAY_SIZE(icssg_all_stats); i++)
 		if (!icssg_all_stats[i].standard_stats)
 			*(data++) = emac->stats[i];
+
+	for (j = 0; j < ICSSG_NUM_PA_STATS; j++)
+		*(data++) = emac->stats[i + j];
 }
 
 static int emac_get_ts_info(struct net_device *ndev,
diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
index 3e51b3a9b0a5..04bf7f1e14ff 100644
--- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c
+++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
@@ -1181,6 +1181,12 @@ static int prueth_probe(struct platform_device *pdev)
 		return -ENODEV;
 	}
 
+	prueth->pa_stats = syscon_regmap_lookup_by_phandle(np, "ti,pa-stats");
+	if (IS_ERR(prueth->pa_stats)) {
+		dev_err(dev, "couldn't get ti,pa-stats syscon regmap\n");
+		return -ENODEV;
+	}
+
 	if (eth0_node) {
 		ret = prueth_get_cores(prueth, ICSS_SLICE0, false);
 		if (ret)
diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.h b/drivers/net/ethernet/ti/icssg/icssg_prueth.h
index f678d656a3ed..ac2291d22c42 100644
--- a/drivers/net/ethernet/ti/icssg/icssg_prueth.h
+++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.h
@@ -50,8 +50,10 @@
 
 #define ICSSG_MAX_RFLOWS	8	/* per slice */
 
+#define ICSSG_NUM_PA_STATS 4
+#define ICSSG_NUM_MII_G_RT_STATS 60
 /* Number of ICSSG related stats */
-#define ICSSG_NUM_STATS 60
+#define ICSSG_NUM_STATS (ICSSG_NUM_MII_G_RT_STATS + ICSSG_NUM_PA_STATS)
 #define ICSSG_NUM_STANDARD_STATS 31
 #define ICSSG_NUM_ETHTOOL_STATS (ICSSG_NUM_STATS - ICSSG_NUM_STANDARD_STATS)
 
@@ -263,6 +265,7 @@ struct prueth {
 	struct net_device *registered_netdevs[PRUETH_NUM_MACS];
 	struct regmap *miig_rt;
 	struct regmap *mii_rt;
+	struct regmap *pa_stats;
 
 	enum pruss_pru_id pru_id[PRUSS_NUM_PRUS];
 	struct platform_device *pdev;
diff --git a/drivers/net/ethernet/ti/icssg/icssg_stats.c b/drivers/net/ethernet/ti/icssg/icssg_stats.c
index 2fb150c13078..c3d081cad3ca 100644
--- a/drivers/net/ethernet/ti/icssg/icssg_stats.c
+++ b/drivers/net/ethernet/ti/icssg/icssg_stats.c
@@ -11,6 +11,7 @@
 
 #define ICSSG_TX_PACKET_OFFSET	0xA0
 #define ICSSG_TX_BYTE_OFFSET	0xEC
+#define ICSSG_FW_STATS_BASE	0x0248
 
 static u32 stats_base[] = {	0x54c,	/* Slice 0 stats start */
 				0xb18,	/* Slice 1 stats start */
@@ -22,8 +23,8 @@ void emac_update_hardware_stats(struct prueth_emac *emac)
 	int slice = prueth_emac_slice(emac);
 	u32 base = stats_base[slice];
 	u32 tx_pkt_cnt = 0;
-	u32 val;
-	int i;
+	u32 val, reg;
+	int i, j;
 
 	for (i = 0; i < ARRAY_SIZE(icssg_all_stats); i++) {
 		regmap_read(prueth->miig_rt,
@@ -40,6 +41,13 @@ void emac_update_hardware_stats(struct prueth_emac *emac)
 		if (icssg_all_stats[i].offset == ICSSG_TX_BYTE_OFFSET)
 			emac->stats[i] -= tx_pkt_cnt * 8;
 	}
+
+	for (j = 0; j < ICSSG_NUM_PA_STATS; j++) {
+		reg = ICSSG_FW_STATS_BASE + icssg_all_pa_stats[j].offset *
+		      PRUETH_NUM_MACS + slice * sizeof(u32);
+		regmap_read(prueth->pa_stats, reg, &val);
+		emac->stats[i + j] += val;
+	}
 }
 
 void icssg_stats_work_handler(struct work_struct *work)
diff --git a/drivers/net/ethernet/ti/icssg/icssg_stats.h b/drivers/net/ethernet/ti/icssg/icssg_stats.h
index 999a4a91276c..e834316092c9 100644
--- a/drivers/net/ethernet/ti/icssg/icssg_stats.h
+++ b/drivers/net/ethernet/ti/icssg/icssg_stats.h
@@ -77,6 +77,20 @@ struct miig_stats_regs {
 	u32 tx_bytes;
 };
 
+/**
+ * struct pa_stats_regs - ICSSG Firmware maintained PA Stats register
+ * @u32 fw_rx_cnt: Number of valid packets sent by Rx PRU to Host on PSI
+ * @u32 fw_tx_cnt: Number of valid packets copied by RTU0 to Tx queues
+ * @u32 fw_tx_pre_overflow: Host Egress Q (Pre-emptible) Overflow Counter
+ * @u32 fw_tx_exp_overflow: Host Egress Q (Express) Overflow Counter
+ */
+struct pa_stats_regs {
+	u32 fw_rx_cnt;
+	u32 fw_tx_cnt;
+	u32 fw_tx_pre_overflow;
+	u32 fw_tx_exp_overflow;
+};
+
 #define ICSSG_STATS(field, stats_type)			\
 {							\
 	#field,						\
@@ -84,12 +98,23 @@ struct miig_stats_regs {
 	stats_type					\
 }
 
+#define ICSSG_PA_STATS(field)			\
+{						\
+	#field,					\
+	offsetof(struct pa_stats_regs, field),	\
+}
+
 struct icssg_stats {
 	char name[ETH_GSTRING_LEN];
 	u32 offset;
 	bool standard_stats;
 };
 
+struct icssg_pa_stats {
+	char name[ETH_GSTRING_LEN];
+	u32 offset;
+};
+
 static const struct icssg_stats icssg_all_stats[] = {
 	/* Rx */
 	ICSSG_STATS(rx_packets, true),
@@ -155,4 +180,11 @@ static const struct icssg_stats icssg_all_stats[] = {
 	ICSSG_STATS(tx_bytes, true),
 };
 
+static const struct icssg_pa_stats icssg_all_pa_stats[] = {
+	ICSSG_PA_STATS(fw_rx_cnt),
+	ICSSG_PA_STATS(fw_tx_cnt),
+	ICSSG_PA_STATS(fw_tx_pre_overflow),
+	ICSSG_PA_STATS(fw_tx_exp_overflow),
+};
+
 #endif /* __NET_TI_ICSSG_STATS_H */
-- 
2.34.1

[DO NOT MERGE][PATCH v4 3/6] arm64: dts: ti: k3-am65-main: Add ti,pruss-pa-st node

[MD Danish Anwar]

Add pa-stats nodes to k3-am65-main.dtsi for all ICSSG instances.
This is needed to dump IET related statistics for ICSSG Driver.

Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
index 1af3dedde1f6..e681b74db235 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
@@ -1159,6 +1159,11 @@ icssg0_mii_g_rt: mii-g-rt@33000 {
 			reg = <0x33000 0x1000>;
 		};
 
+		icssg0_pa_stats: pa-stats@2c000 {
+			compatible = "ti,pruss-pa-st", "syscon";
+			reg = <0x2c000 0x1000>;
+		};
+
 		icssg0_intc: interrupt-controller@20000 {
 			compatible = "ti,icssg-intc";
 			reg = <0x20000 0x2000>;
@@ -1325,6 +1330,11 @@ icssg1_mii_g_rt: mii-g-rt@33000 {
 			reg = <0x33000 0x1000>;
 		};
 
+		icssg1_pa_stats: pa-stats@2c000 {
+			compatible = "ti,pruss-pa-st", "syscon";
+			reg = <0x2c000 0x1000>;
+		};
+
 		icssg1_intc: interrupt-controller@20000 {
 			compatible = "ti,icssg-intc";
 			reg = <0x20000 0x2000>;
@@ -1491,6 +1501,11 @@ icssg2_mii_g_rt: mii-g-rt@33000 {
 			reg = <0x33000 0x1000>;
 		};
 
+		icssg2_pa_stats: pa-stats@2c000 {
+			compatible = "ti,pruss-pa-st", "syscon";
+			reg = <0x2c000 0x1000>;
+		};
+
 		icssg2_intc: interrupt-controller@20000 {
 			compatible = "ti,icssg-intc";
 			reg = <0x20000 0x2000>;
-- 
2.34.1

[DO NOT MERGE][PATCH v4 4/6] arm64: dts: ti: k3-am654-icssg2: Add ti,pa-stats property

[MD Danish Anwar]

Add ti,pa-stats phandles to AM65x device trees. This is a phandle to
PA_STATS syscon regmap and will be used to dump IET related statistics
for ICSSG Driver

Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso | 1 +
 arch/arm64/boot/dts/ti/k3-am654-idk.dtso    | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso b/arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso
index 0a6e75265ba9..66bb0b913d49 100644
--- a/arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso
+++ b/arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso
@@ -41,6 +41,7 @@ icssg2_eth: icssg2-eth {
 
 		ti,mii-g-rt = <&icssg2_mii_g_rt>;
 		ti,mii-rt = <&icssg2_mii_rt>;
+		ti,pa-stats = <&icssg2_pa_stats>;
 		ti,iep = <&icssg2_iep0>, <&icssg2_iep1>;
 
 		interrupt-parent = <&icssg2_intc>;
diff --git a/arch/arm64/boot/dts/ti/k3-am654-idk.dtso b/arch/arm64/boot/dts/ti/k3-am654-idk.dtso
index 8bdb87fcbde0..e548f1c7991a 100644
--- a/arch/arm64/boot/dts/ti/k3-am654-idk.dtso
+++ b/arch/arm64/boot/dts/ti/k3-am654-idk.dtso
@@ -42,6 +42,7 @@ icssg0_eth: icssg0-eth {
 
 		ti,mii-g-rt = <&icssg0_mii_g_rt>;
 		ti,mii-rt = <&icssg0_mii_rt>;
+		ti,pa-stats = <&icssg0_pa_stats>;
 		ti,iep = <&icssg0_iep0>,  <&icssg0_iep1>;
 
 		interrupt-parent = <&icssg0_intc>;
@@ -110,6 +111,7 @@ icssg1_eth: icssg1-eth {
 
 		ti,mii-g-rt = <&icssg1_mii_g_rt>;
 		ti,mii-rt = <&icssg1_mii_rt>;
+		ti,pa-stats = <&icssg1_pa_stats>;
 		ti,iep = <&icssg1_iep0>,  <&icssg1_iep1>;
 
 		interrupt-parent = <&icssg1_intc>;
-- 
2.34.1

[DO NOT MERGE][PATCH v4 5/6] arm64: dts: ti: k3-am64-main: Add ti,pruss-pa-st node

[MD Danish Anwar]

Add pa-stats nodes to k3-am64-main.dtsi for all ICSSG instances.
This is needed to dump IET related statistics for ICSSG Driver.

Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
index f8370dd03350..090bfdc5f20c 100644
--- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
@@ -1257,6 +1257,11 @@ icssg0_mii_g_rt: mii-g-rt@33000 {
 			reg = <0x33000 0x1000>;
 		};
 
+		icssg0_pa_stats: pa-stats@2c000 {
+			compatible = "ti,pruss-pa-st", "syscon";
+			reg = <0x2c000 0x1000>;
+		};
+
 		icssg0_intc: interrupt-controller@20000 {
 			compatible = "ti,icssg-intc";
 			reg = <0x20000 0x2000>;
@@ -1422,6 +1427,11 @@ icssg1_mii_g_rt: mii-g-rt@33000 {
 			reg = <0x33000 0x1000>;
 		};
 
+		icssg1_pa_stats: pa-stats@2c000 {
+			compatible = "ti,pruss-pa-st", "syscon";
+			reg = <0x2c000 0x1000>;
+		};
+
 		icssg1_intc: interrupt-controller@20000 {
 			compatible = "ti,icssg-intc";
 			reg = <0x20000 0x2000>;
-- 
2.34.1

[DO NOT MERGE][PATCH v4 6/6] arm64: dts: ti: k3-am64: Add ti,pa-stats property

[MD Danish Anwar]

Add ti,pa-stats phandles to k3-am64x-evm.dts. This is a phandle to
PA_STATS syscon regmap and will be used to dump IET related statistics
for ICSSG Driver

Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am642-evm.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
index 6bb1ad2e56ec..dcb28d3e7379 100644
--- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
@@ -253,6 +253,7 @@ icssg1_eth: icssg1-eth {
 		ti,mii-g-rt = <&icssg1_mii_g_rt>;
 		ti,mii-rt = <&icssg1_mii_rt>;
 		ti,iep = <&icssg1_iep0>,  <&icssg1_iep1>;
+		ti,pa-stats = <&icssg1_pa_stats>;
 		interrupt-parent = <&icssg1_intc>;
 		interrupts = <24 0 2>, <25 1 3>;
 		interrupt-names = "tx_ts0", "tx_ts1";
-- 
2.34.1

Re: [DO NOT MERGE][PATCH v4 6/6] arm64: dts: ti: k3-am64: Add ti,pa-stats property

[Nishanth Menon]

On 17:02-20240729, MD Danish Anwar wrote:
> Add ti,pa-stats phandles to k3-am64x-evm.dts. This is a phandle to
> PA_STATS syscon regmap and will be used to dump IET related statistics
> for ICSSG Driver
> 
> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> Reviewed-by: Roger Quadros <rogerq@kernel.org>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am642-evm.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> index 6bb1ad2e56ec..dcb28d3e7379 100644
> --- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> @@ -253,6 +253,7 @@ icssg1_eth: icssg1-eth {
>  		ti,mii-g-rt = <&icssg1_mii_g_rt>;
>  		ti,mii-rt = <&icssg1_mii_rt>;
>  		ti,iep = <&icssg1_iep0>,  <&icssg1_iep1>;
> +		ti,pa-stats = <&icssg1_pa_stats>;

Follow:  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n117
for ordering properties.
>  		interrupt-parent = <&icssg1_intc>;
>  		interrupts = <24 0 2>, <25 1 3>;
>  		interrupt-names = "tx_ts0", "tx_ts1";
> -- 
> 2.34.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [DO NOT MERGE][PATCH v4 6/6] arm64: dts: ti: k3-am64: Add ti,pa-stats property

[MD Danish Anwar]

On 30/07/24 5:38 pm, Nishanth Menon wrote:
> On 17:02-20240729, MD Danish Anwar wrote:
>> Add ti,pa-stats phandles to k3-am64x-evm.dts. This is a phandle to
>> PA_STATS syscon regmap and will be used to dump IET related statistics
>> for ICSSG Driver
>>
>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>> Reviewed-by: Roger Quadros <rogerq@kernel.org>
>> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
>> ---
>>  arch/arm64/boot/dts/ti/k3-am642-evm.dts | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
>> index 6bb1ad2e56ec..dcb28d3e7379 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
>> @@ -253,6 +253,7 @@ icssg1_eth: icssg1-eth {
>>  		ti,mii-g-rt = <&icssg1_mii_g_rt>;
>>  		ti,mii-rt = <&icssg1_mii_rt>;
>>  		ti,iep = <&icssg1_iep0>,  <&icssg1_iep1>;
>> +		ti,pa-stats = <&icssg1_pa_stats>;
> 
> Follow:  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n117
> for ordering properties.

Sure Nishant, I will take care of ordering properties when I post these
DTS patches for merge.

For now, I have posted DTS patches only for reference and only the
dt-binding patch is for merging.

>>  		interrupt-parent = <&icssg1_intc>;
>>  		interrupts = <24 0 2>, <25 1 3>;
>>  		interrupt-names = "tx_ts0", "tx_ts1";
>> -- 
>> 2.34.1
>>
> 

-- 
Thanks and Regards,
Danish

Re: [PATCH v4 1/6] dt-bindings: soc: ti: pruss: Add documentation for PA_STATS support

[Roger Quadros]

On 29/07/2024 14:32, MD Danish Anwar wrote:
> Add documentation for pa-stats node which is syscon regmap for
> PA_STATS registers. This will be used to dump statistics maintained by
> ICSSG firmware.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: tags should come after Author's Signed-off-by:

> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>

Reviewed-by: Roger Quadros <rogerq@kernel.org>

Re: [PATCH v4 1/6] dt-bindings: soc: ti: pruss: Add documentation for PA_STATS support

[Nishanth Menon]

On 09:42-20240805, Roger Quadros wrote:
> 
> 
> On 29/07/2024 14:32, MD Danish Anwar wrote:
> > Add documentation for pa-stats node which is syscon regmap for
> > PA_STATS registers. This will be used to dump statistics maintained by
> > ICSSG firmware.
> > 
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Reviewed-by: tags should come after Author's Signed-off-by:
> 
> > Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> 
> Reviewed-by: Roger Quadros <rogerq@kernel.org>

If the net maintainers are OK, they could potentially take the binding
patch along with the driver mods corresponding to this - I am a bit
unsure of picking up a binding if the driver implementation is heading
the wrong way.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH v4 1/6] dt-bindings: soc: ti: pruss: Add documentation for PA_STATS support

[MD Danish Anwar]

On 06/08/24 8:33 pm, Nishanth Menon wrote:
> On 09:42-20240805, Roger Quadros wrote:
>>
>>
>> On 29/07/2024 14:32, MD Danish Anwar wrote:
>>> Add documentation for pa-stats node which is syscon regmap for
>>> PA_STATS registers. This will be used to dump statistics maintained by
>>> ICSSG firmware.
>>>
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> Reviewed-by: tags should come after Author's Signed-off-by:
>>
>>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>>
>> Reviewed-by: Roger Quadros <rogerq@kernel.org>
> 
> If the net maintainers are OK, they could potentially take the binding
> patch along with the driver mods corresponding to this - I am a bit
> unsure of picking up a binding if the driver implementation is heading
> the wrong way.
> 

Hi Jakub, Paolo, David, Andrew,

Will it be okay to pick this binding patch to net-next tree. Nishant is
suggesting since the driver changes are done in drivers/net/ the binding
can be picked by net maintainers.

Please let us know if it will be okay to take this binding to net-next.
I can post a new series with just the binding and the driver patch to
net-next if needed.

-- 
Thanks and Regards,
Danish

Re: [PATCH v4 1/6] dt-bindings: soc: ti: pruss: Add documentation for PA_STATS support

[Jakub Kicinski]

On Mon, 12 Aug 2024 11:20:56 +0530 MD Danish Anwar wrote:
> > If the net maintainers are OK, they could potentially take the binding
> > patch along with the driver mods corresponding to this - I am a bit
> > unsure of picking up a binding if the driver implementation is heading
> > the wrong way.   
> 
> Hi Jakub, Paolo, David, Andrew,
> 
> Will it be okay to pick this binding patch to net-next tree. Nishant is
> suggesting since the driver changes are done in drivers/net/ the binding
> can be picked by net maintainers.
> 
> Please let us know if it will be okay to take this binding to net-next.
> I can post a new series with just the binding and the driver patch to
> net-next if needed.

Nishanth, could you send an official Ack tag?

No problem with merging it via net-next.
On the code itself you may want to use ethtool_puts().

Re: [PATCH v4 1/6] dt-bindings: soc: ti: pruss: Add documentation for PA_STATS support

[Nishanth Menon]

On 17:22-20240812, Jakub Kicinski wrote:
> On Mon, 12 Aug 2024 11:20:56 +0530 MD Danish Anwar wrote:
> > > If the net maintainers are OK, they could potentially take the binding
> > > patch along with the driver mods corresponding to this - I am a bit
> > > unsure of picking up a binding if the driver implementation is heading
> > > the wrong way.   
> > 
> > Hi Jakub, Paolo, David, Andrew,
> > 
> > Will it be okay to pick this binding patch to net-next tree. Nishant is
> > suggesting since the driver changes are done in drivers/net/ the binding
> > can be picked by net maintainers.
> > 
> > Please let us know if it will be okay to take this binding to net-next.
> > I can post a new series with just the binding and the driver patch to
> > net-next if needed.
> 
> Nishanth, could you send an official Ack tag?

Acked-by: Nishanth Menon <nm@ti.com>

Thanks Jakub.

> 
> No problem with merging it via net-next.
> On the code itself you may want to use ethtool_puts().
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH v4 1/6] dt-bindings: soc: ti: pruss: Add documentation for PA_STATS support

[MD Danish Anwar]

On 13/08/24 5:52 am, Jakub Kicinski wrote:
> On Mon, 12 Aug 2024 11:20:56 +0530 MD Danish Anwar wrote:
>>> If the net maintainers are OK, they could potentially take the binding
>>> patch along with the driver mods corresponding to this - I am a bit
>>> unsure of picking up a binding if the driver implementation is heading
>>> the wrong way.   
>>
>> Hi Jakub, Paolo, David, Andrew,
>>
>> Will it be okay to pick this binding patch to net-next tree. Nishant is
>> suggesting since the driver changes are done in drivers/net/ the binding
>> can be picked by net maintainers.
>>
>> Please let us know if it will be okay to take this binding to net-next.
>> I can post a new series with just the binding and the driver patch to
>> net-next if needed.
> 
> Nishanth, could you send an official Ack tag?
> 
> No problem with merging it via net-next.
> On the code itself you may want to use ethtool_puts().

Thanks Jakub, I will send out a new series with just the binding and
driver patch and send it to net-next. I will take care of ethtool_puts().

-- 
Thanks and Regards,
Danish