Re: [PATCH 1/4] dt-bindings: brcmstb-hwspinlock: support for hwspinlock

[Krzysztof Kozlowski <krzk@kernel.org>]

On 11/07/2025 17:42, Kamal Dasu wrote:
> From: Kamal Dasu <kdasu@broadcom.com>
> 
> Adding brcmstb_hwspinlock bindings.
> 
> Signed-off-by: Kamal Dasu <kamal.dasu@broadcom.com>

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

missing hwlock prefix

> ---
>  .../hwlock/brcm,brcmstb-hwspinlock.yaml       | 36 +++++++++++++++++++
>  1 file changed, 36 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwlock/brcm,brcmstb-hwspinlock.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwlock/brcm,brcmstb-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/brcm,brcmstb-hwspinlock.yaml
> new file mode 100644
> index 000000000000..b49ead166b1e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwlock/brcm,brcmstb-hwspinlock.yaml
> @@ -0,0 +1,36 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwlock/brcm,brcmstb-hwspinlock.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom settop Hardware Spinlock
> +
> +maintainers:
> +  - Kamal Dasu <kamal.dasu@broadcom.com>
> +
> +properties:
> +  "#hwlock-cells":
> +    const: 1
> +
> +  compatible:
> +    const: brcm,brcmstb-hwspinlock

Please use SoC specific compatibles. Then also filename will change.

Compatible always goes first. See 99% of other bindings and DTS coding
style.

> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - "#hwlock-cells"
> +  - compatible

Same here

> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    hwspinlock@8404038 {

hwlock@

> +        compatible = "brcm,brcmstb-hwspinlock";

And this you got right...

> +        #hwlock-cells = <1>;
> +        reg = <0x8404038 0x40>;

But this not. Use order from DTS codinh style.

> +    };
> +


Best regards,
Krzysztof