From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75130C25B0E for ; Tue, 16 Aug 2022 11:20:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234459AbiHPLUS (ORCPT ); Tue, 16 Aug 2022 07:20:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233256AbiHPLTz (ORCPT ); Tue, 16 Aug 2022 07:19:55 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E369DE2C51 for ; Tue, 16 Aug 2022 02:44:40 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id v2so14179865lfi.6 for ; Tue, 16 Aug 2022 02:44:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=Enloy5lgKrMKVLbqE4UqCEXL8D9Wgy3KUpK/qyBoIrI=; b=bmhY0kYxRm0Pu1Cs0YlMSETk0hz7OlpKbOUt8eVnlNIeRbuboqVaSXl/78n+u1O29t RWkFw0mRgGs6O9xp37PVWEjfbpC9cvfDuPeJDbI1CWUKikDaalsk6P+uWh8uNsnn+f/P QIFsP8CfQuNuSIih2QvNTFRYGLDmv2wNF3ku4sXH+o83ZAkPRnbVk/wplO4egti048ZD ErxTSkVmZxvFPLxaqXZd1gC4KD0DYq32h2XL+NCU4wmEzS981G+5fm+K2KJHHNjFk5CC UzE9+Q6LCgzSP1ffDEM/NbheuzW8sp649Ns0J1nneXwCLJwPo+miQhcLwuRVAiQukuJU I7aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=Enloy5lgKrMKVLbqE4UqCEXL8D9Wgy3KUpK/qyBoIrI=; b=1N4J7BRb5aEM3CwzxM7R3mtXwzt2RAgHMGc8hqvWXgTwjKg8nQ767I69ItQylsl3pB zwEVcIQubKMQbX3nK7zZYyN13CiDZASzdAQMGRWR6tqTx+a3+KR2ouMxp3KHx46rhSqS DGlmULwHHjbuiAexfurBpmjJ79mas3lAWxPAUPqTbgUCfZ88JQ+7/jrSjQNTd7cD+Tvd u2NLL+7vdBzoa20LPjWr9Fu5DXFOqU/JVEJTyZQr6TyP9oGXnBU/PHsaZWd5QQ27YhvR dFivxUQbG+dBwsDSN8RDp3ZrzUcUsFd1Za2sQ+cC8X8AHQ1TTfbEM09aUA005JWvpqZE bakQ== X-Gm-Message-State: ACgBeo0Bs/+fwsxO/8sFAXMdb+lcdnWC8SVP+AiciBTLBWimPGy2I1Q7 Sdhe4u/sQZBKi+RamM082ceVyg== X-Google-Smtp-Source: AA6agR54PZx7XS1rYcJtMRhTAqOXN6+VFqLfzj/NiD8GAFWFKJ+lry6TmRGXna2tZtdoMf6GdwYMxQ== X-Received: by 2002:ac2:44af:0:b0:48a:f361:fe1d with SMTP id c15-20020ac244af000000b0048af361fe1dmr7226313lfm.190.1660643079100; Tue, 16 Aug 2022 02:44:39 -0700 (PDT) Received: from ?IPV6:2001:14bb:ae:539c:1782:dd68:b0c1:c1a4? (d15l54g8c71znbtrbzt-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1782:dd68:b0c1:c1a4]) by smtp.gmail.com with ESMTPSA id z12-20020a056512370c00b0048b08e25979sm1330665lfr.199.2022.08.16.02.44.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Aug 2022 02:44:38 -0700 (PDT) Message-ID: Date: Tue, 16 Aug 2022 12:44:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 0/6] i2c-imx-lpi2c: add IPG clock Content-Language: en-US To: Peng Fan , "Peng Fan (OSS)" , Aisheng Dong , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" Cc: "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "linux-i2c@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Clark Wang References: <20220812043424.4078034-1-peng.fan@oss.nxp.com> <039566a7-5c65-b2d8-7b45-c616863cb292@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16/08/2022 11:43, Peng Fan wrote: >> No. For such patch ABI break is also not allowed in that case. Just make the >> driver backwards compatible and both problems - non bisectability and ABI >> break - go away. > > One more point that I am not very clear about > "non bisectability and ABI break " > > ABI, I suppose you mean dt-binding, right? > The I2C bindings and dts update will go through different tree, I think. So > dtbs_check may fail considering the PR merge order. ABI break means breaking Application Binary Interface, so out of tree DTS conforming to old bindings stop working with new kernel. ABI is described by bindings and implemented by driver. You broke it in the driver. Best regards, Krzysztof