devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: Re: [PATCH v1 4/6] dt-bindings: memory: tegra20: mc: Convert to schema
Date: Tue, 30 Mar 2021 18:25:51 +0300	[thread overview]
Message-ID: <b638a15f-c824-0b00-bc9a-25759512b7db@gmail.com> (raw)
In-Reply-To: <01daabba-9023-8d78-9386-99b974d46faf@canonical.com>

30.03.2021 11:37, Krzysztof Kozlowski пишет:
>> +properties:
>> +  compatible:
>> +    const: nvidia,tegra20-mc-gart
>> +
>> +  reg:
>> +    minItems: 1
>> +    maxItems: 2
> I think you always need two regs, don't you? If so, then better to use
> "description" like in
> Documentation/devicetree/bindings/example-schema.yaml to describe which
> set is for which range/purpose.

I did this because the original example from the txt binding was failing
with:

Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-mc.example.dt.yaml:
memory-controller@7000f000: reg: [[1879109632, 1024, 1476395008,
33554432]] is too short

But then I just corrected the example and forgot to change the reg
entry. I'll fix it in v2, thanks.

  reply	other threads:[~2021-03-30 15:26 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-29 19:45 [PATCH v1 0/6] NVIDIA Tegra memory improvements Dmitry Osipenko
2021-03-29 19:45 ` [PATCH v1 1/6] dt-bindings: memory: tegra20: emc: Replace core regulator with power domain Dmitry Osipenko
2021-03-29 19:45 ` [PATCH v1 2/6] dt-bindings: memory: tegra30: " Dmitry Osipenko
2021-03-30 22:23   ` Rob Herring
2021-03-30 22:31     ` Dmitry Osipenko
2021-03-29 19:45 ` [PATCH v1 3/6] dt-bindings: memory: tegra124: " Dmitry Osipenko
2021-03-29 19:46 ` [PATCH v1 4/6] dt-bindings: memory: tegra20: mc: Convert to schema Dmitry Osipenko
2021-03-30  8:37   ` Krzysztof Kozlowski
2021-03-30 15:25     ` Dmitry Osipenko [this message]
2021-03-30 13:08   ` Rob Herring
2021-03-30 13:46     ` Rob Herring
2021-03-30 15:25       ` Dmitry Osipenko
2021-03-29 19:46 ` [PATCH v1 5/6] dt-bindings: memory: tegra20: emc: " Dmitry Osipenko
2021-03-30  8:48   ` Krzysztof Kozlowski
2021-03-30 15:29     ` Dmitry Osipenko
2021-03-30 15:56       ` Dmitry Osipenko
2021-03-30 22:33         ` Rob Herring
2021-03-30 15:32     ` Dmitry Osipenko
2021-03-30 22:35       ` Rob Herring
2021-03-30 15:34     ` Dmitry Osipenko
2021-03-29 19:46 ` [PATCH v1 6/6] memory: tegra: Print out info-level once per driver probe Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b638a15f-c824-0b00-bc9a-25759512b7db@gmail.com \
    --to=digetx@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).