From: Krzysztof Kozlowski <krzk@kernel.org>
To: xianwei.zhao@amlogic.com,
Neil Armstrong <neil.armstrong@linaro.org>,
Jerome Brunet <jbrunet@baylibre.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Chuan Liu <chuan.liu@amlogic.com>,
Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: clock: fix C3 PLL input parameter
Date: Tue, 6 Aug 2024 15:10:53 +0200 [thread overview]
Message-ID: <b63fe216-ee29-489e-a175-e1525ac12722@kernel.org> (raw)
In-Reply-To: <20240806-c3_add_node-v1-1-c0de41341632@amlogic.com>
On 06/08/2024 12:27, Xianwei Zhao via B4 Relay wrote:
> From: Xianwei Zhao <xianwei.zhao@amlogic.com>
>
> Add C3 PLL controller input clock parameters "fix".
What is "parameters" here? Why you are adding it? Is it missing?
Something is not working?
>
> Fixes: 0e6be855a96d ("dt-bindings: clock: add Amlogic C3 PLL clock controller")
Why? What bug are you fixing?
> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
> ---
> Documentation/devicetree/bindings/clock/amlogic,c3-pll-clkc.yaml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/amlogic,c3-pll-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,c3-pll-clkc.yaml
> index 43de3c6fc1cf..700865cc9792 100644
> --- a/Documentation/devicetree/bindings/clock/amlogic,c3-pll-clkc.yaml
> +++ b/Documentation/devicetree/bindings/clock/amlogic,c3-pll-clkc.yaml
> @@ -24,11 +24,13 @@ properties:
> items:
> - description: input top pll
> - description: input mclk pll
> + - description: input fix pll
>
> clock-names:
> items:
> - const: top
> - const: mclk
> + - const: fix
and that's not an ABI break because?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-06 13:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 10:27 [PATCH 0/3] add some node for amlogic c3 Xianwei Zhao via B4 Relay
2024-08-06 10:27 ` [PATCH 1/3] dt-bindings: clock: fix C3 PLL input parameter Xianwei Zhao via B4 Relay
2024-08-06 13:10 ` Krzysztof Kozlowski [this message]
2024-08-07 1:55 ` Xianwei Zhao
2024-08-07 5:44 ` Krzysztof Kozlowski
2024-08-07 6:40 ` Xianwei Zhao
2024-08-07 7:01 ` Krzysztof Kozlowski
2024-08-07 7:56 ` Jerome Brunet
2024-08-07 8:07 ` Krzysztof Kozlowski
2024-08-07 8:23 ` Xianwei Zhao
2024-08-06 10:27 ` [PATCH 2/3] arm64: dts: amlogic: add some device nodes for C3 Xianwei Zhao via B4 Relay
2024-08-06 13:13 ` Krzysztof Kozlowski
2024-08-07 5:54 ` Xianwei Zhao
2024-08-07 6:38 ` Krzysztof Kozlowski
2024-08-06 10:27 ` [PATCH 3/3] arm64: dts: amlogic: add C3 AW419 board Xianwei Zhao via B4 Relay
2024-08-06 13:14 ` Krzysztof Kozlowski
2024-08-07 2:37 ` Xianwei Zhao
2024-08-07 5:44 ` Krzysztof Kozlowski
2024-08-07 7:25 ` Xianwei Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b63fe216-ee29-489e-a175-e1525ac12722@kernel.org \
--to=krzk@kernel.org \
--cc=chuan.liu@amlogic.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=xianwei.zhao@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).