From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org
Cc: robh+dt@kernel.org, palmer@dabbelt.com,
krzysztof.kozlowski+dt@linaro.org, zong.li@sifive.com,
linux-kernel@lists.codethink.co.uk,
sudip.mukherjee@codethink.co.uk,
Paul Walmsley <paul.walmsley@sifive.com>,
Greentime Hu <greentime.hu@sifive.com>
Subject: Re: [PATCH] riscv: dts: fu740: fix size of pcie 32bit memory
Date: Fri, 6 Jan 2023 14:51:04 +0000 [thread overview]
Message-ID: <b64bfeff-e1e8-02d5-0a7d-c2a0a905da5e@codethink.co.uk> (raw)
In-Reply-To: <422275a4-b082-2951-71f2-04f33e036438@linaro.org>
On 06/01/2023 14:07, Krzysztof Kozlowski wrote:
> On 06/01/2023 14:44, Ben Dooks wrote:
>> The 32-bit memory resource is needed for non-prefetchable memory
>> allocations on the PCIe bus, however with some cards (such as the
>> SM768) the system fails to allocate memory from this.
>>
>> Checking the allocation against the datasheet, it looks like there
>> has been a mis-calcualation of the resource for the first memory
>> region (0x0060090000..0x0070ffffff) which in the data-sheet for
>> the fu740 (v1p2) is from 0x0060000000..0x007fffffff. Changing
>> this to allocate from 0x0060090000..0x007fffffff fixes the probing
>> issues.
>>
>> Fixes: ae80d514808557018e44190 ("riscv: dts: Add PCIe support for the SiFive FU740-C000 SoC
>> ")
>
> Don't wrap lines.
>
>>
>
> Drop empty line between tags.
Thanks, will fix.
Does anyone have a chance to review and/or test this, it works for me
but I've not got a large number of devices to test with.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
next prev parent reply other threads:[~2023-01-06 14:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 13:44 [PATCH] riscv: dts: fu740: fix size of pcie 32bit memory Ben Dooks
2023-01-06 14:07 ` Krzysztof Kozlowski
2023-01-06 14:51 ` Ben Dooks [this message]
2023-01-06 14:52 ` [Linux-kernel] " Ben Dooks
2023-01-06 14:55 ` Conor Dooley
2023-01-07 19:37 ` Conor Dooley
2023-01-09 8:02 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b64bfeff-e1e8-02d5-0a7d-c2a0a905da5e@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=devicetree@vger.kernel.org \
--cc=greentime.hu@sifive.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sudip.mukherjee@codethink.co.uk \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).