From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E748EC2D0A3 for ; Mon, 26 Oct 2020 09:22:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 913D720759 for ; Mon, 26 Oct 2020 09:22:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603704164; bh=9bGBZBL3goz2M7aEw4HfoQSjkGDjjJczOlwQhkmLLjI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=t8kMwKXAblK5oM6NByC/W1k5LwUxGlgGlvOYZ9mKaGdYjS76WNF2R2uTncHMEC58O f1jam5m5ybxwZJ/o4/irBS0R3Vix9zpq+Occ40rygtItcm4h5HAewi4fwuxAw9Cx/j MA00W7z03syfCax+phSjeF7sc2j6su9r8BvKg9h0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729422AbgJZJWo (ORCPT ); Mon, 26 Oct 2020 05:22:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:36084 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728311AbgJZJWn (ORCPT ); Mon, 26 Oct 2020 05:22:43 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DDDB020747; Mon, 26 Oct 2020 09:22:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603704163; bh=9bGBZBL3goz2M7aEw4HfoQSjkGDjjJczOlwQhkmLLjI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DBPRPN6HRCiBWp0REQ1JWvTIS+wog+0wQLEtDtZDh289UH1CuzyKeQOShpZjzLuB5 Z2mzCcT9qf/TzHwGWfjAVr0JxQFw4V18Lr7UlxioJrIi0IEA8bGTlqyo15d/E1BCsl jYtWnZjX/S4CMbyiQ50CxbCh43NFoLNIJMlFUSPw= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kWyi8-004HIY-Or; Mon, 26 Oct 2020 09:22:40 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 26 Oct 2020 09:22:40 +0000 From: Marc Zyngier To: Rasmus Villemoes Cc: Biwen Li , shawnguo@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, leoyang.li@nxp.com, zhiqiang.hou@nxp.com, tglx@linutronix.de, jason@lakedaemon.net, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, jiafei.pan@nxp.com, xiaobo.xie@nxp.com, linux-arm-kernel@lists.infradead.org, Biwen Li Subject: Re: [RESEND 01/11] irqchip: ls-extirq: Add LS1043A, LS1088A external interrupt In-Reply-To: <3448c822-31b1-7f9d-fedf-49912418fc3f@rasmusvillemoes.dk> References: <20201026080127.40499-1-biwen.li@oss.nxp.com> <31d8971374c261003aee9f4807c8ac8c@kernel.org> <3448c822-31b1-7f9d-fedf-49912418fc3f@rasmusvillemoes.dk> User-Agent: Roundcube Webmail/1.4.9 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: linux@rasmusvillemoes.dk, biwen.li@oss.nxp.com, shawnguo@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, leoyang.li@nxp.com, zhiqiang.hou@nxp.com, tglx@linutronix.de, jason@lakedaemon.net, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, jiafei.pan@nxp.com, xiaobo.xie@nxp.com, linux-arm-kernel@lists.infradead.org, biwen.li@nxp.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2020-10-26 09:06, Rasmus Villemoes wrote: > On 26/10/2020 09.44, Marc Zyngier wrote: >> On 2020-10-26 08:01, Biwen Li wrote: >>> From: Hou Zhiqiang >>> >>> Add an new IRQ chip declaration for LS1043A and LS1088A >>> - compatible "fsl,ls1043a-extirq" for LS1043A, LS1046A >>> - compatible "fsl,ls1088a-extirq" for LS1088A, LS208xA, LX216xA >> >> Three things: >> - This commit message doesn't describe the bit_reverse change > > Yeah, please elaborate on that, as the RM for 1043 or 1046 doesn't > mention anything about bit reversal for the scfg registers - they don't > seem to have the utter nonsense that is SCFG_SCFGREVCR, but perhaps, > instead of removing it, that has just become a hard-coded part of the > IP. > > Also, IANAL etc., but > >>> +// Copyright 2019-2020 NXP > > really? Seems to be a bit of a stretch. > > At the very least, cc'ing the original author and only person to ever > touch that file would have been appreciated. Huh. Well spotted. That's definitely not on. NXP people, please talk to your legal department. M. -- Jazz is not dead. It just smells funny...