From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Mitja Špes" <mitja@lxnav.com>
Cc: linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Tomasz Duszynski <tduszyns@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] doc: iio: pressure: ms5611: added max SPI frequency setting to the example
Date: Thu, 20 Oct 2022 08:00:28 -0400 [thread overview]
Message-ID: <b682cf05-2d96-d7e4-6f86-b1776d16b132@linaro.org> (raw)
In-Reply-To: <CACbQKWdyE2Q7wya4JwAv2+9-1M3oSrB3YfR+qfM3M7TiHjukew@mail.gmail.com>
On 20/10/2022 01:40, Mitja Špes wrote:
> On Wed, Oct 19, 2022 at 5:49 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>
>> Use subject prefixes matching the subsystem (git log --oneline -- ...).
>
> Will do.
>
>> Whether it is honored by driver it matters less. More important is how
>> hardware can handle it. This should be included in the bindings/properties.
>
> The hardware handles frequencies up to 20MHz. That constraint is already
> written in meas,ms5611.yaml.
> What my patch 2 does is allow the user to set a lower frequency and the patch
> 3 just emphasises that in the example.
Then I am not sure whether it is worth changing. This is just an
example. Old value is correct.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-20 12:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 12:52 [PATCH 1/3] iio: pressure: ms5611: fixed value compensation bug Mitja Spes
2022-10-19 12:52 ` [PATCH 2/3] iio: pressure: ms5611: changed hardcoded SPI speed to value limited Mitja Spes
2022-10-19 12:52 ` [PATCH 3/3] doc: iio: pressure: ms5611: added max SPI frequency setting to the example Mitja Spes
2022-10-19 13:23 ` Andy Shevchenko
2022-10-20 5:31 ` Mitja Špes
2022-10-19 15:49 ` Krzysztof Kozlowski
2022-10-20 5:40 ` Mitja Špes
2022-10-20 12:00 ` Krzysztof Kozlowski [this message]
2022-10-19 13:24 ` [PATCH 1/3] iio: pressure: ms5611: fixed value compensation bug Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b682cf05-2d96-d7e4-6f86-b1776d16b132@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mitja@lxnav.com \
--cc=robh+dt@kernel.org \
--cc=tduszyns@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).