* Re: [PATCH] dt-bindings: watchdog: atmel: Add missing 'interrupts' property
2021-12-06 17:40 [PATCH] dt-bindings: watchdog: atmel: Add missing 'interrupts' property Rob Herring
@ 2021-12-06 19:47 ` Guenter Roeck
2021-12-07 8:23 ` Thierry Reding
2021-12-07 10:14 ` Nicolas Ferre
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2021-12-06 19:47 UTC (permalink / raw)
To: Rob Herring
Cc: Wim Van Sebroeck, Nicolas Ferre, Alexandre Belloni,
Ludovic Desroches, Eugen Hristev, devicetree, Thierry Reding,
linux-watchdog, linux-arm-kernel, linux-kernel
On Mon, Dec 06, 2021 at 11:40:45AM -0600, Rob Herring wrote:
> With 'unevaluatedProperties' support implemented, the atmel,sama5d4-wdt
> example has the following warning:
>
> /home/rob/proj/git/linux-dt/.build-arm64/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.example.dt.yaml: watchdog@fc068640: Unevaluated properties are not allowed ('interrupts' was unexpected)
>
> Document the missing 'interrupts' property.
>
> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
> Cc: Eugen Hristev <eugen.hristev@microchip.com>
> Cc: linux-watchdog@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Guenter Roeck <linux@roeck-us.net>
> ---
> .../devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml b/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> index 9856cd76c28d..a9635c03761c 100644
> --- a/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> @@ -22,6 +22,9 @@ properties:
> reg:
> maxItems: 1
>
> + interrupts:
> + maxItems: 1
> +
> atmel,watchdog-type:
> $ref: /schemas/types.yaml#/definitions/string
> description: should be hardware or software.
> --
> 2.32.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: watchdog: atmel: Add missing 'interrupts' property
2021-12-06 17:40 [PATCH] dt-bindings: watchdog: atmel: Add missing 'interrupts' property Rob Herring
2021-12-06 19:47 ` Guenter Roeck
@ 2021-12-07 8:23 ` Thierry Reding
2021-12-07 10:14 ` Nicolas Ferre
2 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2021-12-07 8:23 UTC (permalink / raw)
To: Rob Herring
Cc: Wim Van Sebroeck, Guenter Roeck, Nicolas Ferre, Alexandre Belloni,
Ludovic Desroches, Eugen Hristev, devicetree, linux-watchdog,
linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]
On Mon, Dec 06, 2021 at 11:40:45AM -0600, Rob Herring wrote:
> With 'unevaluatedProperties' support implemented, the atmel,sama5d4-wdt
> example has the following warning:
>
> /home/rob/proj/git/linux-dt/.build-arm64/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.example.dt.yaml: watchdog@fc068640: Unevaluated properties are not allowed ('interrupts' was unexpected)
>
> Document the missing 'interrupts' property.
>
> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
> Cc: Eugen Hristev <eugen.hristev@microchip.com>
> Cc: linux-watchdog@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: watchdog: atmel: Add missing 'interrupts' property
2021-12-06 17:40 [PATCH] dt-bindings: watchdog: atmel: Add missing 'interrupts' property Rob Herring
2021-12-06 19:47 ` Guenter Roeck
2021-12-07 8:23 ` Thierry Reding
@ 2021-12-07 10:14 ` Nicolas Ferre
2 siblings, 0 replies; 4+ messages in thread
From: Nicolas Ferre @ 2021-12-07 10:14 UTC (permalink / raw)
To: Rob Herring, Wim Van Sebroeck, Guenter Roeck, Alexandre Belloni,
Ludovic Desroches, Eugen Hristev
Cc: devicetree, Thierry Reding, linux-watchdog, linux-arm-kernel,
linux-kernel
On 06/12/2021 at 18:40, Rob Herring wrote:
> With 'unevaluatedProperties' support implemented, the atmel,sama5d4-wdt
> example has the following warning:
>
> /home/rob/proj/git/linux-dt/.build-arm64/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.example.dt.yaml: watchdog@fc068640: Unevaluated properties are not allowed ('interrupts' was unexpected)
>
> Document the missing 'interrupts' property.
>
> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Thanks for the fix Rob!
Best regards,
Nicolas
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
> Cc: Eugen Hristev <eugen.hristev@microchip.com>
> Cc: linux-watchdog@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml b/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> index 9856cd76c28d..a9635c03761c 100644
> --- a/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> @@ -22,6 +22,9 @@ properties:
> reg:
> maxItems: 1
>
> + interrupts:
> + maxItems: 1
> +
> atmel,watchdog-type:
> $ref: /schemas/types.yaml#/definitions/string
> description: should be hardware or software.
> --
> 2.32.0
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 4+ messages in thread