From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3A1719C54E for ; Mon, 20 Apr 2026 10:59:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776682746; cv=none; b=qzRjf+AL7DIPdEgObaxIYMpYAxjQM248soTxBimUETcISCBNiCPb4yGDD2p7XFqhMZ7Mky7qgh6jBhtFWsDpRGHiunjRbflhQx4V+P4/cPMuZkUxoVNJHK4JKdQAvZri4Ke8EMrKANebJ5o2gRumYyAOeljAk25SGwbGw7uIxVU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776682746; c=relaxed/simple; bh=Kgbx69a7RiyjmmfBGK/p0ZwBmQHZB68iKT4GgFYQVE8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GcyGzVLnhQaqOYTkJ4wGNITylCjdDSHcDiw38MfnaMOFT9tVhIvrrpMiMZuya7CgMgXmxgHlbcqBtOLIrKghyS0pSs6eVaV3xUeC0LzeAQwaZ76VbC/ecbMoPINHUKwRpNMnr2hJzZPfuIQaNQ2kGrX8BQop66TDMC0ukRBqnqI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mYEUQaMp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Kr3i6zKH; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mYEUQaMp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Kr3i6zKH" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63K79FjJ1598276 for ; Mon, 20 Apr 2026 10:59:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QgY6MV8u8zrLC/Y/isXzi/8HKm38qslcvgo71foq/ig=; b=mYEUQaMpM0ta5eg7 AGNJjMb16LdpFV5P3meK2b1++9Ga31Vx9HGtBmwdDXXsKqIUjHeC8kqOmUdeztsH nZlxcB0gzUNoxMOVVDKfv4ohWVwwSOYaNi1DYSbHoxg7yezSOtn2mf+Lcu/KaPf4 mig4HNiPuBKHkYomNrtWKFDE1zMFZeCtWu8Mx5JIDfociAydaHJsRXLlRCRYuPUO gdQdw0WaNf3e7RZ1Arm7zIbDKEhW4QPSQUZRRO19ZCgGPCp/flQ/HXt+zIvR06hw dlKRv81WDeOHrjWIed3sbOz+GPbF+SrGKLh046UxcNr864lDNu+Tp2lkwNmYtW+u joyWsA== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dnfgnh4ts-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Apr 2026 10:59:03 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8954b9b5da7so8928726d6.2 for ; Mon, 20 Apr 2026 03:59:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776682743; x=1777287543; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QgY6MV8u8zrLC/Y/isXzi/8HKm38qslcvgo71foq/ig=; b=Kr3i6zKHMA/hPRYNY3Fin1qNtMLmxZ0D+n6ROc3KG8aDPISLxbUVsh3z04jvrnIz5Q vh2khc2CFHC0SOmQjb3+kDg4d3obNZCl/tQVBBQG3ZKLtkufN3cm9142neUuSyH9YqJG 8cH91iJ+VkMhrI4MsG1/8+UWyEiXEzuT4Bxl1BNkP1AJAzef3Spr8Yk65z1plnSjiJvk ledpsL5thr+p4T//imdxgUZbIDxS4XW9e6CTlx6Zus1CuspULm0IyLixTxxCXhX7pdLg yfIsXXiW2/1CgWI4J6vHDdYyhsiQs+mlq6JPP7QLeUsnNe+wmJxWbRXFSQpp9kkhOKaE 79oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776682743; x=1777287543; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QgY6MV8u8zrLC/Y/isXzi/8HKm38qslcvgo71foq/ig=; b=S8uHE6H9pRMpiso1fN0h4zLDWIE7u/I/GQHHVLqkB5mth8hw5ltUX9U9nNMjiwqpOU 79XMz1CX+m8puck/woD9+BwviKJ3cvGSgZiV5BPxcb6uIeMaXg9NZ0ctBXBxJUEJeClB Y/FYcmGlwp3OAEo32/BUuGFFEcJWunfDYV+xw3xzwiPqw6HWRCVOSTszJ5NYf9goiXvH 5cSfQJg4xibBsCn4VyhceBx4U1dOXuB/FBvKr1R1ykvCBHWcx+NVUh0+/flG3TRVUf3V IHPxwhkQYZp90nTrhnxC2zZ21n1W/z1cgWsryLHkrbEWIvE6tX+ZtTAR9nD+D8vTjtfK +ROQ== X-Forwarded-Encrypted: i=1; AFNElJ8FuxtQ8sYLMwANrztN/3oRY1AiqRc+Cet8o9KTRaPsXT7WJeBvNxTcW1OytMC+K+u7oXmDvIoGmTQn@vger.kernel.org X-Gm-Message-State: AOJu0Yy0X3GY6Su0LvJ8vTKgKO1NbZqhQiPSjx+zruEic54Wxgiy4WGC 9j+f5LHYEvBDQgtXhNlCwr/EzD82KXZ7v6ilrUyHbgYM5rOjXMEjBD/gSe8h5+MTGxL0DDLEn58 4wCkZogIWMTfU/RHshAOxfPJFkPg5uxNI3SUMUacdIVGPEareubcD17BzbgCN0rHQ X-Gm-Gg: AeBDievrPWk1pa1NeOnngHDb33lQW0gDxXGpiWiWHULY/A0k/mkQuK4spH16pT0SXg2 EOP8HxlnZ6EgY8IW6VRCeC+xXa8LuFhonRjYLmFmYTOlmFCaadvAjF8ZWDRYN5jWcccZsiJNW0l jhRZ3FN/JUci0+S55hImIYoXADvG4blqbSMb4dHOLF7NAxGjF2N3UA+oSeeZwZIIhuRhZukuYLB wgJSW2Xjr5GrCQpJcG84IcOWKW3gTQjgYFCFLhks+czQGa/WqE6HVincRBmUXYOCdDIOp3hGDGt pRO8RSBfNYzdxxYuz6CH4h+zKB7AXQZ3DPeIZwuyzdDGV0BkR+GgHwiCquHyUmX5KrckewPdf9r H73d9TbTHZAVPm8GcKohh8+Ovi3PF2SdpJlmz0LPUi2fs6maT6q/c6OmMmsD9QJBUnqoOOpPx4u Nn9eFPrHLYvwOz+w== X-Received: by 2002:a05:620a:462c:b0:8cd:b2cd:ed4 with SMTP id af79cd13be357-8e7916ad053mr1166919985a.3.1776682742827; Mon, 20 Apr 2026 03:59:02 -0700 (PDT) X-Received: by 2002:a05:620a:462c:b0:8cd:b2cd:ed4 with SMTP id af79cd13be357-8e7916ad053mr1166917885a.3.1776682742390; Mon, 20 Apr 2026 03:59:02 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-672c4d67e50sm1809282a12.27.2026.04.20.03.58.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Apr 2026 03:59:00 -0700 (PDT) Message-ID: Date: Mon, 20 Apr 2026 12:58:58 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] arm64: dts: qcom: sc8280xp: add several missing pdc map entries To: Pengyu Luo Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260419173251.1180026-1-mitltlatltl@gmail.com> <4abb1626-a0a3-45e1-9289-fee366a8d9f0@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: p0f8LYLFuYNh3NRvgtVf5tsHEq4tyx0w X-Proofpoint-GUID: p0f8LYLFuYNh3NRvgtVf5tsHEq4tyx0w X-Authority-Analysis: v=2.4 cv=TK11jVla c=1 sm=1 tr=0 ts=69e606f7 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=pGLkceISAAAA:8 a=HiuIrkTBTQer7cJPyS8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIwMDEwNSBTYWx0ZWRfX1kg8mqCQOJ6i mHwATI99ZPmWfYmuZwldKIbnsOt6hXN4r0VhnFD/RDhnN5MobpwbibV6hjZhoV4s6xCs8jti6D8 H9Jf1M080ElawSH0k2pVf79mIO/tQE6KbII7HPsECZjTWko6g+WS0xsMbZqpt6SJDb5UWSWzQLN BdjUzdC/uGEGP3XQOtTxcOX0yWt9miDE3j9IBcJ7xCOzlNsyQKNxyw29M/K4StPDBe7RwmLNYKx uAFkPKXFkuh8Aa02uH+MGEp8dvgj5VYAtfU2XI49Rspy67zO9x3ZcmfOBe5XogZ3ZapU4dFbCPQ SSIw63BwJjwHIMWGBF4q5buytUJmlrMKaeV27NW16ALK+ueL4JLfH/3ciipFtJ8WTks8vxtzcTA 3lDjJKf5jA+UOaB93SDrgy3oXJOhQcRgG3wvMPCygQ6UBy20SBqH1LOvfo0aMz4PHmblin/W2BK OVJW8mFx+zM+lK9wWBA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-20_02,2026-04-17_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604200105 On 4/20/26 12:47 PM, Pengyu Luo wrote: > On Mon, Apr 20, 2026 at 6:21 PM Konrad Dybcio > wrote: >> >> On 4/20/26 11:53 AM, Pengyu Luo wrote: >>> On Mon, Apr 20, 2026 at 4:32 PM Konrad Dybcio >>> wrote: >>>> >>>> On 4/19/26 7:32 PM, Pengyu Luo wrote: >>>>> pdc 215, 256, 257 are missing, but we can find tlmm pin 103, 84, 90 >>>>> are mapped to them respectively, so add the map entries from pdc to >>>>> gic. These entries are reversed from .data section of qcgpio.sys >>>>> >>>>> Signed-off-by: Pengyu Luo >>>>> --- >>>> >>>> Reviewed-by: Konrad Dybcio >>>> >>>> Konrad >>>> >>>> The below change on top will fully align it with the data in the docs >>>> (no functional change) >>>> >>> >>> Glad to know. Could you please help to check the tlmm map too? When I >>> was parsing the binary, I found >>> >>> tlmm 65535 => pdc 70 => gic 520 >>> tlmm 65535 => pdc 174 => gic 733 >>> tlmm 65535 => pdc 175 => gic 734 >>> tlmm 65535 => pdc 176 => gic 735 >>> tlmm 65535 => pdc 177 => gic 736 >>> tlmm 65535 => pdc 178 => gic 737 >>> tlmm 65535 => pdc 184 => gic 743 >>> tlmm 65535 => pdc 185 => gic 744 >>> tlmm 65535 => pdc 186 => gic 745 >>> tlmm 65535 => pdc 187 => gic 746 >>> tlmm 65535 => pdc 188 => gic 747 >>> tlmm 65535 => pdc 194 => gic 753 >>> tlmm 65535 => pdc 195 => gic 754 >>> tlmm 65535 => pdc 196 => gic 755 >>> tlmm 65535 => pdc 197 => gic 756 >>> tlmm 65535 => pdc 198 => gic 757 >>> tlmm 65535 => pdc 199 => gic 416 >>> tlmm 65535 => pdc 204 => gic 462 >>> tlmm 65535 => pdc 205 => gic 264 >>> >>> If 65536 means the pin is missing, I will send v2 to remove the tlmm >>> map together with the pdc removal. >> >> These seem to be LPASS/SSC GPIOs >> >> There are missing pairs of: >> >> TLMM 151 -> PDC 264 -> GIC 191 >> TLMM 143 -> PDC 261 -> GIC 402 >> >> and very interestingly, GPIO 190 has two mappings: >> PDC 70 -> GIC 552 > > PDC 70 is connected to swr2, which is wakeable. Speaking of this, in > qcom,pdc.yaml > > Drivers requiring wakeup capabilities of their device interrupts > routed through the PDC, must specify PDC as their interrupt controller > and request the PDC port associated with the GIC interrupt. > > But swr2 specifies GIC. > > I wonder, when should we use tlmm, when pdc, when gic? I would assume "pdc, whenever available" Konrad