From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C35E3C71153 for ; Mon, 28 Aug 2023 11:47:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229589AbjH1Lqt (ORCPT ); Mon, 28 Aug 2023 07:46:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232611AbjH1Lqo (ORCPT ); Mon, 28 Aug 2023 07:46:44 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 595A018B for ; Mon, 28 Aug 2023 04:46:12 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-5007c8308c3so4866195e87.0 for ; Mon, 28 Aug 2023 04:46:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693223141; x=1693827941; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6dr8kOwOsDboXjhvNdOS41TNLyrTWEdq0XWTC5Df7tY=; b=QQD8Ameg4gMcUdDMYhMto/Hi/7tnyS4tDVntfE/tGymUvmk92wDRd2UtqPldnveVK5 EdwotR0vKrCJ0w24OADGtEXQJYG5lUBBmn4el/fQJqJ65wff5vFRrkN+F9Q+NktKAaBB kvxbUp/WO2x8bSDWL9dYpkMLM4DUXn9qrMKumZhOTbNkYW1L0H92jjDfbM9MgYz802lk NYzMb/kMBrB1mLfBO/kxPAlDV+zLbloJI8xKBS+qupeSz4hPllNNDe1eXSj14LnOW6SL /O7X9KDxE68YsNlldXBEsRsq0b/4qtWVzKhPsiQ8O7q8w0xPeKbhvoNjyHQBjEZUq9vw PAFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693223141; x=1693827941; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6dr8kOwOsDboXjhvNdOS41TNLyrTWEdq0XWTC5Df7tY=; b=ktMHIBRtmS8ygOKN3r4xoNEhqhfE5oPw/XU/CaMCeasSC2FfDcdjyscT7MEGpXYqjC /dk7nXlHulwLYCDRT7xHcX5Mm3Rp5u/CMXlU62U9krsrSTg2J+PRHpdNyGuE73pR4tgp Uzc/NQ38fEFit+ggXemijj6bTzXZ2JxwQNl2efslqKCmDsRYh6vlkG8hkGUt0Mw9m6kP MqQB+t2g3tEWx7gghewLlA76BGOxMfCHY7XPeUFmfIBBDO9qHRx4Ze7J9ZyAUCjS4uNQ 9ZSUpnHow+uasOSIaysjWsFZ9rAkSVmu+YwJCZ307z/cx8xD8WmHvV7tXRNtF3y1w1a+ rClA== X-Gm-Message-State: AOJu0Yzm8ppyJZLK9ZTx4BAqePKDfcIhbWyq8nZ8kgrU/Lji0AtBRSFe ImJGy0oMjHgUbgOnfyKzq+ptGA== X-Google-Smtp-Source: AGHT+IF6DFfsQgsH8hrHCCkBH8ra8UAma78Y1ZsfOHa33tSwNnuRfE8kzVVbfJkhMv/fqHwwXX6Nuw== X-Received: by 2002:a19:ca44:0:b0:500:90d1:90a6 with SMTP id h4-20020a19ca44000000b0050090d190a6mr10738379lfj.63.1693223140723; Mon, 28 Aug 2023 04:45:40 -0700 (PDT) Received: from [192.168.1.101] (abyl195.neoplus.adsl.tpnet.pl. [83.9.31.195]) by smtp.gmail.com with ESMTPSA id t16-20020ac25490000000b004ff91a94156sm1548628lfk.121.2023.08.28.04.45.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Aug 2023 04:45:40 -0700 (PDT) Message-ID: Date: Mon, 28 Aug 2023 13:45:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] clk: qcom: Add SM6115 LPASSCC Content-Language: en-US To: Krzysztof Kozlowski , Dmitry Baryshkov Cc: Bjorn Andersson , Andy Gross , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Srinivas Kandagatla , Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230825-topic-6115_lpasscc-v1-0-d4857be298e3@linaro.org> <20230825-topic-6115_lpasscc-v1-3-d4857be298e3@linaro.org> <5847be93-68c3-95fb-1d3e-9678804b9a70@linaro.org> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <5847be93-68c3-95fb-1d3e-9678804b9a70@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26.08.2023 16:29, Krzysztof Kozlowski wrote: > On 26/08/2023 16:09, Dmitry Baryshkov wrote: > >>>> +MODULE_DEVICE_TABLE(of, lpasscc_sm6115_match_table); >>> >>> Everything here is almost the same as sc8280xp one, so this should be >>> added to sc8280xp. You cut some boilerplate and additional driver. >> >> We have been there. It quickly becomes a nightmare to maintain. >> Consider dispcc-sm8250.c > > Because too much was added. I do not propose to keep all resets here. > >> >> But I agree with you, this code looks too similar. If we expect more >> similar lpasscc drivers, which provide no clocks, just several resets, >> maybe we can create a common generic wrapper and make resets lists >> corresponding driver data? > > This would also work. Sounds like a good idea until somebody at qualcomm decides to add support for bypassing adsp that only works on chromebooks that may get cancelled or super secret internal devboards and the driver will gain support for clocks.. But I guess that person will have to worry about squaring this out. Konrad