Re: [PATCH v2 2/2] dt-bindings: Add Arm corstone500 platform

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 14/12/2022 14:44, Krzysztof Kozlowski wrote:
> On 14/12/2022 14:24, Emekcan Aras wrote:
>> From: Emekcan Aras <Emekcan.Aras@arm.com>
> 
> 1. Your From does not match SoB exactly. Avoid it and make it consistent.
> 
> 2. Use subject prefixes matching the subsystem (git log --oneline -- ...).
> 
> 3. Please use scripts/get_maintainers.pl to get a list of necessary
> people and lists to CC.  It might happen, that command when run on an
> older kernel, gives you outdated entries.  Therefore please be sure you
> base your patches on recent Linux kernel.
> 
> 
>>
>> Add bindings to describe implementation of
>> the ARM Corstone500 platform.
> 
> Please wrap commit message according to Linux coding style / submission
> process:
> https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586
> 
>>
>> Signed-off-by: Emekcan Aras <emekcan.aras@arm.com>
>> ---
>>  .../bindings/arm/arm,corstone500.yaml         | 30 +++++++++++++++++++
>>  1 file changed, 30 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/arm/arm,corstone500.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/arm/arm,corstone500.yaml b/Documentation/devicetree/bindings/arm/arm,corstone500.yaml
>> new file mode 100644
>> index 000000000000..cfe41f7760fd
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/arm,corstone500.yaml
>> @@ -0,0 +1,30 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/arm/arm,corstone500.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: ARM Corstone500
>> +
>> +maintainers:
>> +  - Emekcan Aras <emekcan.aras@arm.com>
>> +  - Rui Miguel Silva <rui.silva@linaro.org>
>> +
>> +description: |+
>> +  Corstone-500 is an ideal starting point for feature rich System on Chip
>> +  (SoC) designs based on the Cortex-A5 core. These designs can be used in
>> +  Internet of Things (IoT) and embedded products.
> 
> Yet you do not allow to re-use your DTS, so how this re-usage of design
> will happen?
> 

OK, so similar as Corstone 1000, but please tell me - any reason why you
keep them separate in the bindings? Next time new file for Corstone
1001, 1002, 2000, 2221 etc.?

Best regards,
Krzysztof