From: Shan-Chun Hung <shanchun1218@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
ulf.hansson@linaro.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, adrian.hunter@intel.com,
p.zabel@pengutronix.de, pbrobinson@gmail.com, serghox@gmail.com,
mcgrof@kernel.org, prabhakar.mahadev-lad.rj@bp.renesas.com,
forbidden405@outlook.com, tmaimon77@gmail.com,
andy.shevchenko@gmail.com, linux-arm-kernel@lists.infradead.org,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: ychuang3@nuvoton.com, schung@nuvoton.com
Subject: Re: [PATCH 1/2] dt-bindings: mmc: nuvoton,ma35d1-sdhci: Document MA35D1 SDHCI controller
Date: Fri, 21 Jun 2024 14:44:15 +0800 [thread overview]
Message-ID: <b6bda253-3fdf-41c5-934a-66b79c991582@gmail.com> (raw)
In-Reply-To: <f315c1cd-1f78-46e0-a86b-5240a869bb31@kernel.org>
Dear Krzysztof,
Thanks for your review.
On 2024/6/21 下午 02:04, Krzysztof Kozlowski wrote:
> On 21/06/2024 01:53, Shan-Chun Hung wrote:
>>>> +
>>>> + interrupts:
>>>> + maxItems: 1
>>>> +
>>>> + pinctrl-names:
>>>> + description:
>>>> + Should at least contain default and state_uhs.
>>> ? Contradicts constraints.
>> I will modify the description to "Should at least contain default.
>> state_uhs is mandatory in this scenario."
> Then just drop it. Don't repeat constraints in free form text.
>
>
> Best regards,
> Krzysztof
OK , I will drop the description.
Best Regards,
Shan-Chun
next prev parent reply other threads:[~2024-06-21 6:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 5:46 [PATCH 0/2] Add support for Nuvovon MA35D1 SDHCI Shan-Chun Hung
2024-06-19 5:46 ` [PATCH 1/2] dt-bindings: mmc: nuvoton,ma35d1-sdhci: Document MA35D1 SDHCI controller Shan-Chun Hung
2024-06-19 7:16 ` Rob Herring (Arm)
2024-06-19 7:29 ` Krzysztof Kozlowski
2024-06-20 23:53 ` Shan-Chun Hung
2024-06-21 6:04 ` Krzysztof Kozlowski
2024-06-21 6:44 ` Shan-Chun Hung [this message]
2024-06-19 5:46 ` [PATCH 2/2] mmc: sdhci-of-ma35d1: Add Novoton MA35D1 SDHCI driver Shan-Chun Hung
2024-06-19 10:18 ` Dragan Simic
2024-06-19 16:17 ` Shan-Chun Hung
2024-06-19 16:18 ` [PATCH 2/2] mmc: sdhci-of-ma35d1: Add Nuvoton " Markus Elfring
2024-06-20 6:49 ` Shan-Chun Hung
2024-06-20 6:58 ` Krzysztof Kozlowski
2024-06-20 8:59 ` Shan-Chun Hung
2024-06-19 19:09 ` [PATCH 2/2] mmc: sdhci-of-ma35d1: Add Novoton " Andy Shevchenko
2024-06-21 8:06 ` Shan-Chun Hung
2024-06-21 11:25 ` Andy Shevchenko
2024-06-24 0:28 ` Shan-Chun Hung
2024-06-21 11:45 ` Philipp Zabel
2024-06-22 9:15 ` Shan-Chun Hung
2024-06-19 15:40 ` [PATCH 0/2] Add support for Nuvovon MA35D1 SDHCI Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6bda253-3fdf-41c5-934a-66b79c991582@gmail.com \
--to=shanchun1218@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=forbidden405@outlook.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pbrobinson@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=schung@nuvoton.com \
--cc=serghox@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=ychuang3@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).