From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C32DC433FE for ; Mon, 21 Nov 2022 11:30:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231237AbiKULaQ (ORCPT ); Mon, 21 Nov 2022 06:30:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230395AbiKUL3h (ORCPT ); Mon, 21 Nov 2022 06:29:37 -0500 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76FD8B9713 for ; Mon, 21 Nov 2022 03:24:32 -0800 (PST) Received: by mail-lj1-x232.google.com with SMTP id t10so14208680ljj.0 for ; Mon, 21 Nov 2022 03:24:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HKqjxFH9lBJ6mj+RurMBKV6+d9mN/sK1dH5sWKwKtDM=; b=zDLZMBPY1nQ0uEG1u08M0+szLxbC1eBHKzhzxrNsZ2K9yCHXx3x60A96jL4HsBojfW NScof73HJ9qExkMuqkHY+Gfmy6CyZEtMc7w2jipzeXrQtmvSwqEXQXPF675IBr6wyE6c UClf9CUPdUi7G/gAHIwM1sQ/noUIMtlVMr2IcOicZlKRRGH52bBbMuvzZ6DYK9KBulJk CtB4JjuP/F7nGpBbiGRgQVuKJWvIBGct1IAxefNRkrQ+UDnbUbBJxUDvr5ffADndM+Ir CZ3QxmA7mBygDGpPnLNZQz5Ga8uLYEYyRDkF/nyoCJMBh46yidtECU6XHCzjd415KyFN Sp9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HKqjxFH9lBJ6mj+RurMBKV6+d9mN/sK1dH5sWKwKtDM=; b=m/AjK2y2tn/1siE8CF5Wxb5bOZYkx8ggh6z+9ANHVWdeFrA1VRHXyDn/3vY/d2kTvW r7BHzhIb83b+ELzj+Yg/5K8XmEqnf7EM37GuUbQXhIdKQG5aECoiCfmO3DCB5xU7Vr8+ UoLyVuItMQi4jNLo+xkdBMtmjBvEsW8869ca9bPT9YCmjmn/KpFdMN7uVgvt2Ac6UZtV qWStcaVUR11t0Q6Q2+sCbH6tNYMG20t0J5MBZHa9KTlKtnmmOiYvEOuQrBoDFaeAk+FF 2DXpzKGTtH5Lb0/hgAJOYUuW+m+6AIWrb/W28qyyDZtbVOUhFOPzOX7tddh/vf+dTBMd XUPA== X-Gm-Message-State: ANoB5pmil7sq0sRdmRw+QpyE4nGBbh5KC1l6vhy6aBrJUSCCmPZ5Gj/j QUxPNnNFJuafAVVpA+OScqK1+w== X-Google-Smtp-Source: AA0mqf7+ThV1JT8ddFZxi0m7Rj3vk4VxBr+IO5eRpaWktIpUkqwBf2AzEkvkhFJNO2Ly6FItQvMCRg== X-Received: by 2002:a2e:a306:0:b0:279:4846:50a0 with SMTP id l6-20020a2ea306000000b00279484650a0mr1608985lje.5.1669029870659; Mon, 21 Nov 2022 03:24:30 -0800 (PST) Received: from [192.168.1.101] (95.49.32.48.neoplus.adsl.tpnet.pl. [95.49.32.48]) by smtp.gmail.com with ESMTPSA id f8-20020a056512360800b004b4b90a6992sm1842018lfs.95.2022.11.21.03.24.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 03:24:30 -0800 (PST) Message-ID: Date: Mon, 21 Nov 2022 12:24:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 3/3] arm64: dts: qcom: msm8916-acer-a1-724: Add accelerometer/magnetometer Content-Language: en-US To: "Lin, Meng-Bo" , linux-kernel@vger.kernel.org Cc: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Stephan Gerhold , Nikita Travkin , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht References: <20221119194340.91789-1-linmengbo0689@protonmail.com> <20221119194727.92107-1-linmengbo0689@protonmail.com> From: Konrad Dybcio In-Reply-To: <20221119194727.92107-1-linmengbo0689@protonmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19.11.2022 20:48, Lin, Meng-Bo wrote: > Iconia Talk S uses a Bosch BMC150 accelerometer/magnetometer combo. > The chip provides two separate I2C devices for the accelerometer > and magnetometer that are already supported by the bmc150-accel > and bmc150-magn driver. > > Signed-off-by: Lin, Meng-Bo > --- Reviewed-by: Konrad Dybcio Konrad > .../boot/dts/qcom/msm8916-acer-a1-724.dts | 38 +++++++++++++++++++ > 1 file changed, 38 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8916-acer-a1-724.dts b/arch/arm64/boot/dts/qcom/msm8916-acer-a1-724.dts > index acd909551a75..3461a39ee866 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916-acer-a1-724.dts > +++ b/arch/arm64/boot/dts/qcom/msm8916-acer-a1-724.dts > @@ -6,6 +6,7 @@ > > #include > #include > +#include > > /* > * NOTE: The original firmware from Acer can only boot 32-bit kernels. > @@ -51,6 +52,35 @@ usb_id: usb-id { > }; > }; > > +&blsp_i2c2 { > + status = "okay"; > + > + accelerometer@10 { > + compatible = "bosch,bmc150_accel"; > + reg = <0x10>; > + interrupt-parent = <&msmgpio>; > + interrupts = <115 IRQ_TYPE_EDGE_RISING>; > + > + vdd-supply = <&pm8916_l17>; > + vddio-supply = <&pm8916_l6>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&accel_int_default>; > + > + mount-matrix = "0", "-1", "0", > + "-1", "0", "0", > + "0", "0", "1"; > + }; > + > + magnetometer@12 { > + compatible = "bosch,bmc150_magn"; > + reg = <0x12>; > + > + vdd-supply = <&pm8916_l17>; > + vddio-supply = <&pm8916_l6>; > + }; > +}; > + > &blsp1_uart2 { > status = "okay"; > }; > @@ -199,6 +229,14 @@ l18 { > }; > > &msmgpio { > + accel_int_default: accel-int-default-state { > + pins = "gpio115"; > + function = "gpio"; > + > + drive-strength = <2>; > + bias-disable; > + }; > + > gpio_keys_default: gpio-keys-default-state { > pins = "gpio107"; > function = "gpio";