From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED7DC1DF985 for ; Wed, 16 Apr 2025 16:09:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744819760; cv=none; b=ppssqYjSWt4HFi26TDQ7Pb1xwXItUdly3WC664QRmwn8y73DxwKgB5WSVIJWHyR1DrLLEQ+CnKh9Yk2g2WkEJXBCTP2fLfJ8S2hXeRvwvFfCA93JzWb/08F5/Og1x77PbmSppFoBvEAUqEbMe2+W/GRcDE3n92vUQF6BMQxMS5c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744819760; c=relaxed/simple; bh=FwIeW4qgOB5haxONFHXw7a6R1kS+Pg8/36trjRhroCk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Q8Xb+1LkNrI+nRmYpwkpSP+JAT6hoCiU/uIX1xPDzHi4zudDx7760i7UKgzCG0gajQP6p/B7WLKcdev+rtuDDADDU1/Yrtdad6TYvvTrGfkQKygNW3I+0LSqcr8F5wfjz1HkWe7lWBVYYXMses6uaQPGSGQDtf5RPDChVI1i0J4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AmzkTcl3; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AmzkTcl3" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53G9mIS5006001 for ; Wed, 16 Apr 2025 16:09:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ODYn6AqMABErS0MGZHJyExJA6uxCB640fUmnvTdsDC0=; b=AmzkTcl3OozdoeXI QOXa/7IT9EFhYmScZ021lQK85PBqhd/1vF8wBbc/9HjrE1131NbqkhogJz5pWlce T4PoC4Wvfj/9JUB/KBOVG1CYWgl34wZOo1J4qIEJlME9TiUuzZz0F3lcDvAJR3X+ 5Zf9uCwfTBXVamSw9o6zEnV3uibaPIaF1nPaJ1lP79yQRNUUHcxmcKJX3kItSKvo sBxrhH0+QAW3OhNCw83pBVU/A5HFGu+SfGJRTledNqAQUWCP/VhKMXVeLnsBR+v5 B1OUXkFys97L5RMOsRgWvyfNgFPNeONuCNVzs2z4m2/w8CSZFEOouSVyUxDCEKFA iQj6lg== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45ydhqcagh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 16 Apr 2025 16:09:16 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7c552802e9fso168775185a.0 for ; Wed, 16 Apr 2025 09:09:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744819756; x=1745424556; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ODYn6AqMABErS0MGZHJyExJA6uxCB640fUmnvTdsDC0=; b=UtJyffI2GiA7g7zIQrQTPOtUDz7lsARP59KpHWx1phZW++5FXVPaAWHfXmPStgPd5y 6YopjDJ3oZ/bkrPxqNM2uv9GRCuZQCagkSAIF6NYvGa/dQ6wlInoRHC3cqO585u2yF2x NewdVMY6KFOmmSu8x738dwmQzwdtuPE2RmZ7Eftc1BFR71T35QTdHZ+C7mQtR9t9youX 6zI4m34SrTr4YlPmlWnqtA2AJ5qvtk+QD9iKxWE7y4uHJyqqhYzrr5SyNydWIEGovVnT 82Y/8UH/IsjjyK1i9WuB0HwEbGjFpcTPRBXboCflbs8NLSO3gybzog7Z8UXhz5eqGaJZ m59A== X-Forwarded-Encrypted: i=1; AJvYcCXuDFlIz/0JqzkZPZlxhSuph0TrQF64H1d35OLGwMC4wLeUwP4gsHCypabA885tDfeYfk/RLltVJn6N@vger.kernel.org X-Gm-Message-State: AOJu0YxZrbSPvFAAiKGl3bnpxP5fQQOy2jpoxkryLVtCLxMnQyDJbAzd OejzepPoZRXzAcuN9HnGURY6zGfyUsnBviXawJQ8w8Aiun54GWwf58k6d4P75arCVDSSNKCXmfv cn4x2ARgS/w2nBstsP9+kLFr4olQLGEzW/oEpKxKa0Jta19PLwiFl6U8IpCtS X-Gm-Gg: ASbGnctWExB7r5hauiSvxJa/6s8BFhNG1m/2/QmRrW0SyE0wde4+1HkNLbLTZsfEtxq 1F6pHfLJUAFnpcw1/FaZMDF/5BSO3jfTaKgOG1KtgN5nNP7EUPppsGwRTXko3UbfGhsRcV+Vxej Iu9aoJoEnzUWfr9QBjPLnH40UicPjsr6zymecKeDwKHkJ7SV1b11AjFstu5YbpRWVBM3mTUFllR QSHZPYfaS34W4RcB6j5OASDm3SfbHhbeNY7QFmIr8ZTYBhF5T6mZ73+iOXk5/NuxZK5Bl3uqo0N T0LNjSJPF2mHGwPYO6FVpfiZbQ01XsuITFDso9MSOGgeYeyRe2jdAw3lmA7iaL+CYfw= X-Received: by 2002:a05:6214:e6d:b0:6e8:fef8:8b06 with SMTP id 6a1803df08f44-6f2b949f763mr1424086d6.2.1744819755816; Wed, 16 Apr 2025 09:09:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHqTEn4ZwnP85Wl9OFLZVFMob3CDIEgC8OxR/srPtQNfxgXZMTXzLdDo2GRaFTa3vUSJvc1xg== X-Received: by 2002:a05:6214:e6d:b0:6e8:fef8:8b06 with SMTP id 6a1803df08f44-6f2b949f763mr1423916d6.2.1744819755308; Wed, 16 Apr 2025 09:09:15 -0700 (PDT) Received: from [192.168.65.178] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acb3d127970sm153280866b.113.2025.04.16.09.09.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Apr 2025 09:09:14 -0700 (PDT) Message-ID: Date: Wed, 16 Apr 2025 18:09:12 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/2] arm64: dts: qcom: sa8775p: Add support for camss To: Vikram Sharma , Konrad Dybcio , rfoss@kernel.org, todor.too@gmail.com, bryan.odonoghue@linaro.org, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, hverkuil-cisco@xs4all.nl, cros-qcom-dts-watchers@chromium.org, catalin.marinas@arm.com, will@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Suresh Vankadara References: <20250210155605.575367-1-quic_vikramsa@quicinc.com> <20250210155605.575367-3-quic_vikramsa@quicinc.com> <6e98b5ca-3ff1-44c3-928f-e993cf29215f@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: 507wH4W7bVPXpzR6He-GeKEsYYhDbxn6 X-Authority-Analysis: v=2.4 cv=C7DpyRP+ c=1 sm=1 tr=0 ts=67ffd62c cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=COk6AnOGAAAA:8 a=eWPriOLmkRKYu5JWBSMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: 507wH4W7bVPXpzR6He-GeKEsYYhDbxn6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-16_06,2025-04-15_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxlogscore=916 priorityscore=1501 suspectscore=0 clxscore=1015 spamscore=0 bulkscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 mlxscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504160132 On 4/16/25 5:29 PM, Vikram Sharma wrote: > > On 4/14/2025 7:14 PM, Konrad Dybcio wrote: >> On 2/10/25 4:56 PM, Vikram Sharma wrote: >>> Add changes to support the camera subsystem on the SA8775P. >>> >>> Co-developed-by: Suresh Vankadara >>> Signed-off-by: Suresh Vankadara >>> Signed-off-by: Vikram Sharma >>> --- >>>   arch/arm64/boot/dts/qcom/sa8775p.dtsi | 187 ++++++++++++++++++++++++++ >>>   1 file changed, 187 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi >>> index 3394ae2d1300..83640fef05d2 100644 >>> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi >>> @@ -7,6 +7,7 @@ >>>   #include >>>   #include >>>   #include >>> +#include >>>   #include >>>   #include >>>   #include >>> @@ -3796,6 +3797,192 @@ videocc: clock-controller@abf0000 { >>>               #power-domain-cells = <1>; >>>           }; >>>   +        camss: isp@ac7a000 { >>> +            compatible = "qcom,sa8775p-camss"; >>> + >>> +            reg = <0x0 0xac7a000 0x0 0x0f01>, >>> +                  <0x0 0xac7c000 0x0 0x0f01>, >>> +                  <0x0 0xac84000 0x0 0x0f01>, >>> +                  <0x0 0xac88000 0x0 0x0f01>, >>> +                  <0x0 0xac8c000 0x0 0x0f01>, >>> +                  <0x0 0xac90000 0x0 0x0f01>, >>> +                  <0x0 0xac94000 0x0 0x0f01>, >> These I think should begin 0x1000 earlier and as a result be 0x1000 > Hi Konrad, > Thanks for your comments. > First 0x1000 bytes of CSID are for secure usecase. Actually CSID register address space starts from > 'TITAN_A_RT_1_CSID_WRAPPER_CLC_CSID0_HW_VERSION' which is 0xac7a000. Alright, thanks Konrad