From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Agner Subject: Re: [PATCH] pinctrl: imx6ul: add IOMUXC SNVS pinctrl driver for i.MX 6ULL Date: Sat, 06 Jan 2018 12:14:28 +0100 Message-ID: References: <20180102164059.14641-1-stefan@agner.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Linus Walleij Cc: Shawn Guo , Sascha Hauer , Fabio Estevam , Rob Herring , Mark Rutland , Linux ARM , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Bai Ping List-Id: devicetree@vger.kernel.org On 2018-01-03 09:09, Linus Walleij wrote: > On Tue, Jan 2, 2018 at 5:40 PM, Stefan Agner wrote: > >> From: Bai Ping >> >> On i.MX 6ULL, the BOOT_MODEx and TAMPERx pin MUX and CTRL registers >> are available in a separate IOMUXC_SNVS module. Add support for the >> IOMUXC_SNVS module to the i.MX 6UL pinctrl driver. >> >> Signed-off-by: Bai Ping >> Signed-off-by: Stefan Agner > > So 6 unsigned long 32 bit is succeeded by 6 unsigned long long, 64 bit? > > Someone is having fun naming these platforms I see. Hehe, yeah definitely. At least they use proper type suffixes ;-) > >> Required properties: >> -- compatible: "fsl,imx6ul-iomuxc" >> +- compatible: "fsl,imx6ul-iomuxc" for main IOMUX controller or >> + "fsl,imx6ull-iomuxc-snvs" for i.MX 6ULL's SNVS IOMUX controller. > > Pretty uncontroversial change but still nice to give the DT people a chance > to ACK it. > >> static int imx6ul_pinctrl_probe(struct platform_device *pdev) >> { >> - return imx_pinctrl_probe(pdev, &imx6ul_pinctrl_info); >> + const struct of_device_id *match; >> + struct imx_pinctrl_soc_info *pinctrl_info; >> + >> + match = of_match_device(imx6ul_pinctrl_of_match, &pdev->dev); >> + >> + if (!match) >> + return -ENODEV; >> + >> + pinctrl_info = (struct imx_pinctrl_soc_info *) match->data; > > 1. Do not use a cast on void * pointers. > > 2. Use this function: > extern const void *of_device_get_match_data(const struct device *dev); > > From Ok. We use the same code in pinmux-imx7d.c, will send a patch to simplify that too. -- Stefan -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html