From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 755D3C004D4 for ; Thu, 19 Jan 2023 11:04:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230038AbjASLEo (ORCPT ); Thu, 19 Jan 2023 06:04:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230122AbjASLEZ (ORCPT ); Thu, 19 Jan 2023 06:04:25 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B835D7179D for ; Thu, 19 Jan 2023 03:04:19 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id l41-20020a05600c1d2900b003daf986faaeso962183wms.3 for ; Thu, 19 Jan 2023 03:04:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WFPCHnH4BLHfsWKrLXL/kRkVribIQYKCD+0tbIu1RlY=; b=ORycp9/f4UvnbRnieWYiheKRbz4dQRj6ZCKMBB8oUeU+Id+izspyrbe1d8SJD4TDnv MXQTkk087qeT27gM+1xw+eOBqCKd02Xkc/Z8OfZsov0zJlEmRy7p7LqiE1SuxWvkPvy+ /xn5/67z4Q7Xwm7frblc0U8DMCXVz21egKc2CWa6TfS/0R7KPah5ytNYmzdU2GPcl2YW bLnPTu/qFioJ6YsjbOfJVtskoEMEJnnG6Glg/XClwEDAFGE8WnFgNvr0sC4W/OMYq2A9 af/fsFHT3N1QQDnMANHrF1SmKqmfQDYzqcZQzrCE0lUxazmex15ivd+DmNH84RsP5iW2 TXvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WFPCHnH4BLHfsWKrLXL/kRkVribIQYKCD+0tbIu1RlY=; b=592u8V9HlXz4oj8bRTEkd39JVjpqcruw1haN5v43aMqbd/h9OcGAVMgTe8DkG4f5vP ftsUEVT6jilwRQzjYgydKBJHBFNhcqhHEbOqP529RDa0W4rqi4Zm1tKbyQqQ+sL4EdDT no1bdsZRy6cpSHSzTLll+WTjxiZqIjx8AgutIsjiaRI3xB8IfQ89Y0cIMc2NmMSdiX0P E7PWWUdPn4WEfk3Z+CXCt60ZTwm9FiA188YZw7CQ/Sk7sKObw4eo3eGm3yl2IrumTkzG /TF3nhTH9hUoAfctQoA0+mec7BinPodRVA5plXc1QwBCIyG4/+Y1o90nCTQ+hnF0tmMv KNjw== X-Gm-Message-State: AFqh2kpAx4iSHsZj171qzTospahYRVJQKVz+uYs6r53hxdXBtVgDnDbx NQ6P1QXjyy9jgITMjiQMc624uw== X-Google-Smtp-Source: AMrXdXv1b/NdkFoUj8MkBo3cwBpSRggisPj59zoDU29d9SSgAJdooDC4XRMfufn4i6dLoRwq4xM07Q== X-Received: by 2002:a05:600c:3b17:b0:3cf:7397:c768 with SMTP id m23-20020a05600c3b1700b003cf7397c768mr9770538wms.30.1674126258288; Thu, 19 Jan 2023 03:04:18 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id a10-20020adfdd0a000000b002bb6b45ab57sm31533210wrm.85.2023.01.19.03.04.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Jan 2023 03:04:17 -0800 (PST) Message-ID: Date: Thu, 19 Jan 2023 12:04:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH] dt-bindings: clock: qcom,a53pll: drop operating-points-v2 Content-Language: en-US To: Bryan O'Donoghue , Bjorn Andersson Cc: Stephen Boyd , Andy Gross , Konrad Dybcio , Krzysztof Kozlowski , Michael Turquette , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, fabien.parent@linaro.org References: <20230113145859.82868-1-krzysztof.kozlowski@linaro.org> <063c5516-417d-7c21-b58f-a6552779a621@linaro.org> <705c78c1d0da18089419b064832d5fed.sboyd@kernel.org> <20230119031136.27vson2awemt3nkt@builder.lan> <776b67b2-2405-36f5-f072-78f33ae59fcc@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <776b67b2-2405-36f5-f072-78f33ae59fcc@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/01/2023 11:55, Bryan O'Donoghue wrote: > On 19/01/2023 03:11, Bjorn Andersson wrote: >> On Wed, Jan 18, 2023 at 11:11:00AM -0800, Stephen Boyd wrote: >>> Quoting Krzysztof Kozlowski (2023-01-15 06:35:23) >>>> On 13/01/2023 21:28, Stephen Boyd wrote: >>>>> Quoting Krzysztof Kozlowski (2023-01-13 06:58:59) >>>>>> The CPU PLL clock node does not use OPP tables (neither driver). >>>>> >>>>> What device is qcom_a53pll_get_freq_tbl() operating on? >>>> >>>> On its own, internal table. While of course driver could be converted to >>>> operating-points-v2, no one did it within last 5 years, so why it should >>>> happen now? >>>> >>> >>> The property was added mid 2021 by Shawn[1], that's not 5 years ago. I >>> guess there were plans to add an OPP table that never happened[2]? Is >>> Shawn still working on this? If not, we should revert the OPP code out >>> of the driver. >>> >> >> @Bryan, what do you think about this? > > I'd be in favour of starting the CPR patchset instead, which depends on > the opps. > > I think @Fabien has been waiting on the core 8939 dtsi, I also think the > dtsi is close enough to merge that we could reasonably initiate the CPR > stuff. So you would make use of operating-points-v2 property? Then probably we also miss opp-table, but anyway this patch can be dropped then. Best regards, Krzysztof