From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 378ADC64E7C for ; Wed, 2 Dec 2020 15:04:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF25521D7F for ; Wed, 2 Dec 2020 15:04:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727715AbgLBPDz (ORCPT ); Wed, 2 Dec 2020 10:03:55 -0500 Received: from new2-smtp.messagingengine.com ([66.111.4.224]:58737 "EHLO new2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726620AbgLBPDz (ORCPT ); Wed, 2 Dec 2020 10:03:55 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 4DF59580132; Wed, 2 Dec 2020 10:03:09 -0500 (EST) Received: from imap2 ([10.202.2.52]) by compute3.internal (MEProxy); Wed, 02 Dec 2020 10:03:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm1; bh=zKHBXpuw+WPRxYjKCr+NVoOy6HmLEmi pUWxQdocXY44=; b=inplWYyfQJqds7vglOwm5zUoQr2WvvTwZ81yB/6SWEAfzt4 yyfNOxpkuC8Gho2V8At4KOUsKV3LESaha0MQQa5dEm/UcT8ailj9ZNY1kPCaOqaj Fh37aCFHPOB2pQLhVcqXD1X4d2oXJ7CXjuGzkIQ0Gwdta0ytwJhsWIh/HTxom0Bt gCC1QVNvKEpMU/OTL2tA5qQCoqZvePhEG3pcEiaJ3vNXM2Sa6tyQmH9sPDfSFHmp V68iVy14EvlkSFiaLVadcaCdfX1C7uyEpvqTCx9Qy6iu4WpY330rdErGufQInr6t +S58OJd4UF3qpt6GZ0d11EIikMwcf6BQjEDQTGg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=zKHBXp uw+WPRxYjKCr+NVoOy6HmLEmipUWxQdocXY44=; b=Fq+VbBkybpikgWgp2qOWLZ gYejKwOvXLsdF7H0+DdyZb2/oH2bgEK+1ZzGR7Tb+GQgL0jsCi7+t7pjRP2pJlPe ooCgBttACOiSMU/fU7NiM5Ou55eQWXS2rDK+4ygx7JWnsCEWdaL2EQzSA5l72hms tbfyX6Mmu+WiZhlQz+ERKFiK9vqoMEt1sMXlx3aS3OzLyG2B3BDfP5v/AKLystW6 Ppr1jmNbSzq3Qpra9VEfIT/xRZ0vGIvnAzc5WCbc6v0OnTzRLJRdN+a195mWDCD9 sGt0hwaRdNhj2jdUDF9RzRsknSrL4fTk0QgJfk0LbH/qaAIYHiVunifURA/zVhRQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeigedgjeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreertdenucfhrhhomhepfdetnhgu rhgvficulfgvfhhfvghrhidfuceorghnughrvgifsegrjhdrihgurdgruheqnecuggftrf grthhtvghrnhephefhfeekgfekudevheffheeihedujeefjeevjeefudfgfeeutdeuvdeh hfevueffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvgifsegrjhdrihgurdgruh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 7CD5CE00D4; Wed, 2 Dec 2020 10:03:04 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.3.0-622-g4a97c0b-fm-20201115.001-g4a97c0b3 Mime-Version: 1.0 Message-Id: In-Reply-To: References: <20201202063612.21241-1-troy_lee@aspeedtech.com> <20201202063612.21241-3-troy_lee@aspeedtech.com> Date: Thu, 03 Dec 2020 01:32:44 +1030 From: "Andrew Jeffery" To: "Troy Lee" , "Joel Stanley" Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "Tony Luck" , "Ryan Chen" , "James Morse" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "open list" , "Robert Richter" , "leetroy@gmail.com" , "Rob Herring" , "Borislav Petkov" , "Stefan M Schaeckeler" , "Mauro Carvalho Chehab" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "open list:EDAC-CORE" Subject: Re: [PATCH v2 3/3] edac: Supporting AST2400 and AST2600 edac driver Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 2 Dec 2020, at 19:11, Troy Lee wrote: > Hi Joel, > > Thanks for the suggestion, I'll fix the review and create an new patch > against > latest Linux branch. Those exported function will be referenced in > other driver yet > to be upstream, so should I move those exported functions out of this > patch? > Yes, let's leave the exports out of this patch, and add them in when you send the patch that depends on them. Andrew