From: Dan Murphy <dmurphy@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: mark.rutland@arm.com, rpurdie@rpsys.net,
jacek.anaszewski@gmail.com, pavel@ucw.cz,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v2 1/6] dt: bindings: lp8860: Update bindings for lp8860
Date: Thu, 7 Dec 2017 17:08:23 -0600 [thread overview]
Message-ID: <b707d097-496a-1dbd-5872-003d24c3c31f@ti.com> (raw)
In-Reply-To: <20171207224347.hrqwygbm2xb7lzbs@rob-hp-laptop>
Rob
On 12/07/2017 04:43 PM, Rob Herring wrote:
> On Tue, Dec 05, 2017 at 02:43:22PM -0600, Dan Murphy wrote:
>> Update the lp8860 bindings to fix various issues
>> found. Add address-cells and size-cells, rename
>> enable-gpio to enable-gpios, update the node name
>> to the device name and indent the node example.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>>
>> v2 - New patch
>>
>> .../devicetree/bindings/leds/leds-lp8860.txt | 28 ++++++++++++----------
>> 1 file changed, 16 insertions(+), 12 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> index aad38dd94d4b..1b2fab05ec6a 100644
>> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> @@ -6,24 +6,28 @@ current sinks that can be controlled by a PWM input
>> signal, a SPI/I2C master, or both.
>>
>> Required properties:
>> - - compatible:
>> + - compatible :
>> "ti,lp8860"
>> - - reg - I2C slave address
>> - - label - Used for naming LEDs
>> + - reg : I2C slave address
>> + - label : Used for naming LEDs
>> + - #address-cells : 1
>> + - #size-cells : 0
>
> This should be added in the next patch when you have child nodes.
>
Ack
> Rob
>
--
------------------
Dan Murphy
next prev parent reply other threads:[~2017-12-07 23:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 20:43 [PATCH v2 0/6] Updated lp8860 led driver Dan Murphy
[not found] ` <20171205204327.12111-1-dmurphy-l0cyMroinI0@public.gmane.org>
2017-12-05 20:43 ` [PATCH v2 1/6] dt: bindings: lp8860: Update bindings for lp8860 Dan Murphy
2017-12-07 22:42 ` Rob Herring
2017-12-07 23:07 ` Dan Murphy
2017-12-07 22:43 ` Rob Herring
2017-12-07 23:08 ` Dan Murphy [this message]
2017-12-05 20:43 ` [PATCH v2 2/6] dt: bindings: lp8860: Update DT label binding Dan Murphy
2017-12-07 22:45 ` Rob Herring
2017-12-07 23:09 ` Dan Murphy
2017-12-05 20:43 ` [PATCH v2 4/6] dt: bindings: lp8860: Add trigger binding to the lp8860 Dan Murphy
2017-12-07 22:46 ` Rob Herring
2017-12-05 20:43 ` [PATCH v2 3/6] leds: lp8860: Update the dt parsing for LED labeling Dan Murphy
2017-12-05 20:43 ` [PATCH v2 5/6] leds: lp8860: Add DT parsing to retrieve the trigger node Dan Murphy
2017-12-05 20:43 ` [PATCH v2 6/6] leds: lp8860: Various fixes to align with LED framework Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b707d097-496a-1dbd-5872-003d24c3c31f@ti.com \
--to=dmurphy@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).