devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Niedermayr, BENEDIKT" <benedikt.niedermayr@siemens.com>
To: "tony@atomide.com" <tony@atomide.com>
Cc: "rogerq@kernel.org" <rogerq@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>
Subject: Re: [PATCH v9 1/2] memory: omap-gpmc: wait pin additions
Date: Thu, 8 Dec 2022 15:55:01 +0000	[thread overview]
Message-ID: <b72c7b7aa5978100c2e925cf7386e2ecdb39aa5c.camel@siemens.com> (raw)
In-Reply-To: <Y5F69xtIPM87iklg@atomide.com>

Hi Tony,

On Thu, 2022-12-08 at 07:49 +0200, Tony Lindgren wrote:
> * Niedermayr, BENEDIKT <benedikt.niedermayr@siemens.com> [221207 17:29]:
> > I found the cause of this bug.
> > At least when "gpmc_cs_program_settings: invalid wait-pin (-1)" is
> > printed in the kernel log.
> 
> OK
> 
> > Now I'm not sure where to send the bugfix patch (linux-next, linux-omap, 
> > both?). 
> 
> Please send a fix as against current Linux next as a separate patch as
> your earlier patches have been already applied for the merge window.

OK. Thanks!

> If dts changes are also needed, let's first try to fix the driver to
> handle
> the invalid wait-pin case. Then we can patch the dts files separately as
> needed.
No need for dts changes. One concern for the wait-pin implementation was to
not break existing dts's where the wait-pin is not used.   

> 
> Regards,
> 
> Tony

cheers,
Benedikt

  reply	other threads:[~2022-12-08 15:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02 13:30 [PATCH v9 0/2] gpmc wait pin additions B. Niedermayr
2022-11-02 13:30 ` [PATCH v9 1/2] memory: omap-gpmc: " B. Niedermayr
2022-12-07 13:51   ` Tony Lindgren
2022-12-07 14:52     ` Niedermayr, BENEDIKT
2022-12-07 15:06       ` Tony Lindgren
2022-12-07 17:28         ` Niedermayr, BENEDIKT
2022-12-08  5:49           ` Tony Lindgren
2022-12-08 15:55             ` Niedermayr, BENEDIKT [this message]
2022-12-12  7:16               ` Tony Lindgren
2022-11-02 13:30 ` [PATCH v9 2/2] dt-bindings: memory-controllers: gpmc-child: add wait-pin polarity B. Niedermayr
2022-11-02 14:02 ` [PATCH v9 0/2] gpmc wait pin additions Krzysztof Kozlowski
2022-11-03  8:13   ` Niedermayr, BENEDIKT
2022-11-03 12:37     ` Krzysztof Kozlowski
2022-11-02 14:03 ` Krzysztof Kozlowski
2022-11-03  8:07   ` Niedermayr, BENEDIKT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b72c7b7aa5978100c2e925cf7386e2ecdb39aa5c.camel@siemens.com \
    --to=benedikt.niedermayr@siemens.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).