From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DFA3C28D13 for ; Thu, 25 Aug 2022 14:49:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242072AbiHYOtp (ORCPT ); Thu, 25 Aug 2022 10:49:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242143AbiHYOto (ORCPT ); Thu, 25 Aug 2022 10:49:44 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1ECB0B2860 for ; Thu, 25 Aug 2022 07:49:43 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id d23so24203720lfl.13 for ; Thu, 25 Aug 2022 07:49:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=zQBjygS8SCHVF5NWTeRq0S8WBLCqlWIJPLS18A425Jo=; b=HLeBSz4kbNvFBK2P5M3BUEWz5YfE1cWTZpxBfcHVg0Xm22DwGf4nM4lNhaKlqKUtTY HCG9RVM+gXQMICAR0zuPCPaBxObGxiLDo7tW3/b8Z5aAGl03tj4gcK1awwCxqf98T2kP N7AWdUaPU0tpFqwfuiEeviuIA8S5Voofy58ouGqN6E9NFYDl6PO7K3Qhp2u4fPKVEUGz z9GNZNcE6iQK0Hjx/kKvJM1kP5/kmNcKVnWAzf7k4sboEACFOSLnB2Rw68p9/3RAwrLx 6gcZiSpR/wljBf827mhfo9engPN0aQHEsBLwPADZmXOyiLSnS5XXjqEFw+JXRviBex5Y zEkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=zQBjygS8SCHVF5NWTeRq0S8WBLCqlWIJPLS18A425Jo=; b=OCpK42Vz7kaik1JFwK7N5DACZr8y6I1i4HjP21ybLRp/iNWPMEpobsWuaheCd6ZHxA pa/HJ6wCHCAdCrKUxM8tKbM4uezyJwZspsW+3awPUb7seb3uS7LP+7oq357192VnewRL oLVbjbJ9eKCkq+4SNvGI1L0dNwB12WcddXdr4u4D0ul4jbkSd5L1/xt9lUpvErfGAgL3 3uo3T+y5lS3p5V0muY2Dvh/FUMfJ5aM8yMzbZXKcEWINCLeW0QfkEo8DzzaXx/jylup8 NxpWoFVjZwqM1F7B7F4IX59WZnzSWzHRoPNXXuQWXYjBEpXeljfdfqAD2nSRncdYv9Yd 1wRA== X-Gm-Message-State: ACgBeo0RINBIW+XIO7dm73gvIGZM7EaUfmzukGpIflZA4YJlmuD2mBcI +Gvn7xILTanyLd8Sdi5e0XYaQA== X-Google-Smtp-Source: AA6agR4nHsUMcKPDNfT/Ev+u7ZNpF9ElXAOXYDZRDAdUrPqz6QvM9j3oewQPKa33v+Q+8QyiBiPSqw== X-Received: by 2002:ac2:515c:0:b0:492:df83:8bc1 with SMTP id q28-20020ac2515c000000b00492df838bc1mr1167327lfd.620.1661438981469; Thu, 25 Aug 2022 07:49:41 -0700 (PDT) Received: from [192.168.0.71] (82.131.98.15.cable.starman.ee. [82.131.98.15]) by smtp.gmail.com with ESMTPSA id k4-20020a05651210c400b0048d1101d0d6sm532399lfg.121.2022.08.25.07.49.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Aug 2022 07:49:40 -0700 (PDT) Message-ID: Date: Thu, 25 Aug 2022 17:49:40 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v3 1/2] Documentation: devicetree: update bindings for tps23861 Content-Language: en-US To: =?UTF-8?Q?Andreas_B=c3=b6hler?= Cc: Robert Marko , Luka Perkov , Jean Delvare , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220825143737.77732-1-dev@aboehler.at> From: Krzysztof Kozlowski In-Reply-To: <20220825143737.77732-1-dev@aboehler.at> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 25/08/2022 17:37, Andreas Böhler wrote: > The tps23861 driver does not initialize the chip and relies on it being > in auto-mode by default. On some devices, these controllers default to > OFF-Mode and hence cannot be used at all. > Thank you for your patch. There is something to discuss/improve. > This brings minimal support for initializing the controller in a user- > defined mode. > > Signed-off-by: Andreas Böhler Use subject prefixes matching the subsystem (git log --oneline -- ...). > --- > .../bindings/hwmon/ti,tps23861.yaml | 76 +++++++++++++++++++ > 1 file changed, 76 insertions(+) > > diff --git a/Documentation/devicetree/bindings/hwmon/ti,tps23861.yaml b/Documentation/devicetree/bindings/hwmon/ti,tps23861.yaml > index 3bc8e73dfbf0..ed3a703478fb 100644 > --- a/Documentation/devicetree/bindings/hwmon/ti,tps23861.yaml > +++ b/Documentation/devicetree/bindings/hwmon/ti,tps23861.yaml > @@ -35,6 +35,50 @@ required: > - compatible > - reg > > +patternProperties: > + "^port@([0-3])$": No need for () > + type: object > + description: Represents ports of the device and their specific configuration. > + > + properties: > + reg: > + description: The port number > + items: > + minimum: 0 > + maximum: 3 > + > + mode: > + description: The operating mode the device should be initialized with > + items: If this is real array, you need maxItems, but it looks one item, so no need for "items". > + - enum: > + - auto > + - semiauto > + - manual > + - off And how "off" is different from disabled or powered off? > + > + enable: > + description: Whether the port should be enabled This looks confusing... Looks like boolean property, but instead you define some numbers. What are the values for these numbers? Why these are numbers not booleans? Second - what does it mean "enable"? We have a generic "status" property for it - isn't this the same? Third, all these properties (especially PoE) look like you keep describing here network device but this is HWMON part. > + items: > + minimum: 0 > + maximum: 1 > + > + power: > + description: Whether the port should be powered on > + items: > + minimum: 0 > + maximum: 1 > + > + poe_plus: No underscores in property names. > + description: Whether the port should support PoE+ > + items: > + minimum: 0 > + maximum: 1 > + Best regards, Krzysztof