devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] dt-bindings: watchdog: re-order entries to match coding convention
@ 2023-11-05 18:41 Krzysztof Kozlowski
  2023-11-05 18:41 ` [PATCH 2/2] dt-bindings: watchdog: intel,keembay: reference common watchdog schema Krzysztof Kozlowski
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-05 18:41 UTC (permalink / raw)
  To: Wim Van Sebroeck, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland,
	Hector Martin, Sven Peter, Alyssa Rosenzweig, Julius Werner,
	Evan Benn, Florian Fainelli, Broadcom internal kernel review list,
	Maxime Ripard, Oleksij Rempel, Justin Chen, �ecki,
	Baruch Siach, Ahmad Zainie, Marc Zyngier, Linus Walleij,
	Jamie Iles, linux-watchdog, devicetree, linux-arm-kernel,
	linux-sunxi, linux-kernel, asahi
  Cc: Krzysztof Kozlowski

The Devicetree bindings coding convention, as used in most of the files
and expressed in Documentation/devicetree/bindings/example-schema.yaml,
expects:
1. "allOf:" block just before "properties:" (or after "required:" for
   more complex cases),
2. additionalProperties/unevaluatedProperties at the end of the file,
   just before the examples section.

Re-order few schemas to match the convention to avoid repeating review
comments for new patches using existing code as template.  No functional
changes.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../bindings/watchdog/allwinner,sun4i-a10-wdt.yaml     |  6 +++---
 .../bindings/watchdog/alphascale,asm9260-wdt.yaml      |  6 +++---
 .../devicetree/bindings/watchdog/apple,wdt.yaml        |  6 +++---
 .../devicetree/bindings/watchdog/arm-smc-wdt.yaml      |  6 +++---
 .../devicetree/bindings/watchdog/brcm,bcm7038-wdt.yaml | 10 +++++-----
 .../devicetree/bindings/watchdog/cnxt,cx92755-wdt.yaml |  6 +++---
 .../devicetree/bindings/watchdog/maxim,max63xx.yaml    |  8 ++++----
 .../devicetree/bindings/watchdog/snps,dw-wdt.yaml      | 10 +++++-----
 8 files changed, 29 insertions(+), 29 deletions(-)

diff --git a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
index 274519fc24fd..64c8f7393809 100644
--- a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
@@ -6,13 +6,13 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: Allwinner A10 Watchdog
 
-allOf:
-  - $ref: watchdog.yaml#
-
 maintainers:
   - Chen-Yu Tsai <wens@csie.org>
   - Maxime Ripard <mripard@kernel.org>
 
+allOf:
+  - $ref: watchdog.yaml#
+
 properties:
   compatible:
     oneOf:
diff --git a/Documentation/devicetree/bindings/watchdog/alphascale,asm9260-wdt.yaml b/Documentation/devicetree/bindings/watchdog/alphascale,asm9260-wdt.yaml
index fea84f5b7e6d..6425fe51d20c 100644
--- a/Documentation/devicetree/bindings/watchdog/alphascale,asm9260-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/alphascale,asm9260-wdt.yaml
@@ -6,12 +6,12 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: Alphascale asm9260 Watchdog timer
 
-allOf:
-  - $ref: watchdog.yaml#
-
 maintainers:
   - Oleksij Rempel <linux@rempel-privat.de>
 
+allOf:
+  - $ref: watchdog.yaml#
+
 properties:
   compatible:
     const: alphascale,asm9260-wdt
diff --git a/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml b/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml
index 929681127df0..21872e15916c 100644
--- a/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml
@@ -6,12 +6,12 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: Apple SoC Watchdog
 
-allOf:
-  - $ref: watchdog.yaml#
-
 maintainers:
   - Sven Peter <sven@svenpeter.dev>
 
+allOf:
+  - $ref: watchdog.yaml#
+
 properties:
   compatible:
     items:
diff --git a/Documentation/devicetree/bindings/watchdog/arm-smc-wdt.yaml b/Documentation/devicetree/bindings/watchdog/arm-smc-wdt.yaml
index b5573852ef5a..8e9d0b7e8244 100644
--- a/Documentation/devicetree/bindings/watchdog/arm-smc-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/arm-smc-wdt.yaml
@@ -6,12 +6,12 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: ARM Secure Monitor Call based watchdog
 
-allOf:
-  - $ref: watchdog.yaml#
-
 maintainers:
   - Julius Werner <jwerner@chromium.org>
 
+allOf:
+  - $ref: watchdog.yaml#
+
 properties:
   compatible:
     enum:
diff --git a/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.yaml b/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.yaml
index 526ff908d134..e898167ef628 100644
--- a/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.yaml
@@ -6,14 +6,14 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: BCM63xx and BCM7038 watchdog timer
 
-allOf:
-  - $ref: watchdog.yaml#
-
 maintainers:
   - Florian Fainelli <f.fainelli@gmail.com>
   - Justin Chen <justinpopo6@gmail.com>
   - Rafał Miłecki <rafal@milecki.pl>
 
+allOf:
+  - $ref: watchdog.yaml#
+
 properties:
   compatible:
     enum:
@@ -29,11 +29,11 @@ properties:
       The clock running the watchdog. If no clock is found the driver will
       default to 27000000 Hz.
 
-unevaluatedProperties: false
-
 required:
   - reg
 
+unevaluatedProperties: false
+
 examples:
   - |
     watchdog@f040a7e8 {
diff --git a/Documentation/devicetree/bindings/watchdog/cnxt,cx92755-wdt.yaml b/Documentation/devicetree/bindings/watchdog/cnxt,cx92755-wdt.yaml
index 1844d7e026fe..13236ee61f6f 100644
--- a/Documentation/devicetree/bindings/watchdog/cnxt,cx92755-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/cnxt,cx92755-wdt.yaml
@@ -12,12 +12,12 @@ description: |
   timer counters. The first timer (called "Timer A") is the only one that can be
   used as watchdog.
 
-allOf:
-  - $ref: watchdog.yaml#
-
 maintainers:
   - Baruch Siach <baruch@tkos.co.il>
 
+allOf:
+  - $ref: watchdog.yaml#
+
 properties:
   compatible:
     const: cnxt,cx92755-wdt
diff --git a/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml b/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
index 1a6490c43d89..442c21f12a3b 100644
--- a/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
+++ b/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
@@ -6,14 +6,14 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: Maxim 63xx Watchdog Timers
 
-allOf:
-  - $ref: watchdog.yaml#
-  - $ref: /schemas/memory-controllers/mc-peripheral-props.yaml#
-
 maintainers:
   - Marc Zyngier <maz@kernel.org>
   - Linus Walleij <linus.walleij@linaro.org>
 
+allOf:
+  - $ref: watchdog.yaml#
+  - $ref: /schemas/memory-controllers/mc-peripheral-props.yaml#
+
 properties:
   compatible:
     enum:
diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
index 76eceeddd150..c7aab0418a32 100644
--- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
@@ -6,12 +6,12 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: Synopsys Designware Watchdog Timer
 
-allOf:
-  - $ref: watchdog.yaml#
-
 maintainers:
   - Jamie Iles <jamie@jamieiles.com>
 
+allOf:
+  - $ref: watchdog.yaml#
+
 properties:
   compatible:
     oneOf:
@@ -73,13 +73,13 @@ properties:
     minItems: 16
     maxItems: 16
 
-unevaluatedProperties: false
-
 required:
   - compatible
   - reg
   - clocks
 
+unevaluatedProperties: false
+
 examples:
   - |
     watchdog@ffd02000 {
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 2/2] dt-bindings: watchdog: intel,keembay: reference common watchdog schema
  2023-11-05 18:41 [PATCH 1/2] dt-bindings: watchdog: re-order entries to match coding convention Krzysztof Kozlowski
@ 2023-11-05 18:41 ` Krzysztof Kozlowski
  2023-11-05 19:05   ` Guenter Roeck
  2023-11-08 16:41   ` Rob Herring
  2023-11-05 19:04 ` [PATCH 1/2] dt-bindings: watchdog: re-order entries to match coding convention Guenter Roeck
                   ` (2 subsequent siblings)
  3 siblings, 2 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-05 18:41 UTC (permalink / raw)
  To: Wim Van Sebroeck, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland,
	Hector Martin, Sven Peter, Alyssa Rosenzweig, Julius Werner,
	Evan Benn, Florian Fainelli, Broadcom internal kernel review list,
	Maxime Ripard, Oleksij Rempel, Justin Chen, �ecki,
	Baruch Siach, Ahmad Zainie, Marc Zyngier, Linus Walleij,
	Jamie Iles, linux-watchdog, devicetree, linux-arm-kernel,
	linux-sunxi, linux-kernel, asahi
  Cc: Krzysztof Kozlowski

Reference common watchdog.yaml schema to allow "timeout-sec" property
and enforce proper device node name.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../devicetree/bindings/watchdog/intel,keembay-wdt.yaml      | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/watchdog/intel,keembay-wdt.yaml b/Documentation/devicetree/bindings/watchdog/intel,keembay-wdt.yaml
index 1437ff8a122f..8231dde2bfa6 100644
--- a/Documentation/devicetree/bindings/watchdog/intel,keembay-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/intel,keembay-wdt.yaml
@@ -9,6 +9,9 @@ title: Intel Keem Bay SoC non-secure Watchdog Timer
 maintainers:
   - Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@intel.com>
 
+allOf:
+  - $ref: watchdog.yaml#
+
 properties:
   compatible:
     enum:
@@ -37,7 +40,7 @@ required:
   - interrupt-names
   - clocks
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] dt-bindings: watchdog: re-order entries to match coding convention
  2023-11-05 18:41 [PATCH 1/2] dt-bindings: watchdog: re-order entries to match coding convention Krzysztof Kozlowski
  2023-11-05 18:41 ` [PATCH 2/2] dt-bindings: watchdog: intel,keembay: reference common watchdog schema Krzysztof Kozlowski
@ 2023-11-05 19:04 ` Guenter Roeck
  2023-11-06  8:10 ` Rafał Miłecki
  2023-11-08 16:41 ` Rob Herring
  3 siblings, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2023-11-05 19:04 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Wim Van Sebroeck, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai, Jernej Skrabec,
	Samuel Holland, Hector Martin, Sven Peter, Alyssa Rosenzweig,
	Julius Werner, Evan Benn, Florian Fainelli,
	Broadcom internal kernel review list, Maxime Ripard,
	Oleksij Rempel, Justin Chen, �ecki, Baruch Siach,
	Ahmad Zainie, Marc Zyngier, Linus Walleij, Jamie Iles,
	linux-watchdog, devicetree, linux-arm-kernel, linux-sunxi,
	linux-kernel, asahi

On 11/5/23 10:41, Krzysztof Kozlowski wrote:
> The Devicetree bindings coding convention, as used in most of the files
> and expressed in Documentation/devicetree/bindings/example-schema.yaml,
> expects:
> 1. "allOf:" block just before "properties:" (or after "required:" for
>     more complex cases),
> 2. additionalProperties/unevaluatedProperties at the end of the file,
>     just before the examples section.
> 
> Re-order few schemas to match the convention to avoid repeating review
> comments for new patches using existing code as template.  No functional
> changes.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Acked-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   .../bindings/watchdog/allwinner,sun4i-a10-wdt.yaml     |  6 +++---
>   .../bindings/watchdog/alphascale,asm9260-wdt.yaml      |  6 +++---
>   .../devicetree/bindings/watchdog/apple,wdt.yaml        |  6 +++---
>   .../devicetree/bindings/watchdog/arm-smc-wdt.yaml      |  6 +++---
>   .../devicetree/bindings/watchdog/brcm,bcm7038-wdt.yaml | 10 +++++-----
>   .../devicetree/bindings/watchdog/cnxt,cx92755-wdt.yaml |  6 +++---
>   .../devicetree/bindings/watchdog/maxim,max63xx.yaml    |  8 ++++----
>   .../devicetree/bindings/watchdog/snps,dw-wdt.yaml      | 10 +++++-----
>   8 files changed, 29 insertions(+), 29 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
> index 274519fc24fd..64c8f7393809 100644
> --- a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
> @@ -6,13 +6,13 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
>   
>   title: Allwinner A10 Watchdog
>   
> -allOf:
> -  - $ref: watchdog.yaml#
> -
>   maintainers:
>     - Chen-Yu Tsai <wens@csie.org>
>     - Maxime Ripard <mripard@kernel.org>
>   
> +allOf:
> +  - $ref: watchdog.yaml#
> +
>   properties:
>     compatible:
>       oneOf:
> diff --git a/Documentation/devicetree/bindings/watchdog/alphascale,asm9260-wdt.yaml b/Documentation/devicetree/bindings/watchdog/alphascale,asm9260-wdt.yaml
> index fea84f5b7e6d..6425fe51d20c 100644
> --- a/Documentation/devicetree/bindings/watchdog/alphascale,asm9260-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/alphascale,asm9260-wdt.yaml
> @@ -6,12 +6,12 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
>   
>   title: Alphascale asm9260 Watchdog timer
>   
> -allOf:
> -  - $ref: watchdog.yaml#
> -
>   maintainers:
>     - Oleksij Rempel <linux@rempel-privat.de>
>   
> +allOf:
> +  - $ref: watchdog.yaml#
> +
>   properties:
>     compatible:
>       const: alphascale,asm9260-wdt
> diff --git a/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml b/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml
> index 929681127df0..21872e15916c 100644
> --- a/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml
> @@ -6,12 +6,12 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
>   
>   title: Apple SoC Watchdog
>   
> -allOf:
> -  - $ref: watchdog.yaml#
> -
>   maintainers:
>     - Sven Peter <sven@svenpeter.dev>
>   
> +allOf:
> +  - $ref: watchdog.yaml#
> +
>   properties:
>     compatible:
>       items:
> diff --git a/Documentation/devicetree/bindings/watchdog/arm-smc-wdt.yaml b/Documentation/devicetree/bindings/watchdog/arm-smc-wdt.yaml
> index b5573852ef5a..8e9d0b7e8244 100644
> --- a/Documentation/devicetree/bindings/watchdog/arm-smc-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/arm-smc-wdt.yaml
> @@ -6,12 +6,12 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
>   
>   title: ARM Secure Monitor Call based watchdog
>   
> -allOf:
> -  - $ref: watchdog.yaml#
> -
>   maintainers:
>     - Julius Werner <jwerner@chromium.org>
>   
> +allOf:
> +  - $ref: watchdog.yaml#
> +
>   properties:
>     compatible:
>       enum:
> diff --git a/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.yaml b/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.yaml
> index 526ff908d134..e898167ef628 100644
> --- a/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.yaml
> @@ -6,14 +6,14 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
>   
>   title: BCM63xx and BCM7038 watchdog timer
>   
> -allOf:
> -  - $ref: watchdog.yaml#
> -
>   maintainers:
>     - Florian Fainelli <f.fainelli@gmail.com>
>     - Justin Chen <justinpopo6@gmail.com>
>     - Rafał Miłecki <rafal@milecki.pl>
>   
> +allOf:
> +  - $ref: watchdog.yaml#
> +
>   properties:
>     compatible:
>       enum:
> @@ -29,11 +29,11 @@ properties:
>         The clock running the watchdog. If no clock is found the driver will
>         default to 27000000 Hz.
>   
> -unevaluatedProperties: false
> -
>   required:
>     - reg
>   
> +unevaluatedProperties: false
> +
>   examples:
>     - |
>       watchdog@f040a7e8 {
> diff --git a/Documentation/devicetree/bindings/watchdog/cnxt,cx92755-wdt.yaml b/Documentation/devicetree/bindings/watchdog/cnxt,cx92755-wdt.yaml
> index 1844d7e026fe..13236ee61f6f 100644
> --- a/Documentation/devicetree/bindings/watchdog/cnxt,cx92755-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/cnxt,cx92755-wdt.yaml
> @@ -12,12 +12,12 @@ description: |
>     timer counters. The first timer (called "Timer A") is the only one that can be
>     used as watchdog.
>   
> -allOf:
> -  - $ref: watchdog.yaml#
> -
>   maintainers:
>     - Baruch Siach <baruch@tkos.co.il>
>   
> +allOf:
> +  - $ref: watchdog.yaml#
> +
>   properties:
>     compatible:
>       const: cnxt,cx92755-wdt
> diff --git a/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml b/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
> index 1a6490c43d89..442c21f12a3b 100644
> --- a/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
> @@ -6,14 +6,14 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
>   
>   title: Maxim 63xx Watchdog Timers
>   
> -allOf:
> -  - $ref: watchdog.yaml#
> -  - $ref: /schemas/memory-controllers/mc-peripheral-props.yaml#
> -
>   maintainers:
>     - Marc Zyngier <maz@kernel.org>
>     - Linus Walleij <linus.walleij@linaro.org>
>   
> +allOf:
> +  - $ref: watchdog.yaml#
> +  - $ref: /schemas/memory-controllers/mc-peripheral-props.yaml#
> +
>   properties:
>     compatible:
>       enum:
> diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> index 76eceeddd150..c7aab0418a32 100644
> --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> @@ -6,12 +6,12 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
>   
>   title: Synopsys Designware Watchdog Timer
>   
> -allOf:
> -  - $ref: watchdog.yaml#
> -
>   maintainers:
>     - Jamie Iles <jamie@jamieiles.com>
>   
> +allOf:
> +  - $ref: watchdog.yaml#
> +
>   properties:
>     compatible:
>       oneOf:
> @@ -73,13 +73,13 @@ properties:
>       minItems: 16
>       maxItems: 16
>   
> -unevaluatedProperties: false
> -
>   required:
>     - compatible
>     - reg
>     - clocks
>   
> +unevaluatedProperties: false
> +
>   examples:
>     - |
>       watchdog@ffd02000 {


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] dt-bindings: watchdog: intel,keembay: reference common watchdog schema
  2023-11-05 18:41 ` [PATCH 2/2] dt-bindings: watchdog: intel,keembay: reference common watchdog schema Krzysztof Kozlowski
@ 2023-11-05 19:05   ` Guenter Roeck
  2023-11-08 16:41   ` Rob Herring
  1 sibling, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2023-11-05 19:05 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Wim Van Sebroeck, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai, Jernej Skrabec,
	Samuel Holland, Hector Martin, Sven Peter, Alyssa Rosenzweig,
	Julius Werner, Evan Benn, Florian Fainelli,
	Broadcom internal kernel review list, Maxime Ripard,
	Oleksij Rempel, Justin Chen, �ecki, Baruch Siach,
	Ahmad Zainie, Marc Zyngier, Linus Walleij, Jamie Iles,
	linux-watchdog, devicetree, linux-arm-kernel, linux-sunxi,
	linux-kernel, asahi

On 11/5/23 10:41, Krzysztof Kozlowski wrote:
> Reference common watchdog.yaml schema to allow "timeout-sec" property
> and enforce proper device node name.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Acked-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   .../devicetree/bindings/watchdog/intel,keembay-wdt.yaml      | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/intel,keembay-wdt.yaml b/Documentation/devicetree/bindings/watchdog/intel,keembay-wdt.yaml
> index 1437ff8a122f..8231dde2bfa6 100644
> --- a/Documentation/devicetree/bindings/watchdog/intel,keembay-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/intel,keembay-wdt.yaml
> @@ -9,6 +9,9 @@ title: Intel Keem Bay SoC non-secure Watchdog Timer
>   maintainers:
>     - Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@intel.com>
>   
> +allOf:
> +  - $ref: watchdog.yaml#
> +
>   properties:
>     compatible:
>       enum:
> @@ -37,7 +40,7 @@ required:
>     - interrupt-names
>     - clocks
>   
> -additionalProperties: false
> +unevaluatedProperties: false
>   
>   examples:
>     - |


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] dt-bindings: watchdog: re-order entries to match coding convention
  2023-11-05 18:41 [PATCH 1/2] dt-bindings: watchdog: re-order entries to match coding convention Krzysztof Kozlowski
  2023-11-05 18:41 ` [PATCH 2/2] dt-bindings: watchdog: intel,keembay: reference common watchdog schema Krzysztof Kozlowski
  2023-11-05 19:04 ` [PATCH 1/2] dt-bindings: watchdog: re-order entries to match coding convention Guenter Roeck
@ 2023-11-06  8:10 ` Rafał Miłecki
  2023-11-08 16:40   ` Rob Herring
  2023-11-08 16:41 ` Rob Herring
  3 siblings, 1 reply; 8+ messages in thread
From: Rafał Miłecki @ 2023-11-06  8:10 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Wim Van Sebroeck, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland,
	Hector Martin, Sven Peter, Alyssa Rosenzweig, Julius Werner,
	Evan Benn, Florian Fainelli, Broadcom internal kernel review list,
	Maxime Ripard, Oleksij Rempel, Justin Chen, Baruch Siach,
	Ahmad Zainie, Marc Zyngier, Linus Walleij, Jamie Iles,
	linux-watchdog, devicetree, linux-arm-kernel, linux-sunxi,
	linux-kernel, asahi

On 2023-11-05 19:41, Krzysztof Kozlowski wrote:
> The Devicetree bindings coding convention, as used in most of the files
> and expressed in Documentation/devicetree/bindings/example-schema.yaml,
> expects:
> 1. "allOf:" block just before "properties:" (or after "required:" for
>    more complex cases),
> 2. additionalProperties/unevaluatedProperties at the end of the file,
>    just before the examples section.
> 
> Re-order few schemas to match the convention to avoid repeating review
> comments for new patches using existing code as template.  No 
> functional
> changes.

It's surely going to help a bit but for a long time solution maybe you
could consider adding proper check to Rob's bot and/or checkpatch.pl.

-- 
Rafał Miłecki

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] dt-bindings: watchdog: re-order entries to match coding convention
  2023-11-06  8:10 ` Rafał Miłecki
@ 2023-11-08 16:40   ` Rob Herring
  0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2023-11-08 16:40 UTC (permalink / raw)
  To: Rafał Miłecki
  Cc: Krzysztof Kozlowski, Wim Van Sebroeck, Guenter Roeck,
	Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai, Jernej Skrabec,
	Samuel Holland, Hector Martin, Sven Peter, Alyssa Rosenzweig,
	Julius Werner, Evan Benn, Florian Fainelli,
	Broadcom internal kernel review list, Maxime Ripard,
	Oleksij Rempel, Justin Chen, Baruch Siach, Ahmad Zainie,
	Marc Zyngier, Linus Walleij, Jamie Iles, linux-watchdog,
	devicetree, linux-arm-kernel, linux-sunxi, linux-kernel, asahi

On Mon, Nov 06, 2023 at 09:10:44AM +0100, Rafał Miłecki wrote:
> On 2023-11-05 19:41, Krzysztof Kozlowski wrote:
> > The Devicetree bindings coding convention, as used in most of the files
> > and expressed in Documentation/devicetree/bindings/example-schema.yaml,
> > expects:
> > 1. "allOf:" block just before "properties:" (or after "required:" for
> >    more complex cases),
> > 2. additionalProperties/unevaluatedProperties at the end of the file,
> >    just before the examples section.
> > 
> > Re-order few schemas to match the convention to avoid repeating review
> > comments for new patches using existing code as template.  No functional
> > changes.
> 
> It's surely going to help a bit but for a long time solution maybe you
> could consider adding proper check to Rob's bot and/or checkpatch.pl.

I have such a check I wrote long ago. tools/yaml-format in dtschema. It 
just does a ruamel read and write back out so you get exactly how ruamel 
is configured or defaults to for things not configurable. Primarily, the 
non-configurable part is multi-line text without a '|'. So lots of 
'description' paragraphs are reformatted. It ends up being too strict 
IMO.

The key order is checked, but not fixed. Probably could add reordering.

Adding this by default (and to the bot) means fixing *every* file in 
tree first. That's not something I care to do and enforce.

Rob

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] dt-bindings: watchdog: re-order entries to match coding convention
  2023-11-05 18:41 [PATCH 1/2] dt-bindings: watchdog: re-order entries to match coding convention Krzysztof Kozlowski
                   ` (2 preceding siblings ...)
  2023-11-06  8:10 ` Rafał Miłecki
@ 2023-11-08 16:41 ` Rob Herring
  3 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2023-11-08 16:41 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Conor Dooley, Hector Martin, Chen-Yu Tsai, Marc Zyngier,
	Oleksij Rempel, Jamie Iles, asahi, Samuel Holland, Maxime Ripard,
	Wim Van Sebroeck, Broadcom internal kernel review list,
	devicetree, linux-sunxi, linux-kernel, Linus Walleij,
	Ahmad Zainie, Rob Herring, linux-watchdog, Julius Werner,
	Sven Peter, Justin Chen, Evan Benn, Florian Fainelli,
	linux-arm-kernel, Guenter Roeck, Baruch Siach, �ecki,
	Alyssa Rosenzweig, Krzysztof Kozlowski, Jernej Skrabec


On Sun, 05 Nov 2023 19:41:53 +0100, Krzysztof Kozlowski wrote:
> The Devicetree bindings coding convention, as used in most of the files
> and expressed in Documentation/devicetree/bindings/example-schema.yaml,
> expects:
> 1. "allOf:" block just before "properties:" (or after "required:" for
>    more complex cases),
> 2. additionalProperties/unevaluatedProperties at the end of the file,
>    just before the examples section.
> 
> Re-order few schemas to match the convention to avoid repeating review
> comments for new patches using existing code as template.  No functional
> changes.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../bindings/watchdog/allwinner,sun4i-a10-wdt.yaml     |  6 +++---
>  .../bindings/watchdog/alphascale,asm9260-wdt.yaml      |  6 +++---
>  .../devicetree/bindings/watchdog/apple,wdt.yaml        |  6 +++---
>  .../devicetree/bindings/watchdog/arm-smc-wdt.yaml      |  6 +++---
>  .../devicetree/bindings/watchdog/brcm,bcm7038-wdt.yaml | 10 +++++-----
>  .../devicetree/bindings/watchdog/cnxt,cx92755-wdt.yaml |  6 +++---
>  .../devicetree/bindings/watchdog/maxim,max63xx.yaml    |  8 ++++----
>  .../devicetree/bindings/watchdog/snps,dw-wdt.yaml      | 10 +++++-----
>  8 files changed, 29 insertions(+), 29 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] dt-bindings: watchdog: intel,keembay: reference common watchdog schema
  2023-11-05 18:41 ` [PATCH 2/2] dt-bindings: watchdog: intel,keembay: reference common watchdog schema Krzysztof Kozlowski
  2023-11-05 19:05   ` Guenter Roeck
@ 2023-11-08 16:41   ` Rob Herring
  1 sibling, 0 replies; 8+ messages in thread
From: Rob Herring @ 2023-11-08 16:41 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Julius Werner, linux-watchdog, Justin Chen, Oleksij Rempel,
	Alyssa Rosenzweig, linux-sunxi, Evan Benn, Guenter Roeck,
	Wim Van Sebroeck, Jernej Skrabec, asahi, Sven Peter,
	Maxime Ripard, devicetree, Hector Martin, Jamie Iles,
	Ahmad Zainie, Baruch Siach, linux-kernel, Conor Dooley,
	�ecki, Samuel Holland, Rob Herring, Chen-Yu Tsai,
	Linus Walleij, Florian Fainelli,
	Broadcom internal kernel review list, Marc Zyngier,
	Krzysztof Kozlowski, linux-arm-kernel


On Sun, 05 Nov 2023 19:41:54 +0100, Krzysztof Kozlowski wrote:
> Reference common watchdog.yaml schema to allow "timeout-sec" property
> and enforce proper device node name.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../devicetree/bindings/watchdog/intel,keembay-wdt.yaml      | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2023-11-08 16:41 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-05 18:41 [PATCH 1/2] dt-bindings: watchdog: re-order entries to match coding convention Krzysztof Kozlowski
2023-11-05 18:41 ` [PATCH 2/2] dt-bindings: watchdog: intel,keembay: reference common watchdog schema Krzysztof Kozlowski
2023-11-05 19:05   ` Guenter Roeck
2023-11-08 16:41   ` Rob Herring
2023-11-05 19:04 ` [PATCH 1/2] dt-bindings: watchdog: re-order entries to match coding convention Guenter Roeck
2023-11-06  8:10 ` Rafał Miłecki
2023-11-08 16:40   ` Rob Herring
2023-11-08 16:41 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).