[PATCH 0/3] media: vgxy61: Remove vendor prefix from driver name

[PATCH 0/3] media: vgxy61: Remove vendor prefix from driver name

[Benjamin Mugnier]

This is a follow up of the discussion we had [1] on drivers naming scheme.
Basically the vendor prefix should not be part of the driver's name.

This series renames the driver from 'st-vgxy61' to 'vgxy61' and the device tree
compatible string from 'st,st-vgxy61' to 'st-vgxy61', therefore avoiding the
vendor prefix duplication.
Backward compatibility is preserved.
Makes the vgxy64 driver consistent with the soon to come v3 of the vd56g3
series.

Thanks,
Benjamin

[1] https://lore.kernel.org/lkml/ZlToLtUkVqzrZf4p@valkosipuli.retiisi.eu/

Benjamin Mugnier (3):
  media: vgxy61: Fix driver name
  media: vgxy61: Add legacy compatible string
  media: vgxy61: Add MODULE_ALIAS()

 .../media/i2c/{st,st-vgxy61.yaml => st,vgxy61.yaml}       | 6 +++---
 Documentation/userspace-api/media/drivers/index.rst       | 2 +-
 .../media/drivers/{st-vgxy61.rst => vgxy61.rst}           | 0
 MAINTAINERS                                               | 8 ++++----
 drivers/media/i2c/Kconfig                                 | 2 +-
 drivers/media/i2c/Makefile                                | 2 +-
 drivers/media/i2c/{st-vgxy61.c => vgxy61.c}               | 8 +++++++-
 7 files changed, 17 insertions(+), 11 deletions(-)
 rename Documentation/devicetree/bindings/media/i2c/{st,st-vgxy61.yaml => st,vgxy61.yaml} (95%)
 rename Documentation/userspace-api/media/drivers/{st-vgxy61.rst => vgxy61.rst} (100%)
 rename drivers/media/i2c/{st-vgxy61.c => vgxy61.c} (99%)

-- 
2.25.1

[PATCH 1/3] media: vgxy61: Fix driver name

[Benjamin Mugnier]

From 'st-vgxy61' to 'vgxy61'.
Align with other drivers to not use the vendor prefix.
Also the vendor prefix is already mentioned in the device tree
compatible string, being 'st,vgxy61', and does not need to be expressed twice.

Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
---
 .../media/i2c/{st,st-vgxy61.yaml => st,vgxy61.yaml}       | 6 +++---
 Documentation/userspace-api/media/drivers/index.rst       | 2 +-
 .../media/drivers/{st-vgxy61.rst => vgxy61.rst}           | 0
 MAINTAINERS                                               | 8 ++++----
 drivers/media/i2c/Kconfig                                 | 2 +-
 drivers/media/i2c/Makefile                                | 2 +-
 drivers/media/i2c/{st-vgxy61.c => vgxy61.c}               | 2 +-
 7 files changed, 11 insertions(+), 11 deletions(-)
 rename Documentation/devicetree/bindings/media/i2c/{st,st-vgxy61.yaml => st,vgxy61.yaml} (95%)
 rename Documentation/userspace-api/media/drivers/{st-vgxy61.rst => vgxy61.rst} (100%)
 rename drivers/media/i2c/{st-vgxy61.c => vgxy61.c} (99%)

diff --git a/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml b/Documentation/devicetree/bindings/media/i2c/st,vgxy61.yaml
similarity index 95%
rename from Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
rename to Documentation/devicetree/bindings/media/i2c/st,vgxy61.yaml
index 8c28848b226a..4e4c2c7ad168 100644
--- a/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/st,vgxy61.yaml
@@ -2,7 +2,7 @@
 # Copyright (c) 2022 STMicroelectronics SA.
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/media/i2c/st,st-vgxy61.yaml#
+$id: http://devicetree.org/schemas/media/i2c/st,vgxy61.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: STMicroelectronics VGxy61 HDR Global Shutter Sensor Family
@@ -23,7 +23,7 @@ description: |-
 
 properties:
   compatible:
-    const: st,st-vgxy61
+    const: st,vgxy61
 
   reg:
     maxItems: 1
@@ -95,7 +95,7 @@ examples:
         #address-cells = <1>;
         #size-cells = <0>;
         vgxy61: csi2tx@10 {
-            compatible = "st,st-vgxy61";
+            compatible = "st,vgxy61";
             reg = <0x10>;
             clocks = <&clk_ext_camera>;
             VCORE-supply = <&v1v2>;
diff --git a/Documentation/userspace-api/media/drivers/index.rst b/Documentation/userspace-api/media/drivers/index.rst
index 2252063593bf..d706cb47b112 100644
--- a/Documentation/userspace-api/media/drivers/index.rst
+++ b/Documentation/userspace-api/media/drivers/index.rst
@@ -35,6 +35,6 @@ For more details see the file COPYING in the source distribution of Linux.
 	max2175
 	npcm-video
 	omap3isp-uapi
-	st-vgxy61
 	thp7312
 	uvcvideo
+	vgxy61
diff --git a/Documentation/userspace-api/media/drivers/st-vgxy61.rst b/Documentation/userspace-api/media/drivers/vgxy61.rst
similarity index 100%
rename from Documentation/userspace-api/media/drivers/st-vgxy61.rst
rename to Documentation/userspace-api/media/drivers/vgxy61.rst
diff --git a/MAINTAINERS b/MAINTAINERS
index ef6be9d95143..3838f2ad77ca 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -20891,9 +20891,9 @@ M:	Sylvain Petinot <sylvain.petinot@foss.st.com>
 L:	linux-media@vger.kernel.org
 S:	Maintained
 T:	git git://linuxtv.org/media_tree.git
-F:	Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
-F:	Documentation/userspace-api/media/drivers/st-vgxy61.rst
-F:	drivers/media/i2c/st-vgxy61.c
+F:	Documentation/devicetree/bindings/media/i2c/st,vgxy61.yaml
+F:	Documentation/userspace-api/media/drivers/vgxy61.rst
+F:	drivers/media/i2c/vgxy61.c
 
 ST VL53L0X ToF RANGER(I2C) IIO DRIVER
 M:	Song Qiang <songqiang1304521@gmail.com>
@@ -23210,7 +23210,7 @@ F:	drivers/media/i2c/mt*
 F:	drivers/media/i2c/og*
 F:	drivers/media/i2c/ov*
 F:	drivers/media/i2c/s5*
-F:	drivers/media/i2c/st-vgxy61.c
+F:	drivers/media/i2c/vgxy61.c
 
 VF610 NAND DRIVER
 M:	Stefan Agner <stefan@agner.ch>
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index c6d3ee472d81..25619d5e29c4 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -659,7 +659,7 @@ config VIDEO_S5K6A3
 	  This is a V4L2 sensor driver for Samsung S5K6A3 raw
 	  camera sensor.
 
-config VIDEO_ST_VGXY61
+config VIDEO_VGXY61
 	tristate "ST VGXY61 sensor support"
 	select V4L2_CCI_I2C
 	depends on OF && GPIOLIB
diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
index dfbe6448b549..d322ba161da5 100644
--- a/drivers/media/i2c/Makefile
+++ b/drivers/media/i2c/Makefile
@@ -124,7 +124,6 @@ obj-$(CONFIG_VIDEO_SAA717X) += saa717x.o
 obj-$(CONFIG_VIDEO_SAA7185) += saa7185.o
 obj-$(CONFIG_VIDEO_SONY_BTF_MPX) += sony-btf-mpx.o
 obj-$(CONFIG_VIDEO_ST_MIPID02) += st-mipid02.o
-obj-$(CONFIG_VIDEO_ST_VGXY61) += st-vgxy61.o
 obj-$(CONFIG_VIDEO_TC358743) += tc358743.o
 obj-$(CONFIG_VIDEO_TC358746) += tc358746.o
 obj-$(CONFIG_VIDEO_TDA1997X) += tda1997x.o
@@ -148,6 +147,7 @@ obj-$(CONFIG_VIDEO_TW9910) += tw9910.o
 obj-$(CONFIG_VIDEO_UDA1342) += uda1342.o
 obj-$(CONFIG_VIDEO_UPD64031A) += upd64031a.o
 obj-$(CONFIG_VIDEO_UPD64083) += upd64083.o
+obj-$(CONFIG_VIDEO_VGXY61) += vgxy61.o
 obj-$(CONFIG_VIDEO_VP27SMPX) += vp27smpx.o
 obj-$(CONFIG_VIDEO_VPX3220) += vpx3220.o
 obj-$(CONFIG_VIDEO_WM8739) += wm8739.o
diff --git a/drivers/media/i2c/st-vgxy61.c b/drivers/media/i2c/vgxy61.c
similarity index 99%
rename from drivers/media/i2c/st-vgxy61.c
rename to drivers/media/i2c/vgxy61.c
index b9e7c57027b1..30378e962016 100644
--- a/drivers/media/i2c/st-vgxy61.c
+++ b/drivers/media/i2c/vgxy61.c
@@ -1878,7 +1878,7 @@ static const struct dev_pm_ops vgxy61_pm_ops = {
 
 static struct i2c_driver vgxy61_i2c_driver = {
 	.driver = {
-		.name  = "st-vgxy61",
+		.name  = "vgxy61",
 		.of_match_table = vgxy61_dt_ids,
 		.pm = &vgxy61_pm_ops,
 	},
-- 
2.25.1

Re: [PATCH 1/3] media: vgxy61: Fix driver name

[Krzysztof Kozlowski]

On 10/06/2024 17:08, Benjamin Mugnier wrote:
> From 'st-vgxy61' to 'vgxy61'.
> Align with other drivers to not use the vendor prefix.
> Also the vendor prefix is already mentioned in the device tree
> compatible string, being 'st,vgxy61', and does not need to be expressed twice.

What bindings have anything to do with driver name?

I think I made it clear last time.


> 
> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
> ---
>  .../media/i2c/{st,st-vgxy61.yaml => st,vgxy61.yaml}       | 6 +++---
>  Documentation/userspace-api/media/drivers/index.rst       | 2 +-
>  .../media/drivers/{st-vgxy61.rst => vgxy61.rst}           | 0
>  MAINTAINERS                                               | 8 ++++----
>  drivers/media/i2c/Kconfig                                 | 2 +-
>  drivers/media/i2c/Makefile                                | 2 +-
>  drivers/media/i2c/{st-vgxy61.c => vgxy61.c}               | 2 +-
>  7 files changed, 11 insertions(+), 11 deletions(-)
>  rename Documentation/devicetree/bindings/media/i2c/{st,st-vgxy61.yaml => st,vgxy61.yaml} (95%)
>  rename Documentation/userspace-api/media/drivers/{st-vgxy61.rst => vgxy61.rst} (100%)
>  rename drivers/media/i2c/{st-vgxy61.c => vgxy61.c} (99%)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml b/Documentation/devicetree/bindings/media/i2c/st,vgxy61.yaml
> similarity index 95%
> rename from Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
> rename to Documentation/devicetree/bindings/media/i2c/st,vgxy61.yaml
> index 8c28848b226a..4e4c2c7ad168 100644
> --- a/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/st,vgxy61.yaml
> @@ -2,7 +2,7 @@
>  # Copyright (c) 2022 STMicroelectronics SA.
>  %YAML 1.2
>  ---
> -$id: http://devicetree.org/schemas/media/i2c/st,st-vgxy61.yaml#
> +$id: http://devicetree.org/schemas/media/i2c/st,vgxy61.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
>  title: STMicroelectronics VGxy61 HDR Global Shutter Sensor Family
> @@ -23,7 +23,7 @@ description: |-
>  
>  properties:
>    compatible:
> -    const: st,st-vgxy61
> +    const: st,vgxy61

Why? No. NAK.


Best regards,
Krzysztof

[PATCH 2/3] media: vgxy61: Add legacy compatible string

[Benjamin Mugnier]

As the driver has been renamed from 'st-vgxy61' to 'vgxy61', its
compatible string has been updated to reflect this change. Therefore old
device trees will not work anymore.
Add the old driver name as another compatible name to handle the
retro compatibility.

Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
---
 drivers/media/i2c/vgxy61.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/media/i2c/vgxy61.c b/drivers/media/i2c/vgxy61.c
index 30378e962016..ca3b43608dad 100644
--- a/drivers/media/i2c/vgxy61.c
+++ b/drivers/media/i2c/vgxy61.c
@@ -1867,6 +1867,11 @@ static void vgxy61_remove(struct i2c_client *client)
 }
 
 static const struct of_device_id vgxy61_dt_ids[] = {
+	{ .compatible = "st,vgxy61" },
+	/*
+	 * Previously the driver was named 'st-vgxy61' instead of simply
+	 * 'vgxy61', keep it for retrocompatibility purposes.
+	 */
 	{ .compatible = "st,st-vgxy61" },
 	{ /* sentinel */ }
 };
-- 
2.25.1

Re: [PATCH 2/3] media: vgxy61: Add legacy compatible string

[Krzysztof Kozlowski]

On 10/06/2024 17:08, Benjamin Mugnier wrote:
> As the driver has been renamed from 'st-vgxy61' to 'vgxy61', its
> compatible string has been updated to reflect this change. Therefore old
> device trees will not work anymore.
> Add the old driver name as another compatible name to handle the
> retro compatibility.
> 
> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
> ---
>  drivers/media/i2c/vgxy61.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/media/i2c/vgxy61.c b/drivers/media/i2c/vgxy61.c
> index 30378e962016..ca3b43608dad 100644
> --- a/drivers/media/i2c/vgxy61.c
> +++ b/drivers/media/i2c/vgxy61.c
> @@ -1867,6 +1867,11 @@ static void vgxy61_remove(struct i2c_client *client)
>  }
>  
>  static const struct of_device_id vgxy61_dt_ids[] = {
> +	{ .compatible = "st,vgxy61" },
> +	/*
> +	 * Previously the driver was named 'st-vgxy61' instead of simply
> +	 * 'vgxy61', keep it for retrocompatibility purposes.

NAK.

Best regards,
Krzysztof

Re: [PATCH 2/3] media: vgxy61: Add legacy compatible string

[Sakari Ailus]

Hi Krzysztof,

On Tue, Jun 11, 2024 at 08:47:25AM +0200, Krzysztof Kozlowski wrote:
> On 10/06/2024 17:08, Benjamin Mugnier wrote:
> > As the driver has been renamed from 'st-vgxy61' to 'vgxy61', its
> > compatible string has been updated to reflect this change. Therefore old
> > device trees will not work anymore.
> > Add the old driver name as another compatible name to handle the
> > retro compatibility.
> > 
> > Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
> > ---
> >  drivers/media/i2c/vgxy61.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/drivers/media/i2c/vgxy61.c b/drivers/media/i2c/vgxy61.c
> > index 30378e962016..ca3b43608dad 100644
> > --- a/drivers/media/i2c/vgxy61.c
> > +++ b/drivers/media/i2c/vgxy61.c
> > @@ -1867,6 +1867,11 @@ static void vgxy61_remove(struct i2c_client *client)
> >  }
> >  
> >  static const struct of_device_id vgxy61_dt_ids[] = {
> > +	{ .compatible = "st,vgxy61" },
> > +	/*
> > +	 * Previously the driver was named 'st-vgxy61' instead of simply
> > +	 * 'vgxy61', keep it for retrocompatibility purposes.
> 
> NAK.

Is that because the comment says "driver" rather than "device"?

Please try to express clearer what you'd expect from the patch author.

-- 
Kind regards,

Sakari Ailus

Re: [PATCH 2/3] media: vgxy61: Add legacy compatible string

[Krzysztof Kozlowski]

On 11/06/2024 10:19, Sakari Ailus wrote:
> Hi Krzysztof,
> 
> On Tue, Jun 11, 2024 at 08:47:25AM +0200, Krzysztof Kozlowski wrote:
>> On 10/06/2024 17:08, Benjamin Mugnier wrote:
>>> As the driver has been renamed from 'st-vgxy61' to 'vgxy61', its
>>> compatible string has been updated to reflect this change. Therefore old
>>> device trees will not work anymore.
>>> Add the old driver name as another compatible name to handle the
>>> retro compatibility.
>>>
>>> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
>>> ---
>>>  drivers/media/i2c/vgxy61.c | 5 +++++
>>>  1 file changed, 5 insertions(+)
>>>
>>> diff --git a/drivers/media/i2c/vgxy61.c b/drivers/media/i2c/vgxy61.c
>>> index 30378e962016..ca3b43608dad 100644
>>> --- a/drivers/media/i2c/vgxy61.c
>>> +++ b/drivers/media/i2c/vgxy61.c
>>> @@ -1867,6 +1867,11 @@ static void vgxy61_remove(struct i2c_client *client)
>>>  }
>>>  
>>>  static const struct of_device_id vgxy61_dt_ids[] = {
>>> +	{ .compatible = "st,vgxy61" },
>>> +	/*
>>> +	 * Previously the driver was named 'st-vgxy61' instead of simply
>>> +	 * 'vgxy61', keep it for retrocompatibility purposes.
>>
>> NAK.
> 
> Is that because the comment says "driver" rather than "device"?
> 
> Please try to express clearer what you'd expect from the patch author.

There is almost never a need to rename compatible or add new compatible
matching existing one. There are exceptions, like development or work in
progress with no users at all (and really no users!).

The commit did not provide any rationale for binding change.

Additionally, it does not make any sense. There is no point in doing it
at all. No benefit.

Best regards,
Krzysztof

Re: [PATCH 2/3] media: vgxy61: Add legacy compatible string

[Benjamin Mugnier]

Hi Sakari and Krzysztof,

On 6/11/24 10:38, Krzysztof Kozlowski wrote:
> On 11/06/2024 10:19, Sakari Ailus wrote:
>> Hi Krzysztof,
>>
>> On Tue, Jun 11, 2024 at 08:47:25AM +0200, Krzysztof Kozlowski wrote:
>>> On 10/06/2024 17:08, Benjamin Mugnier wrote:
>>>> As the driver has been renamed from 'st-vgxy61' to 'vgxy61', its
>>>> compatible string has been updated to reflect this change. Therefore old
>>>> device trees will not work anymore.
>>>> Add the old driver name as another compatible name to handle the
>>>> retro compatibility.
>>>>
>>>> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
>>>> ---
>>>>  drivers/media/i2c/vgxy61.c | 5 +++++
>>>>  1 file changed, 5 insertions(+)
>>>>
>>>> diff --git a/drivers/media/i2c/vgxy61.c b/drivers/media/i2c/vgxy61.c
>>>> index 30378e962016..ca3b43608dad 100644
>>>> --- a/drivers/media/i2c/vgxy61.c
>>>> +++ b/drivers/media/i2c/vgxy61.c
>>>> @@ -1867,6 +1867,11 @@ static void vgxy61_remove(struct i2c_client *client)
>>>>  }
>>>>  
>>>>  static const struct of_device_id vgxy61_dt_ids[] = {
>>>> +	{ .compatible = "st,vgxy61" },
>>>> +	/*
>>>> +	 * Previously the driver was named 'st-vgxy61' instead of simply
>>>> +	 * 'vgxy61', keep it for retrocompatibility purposes.
>>>
>>> NAK.
>>
>> Is that because the comment says "driver" rather than "device"?
>>

You're correct, I'll replace all occurrences for the series.

>> Please try to express clearer what you'd expect from the patch author.
> 
> There is almost never a need to rename compatible or add new compatible
> matching existing one. There are exceptions, like development or work in
> progress with no users at all (and really no users!).
> 
> The commit did not provide any rationale for binding change.
> 
> Additionally, it does not make any sense. There is no point in doing it
> at all. No benefit.
> 

Thanks, here is a draft of a new commit message for v2 highlighting the
rationale :

The previous binding 'st,st-vgxy61' did not reflect the actual device
name : vgxy61 (and not st-vgxy61 as ST is the vendor prefix), and was
changed to 'st,vgxy61'.
Still some device trees uses the old binding. This commit adds back the
'st,vgxy61' binding in addition to the new one to ensure retro
compatibility.

Will this be ok for you ? Tell me your thoughts.

> Best regards,
> Krzysztof
> 

-- 
Regards,

Benjamin

Re: [PATCH 2/3] media: vgxy61: Add legacy compatible string

[Krzysztof Kozlowski]

On 11/06/2024 13:57, Benjamin Mugnier wrote:
> Hi Sakari and Krzysztof,
> 
> On 6/11/24 10:38, Krzysztof Kozlowski wrote:
>> On 11/06/2024 10:19, Sakari Ailus wrote:
>>> Hi Krzysztof,
>>>
>>> On Tue, Jun 11, 2024 at 08:47:25AM +0200, Krzysztof Kozlowski wrote:
>>>> On 10/06/2024 17:08, Benjamin Mugnier wrote:
>>>>> As the driver has been renamed from 'st-vgxy61' to 'vgxy61', its
>>>>> compatible string has been updated to reflect this change. Therefore old
>>>>> device trees will not work anymore.
>>>>> Add the old driver name as another compatible name to handle the
>>>>> retro compatibility.
>>>>>
>>>>> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
>>>>> ---
>>>>>  drivers/media/i2c/vgxy61.c | 5 +++++
>>>>>  1 file changed, 5 insertions(+)
>>>>>
>>>>> diff --git a/drivers/media/i2c/vgxy61.c b/drivers/media/i2c/vgxy61.c
>>>>> index 30378e962016..ca3b43608dad 100644
>>>>> --- a/drivers/media/i2c/vgxy61.c
>>>>> +++ b/drivers/media/i2c/vgxy61.c
>>>>> @@ -1867,6 +1867,11 @@ static void vgxy61_remove(struct i2c_client *client)
>>>>>  }
>>>>>  
>>>>>  static const struct of_device_id vgxy61_dt_ids[] = {
>>>>> +	{ .compatible = "st,vgxy61" },
>>>>> +	/*
>>>>> +	 * Previously the driver was named 'st-vgxy61' instead of simply
>>>>> +	 * 'vgxy61', keep it for retrocompatibility purposes.
>>>>
>>>> NAK.
>>>
>>> Is that because the comment says "driver" rather than "device"?
>>>
> 
> You're correct, I'll replace all occurrences for the series.
> 
>>> Please try to express clearer what you'd expect from the patch author.
>>
>> There is almost never a need to rename compatible or add new compatible
>> matching existing one. There are exceptions, like development or work in
>> progress with no users at all (and really no users!).
>>
>> The commit did not provide any rationale for binding change.
>>
>> Additionally, it does not make any sense. There is no point in doing it
>> at all. No benefit.
>>
> 
> Thanks, here is a draft of a new commit message for v2 highlighting the
> rationale :
> 
> The previous binding 'st,st-vgxy61' did not reflect the actual device
> name : vgxy61 (and not st-vgxy61 as ST is the vendor prefix), and was
> changed to 'st,vgxy61'.

That's not really a reason to change binding.

> Still some device trees uses the old binding. This commit adds back the
> 'st,vgxy61' binding in addition to the new one to ensure retro
> compatibility.

"Adds back"? This means it was there but was removed, so please document
it with commit references.

> 
> Will this be ok for you ? Tell me your thoughts.

It seems you are making some changes assuming there is some error to be
fixed, but there is none. Compatible is just some unique string, so the
original compatible, although unfortunate, is okay and must not be
changed. I already explained that adding new compatibles for such cases
is only for exceptions. Is this exception? No. You provided no rationale
to make it an exception.

Best regards,
Krzysztof

Re: [PATCH 2/3] media: vgxy61: Add legacy compatible string

[Benjamin Mugnier]

Hi Krzysztof,

On 6/11/24 14:17, Krzysztof Kozlowski wrote:
> On 11/06/2024 13:57, Benjamin Mugnier wrote:
>> Hi Sakari and Krzysztof,
>>
>> On 6/11/24 10:38, Krzysztof Kozlowski wrote:
>>> On 11/06/2024 10:19, Sakari Ailus wrote:
>>>> Hi Krzysztof,
>>>>
>>>> On Tue, Jun 11, 2024 at 08:47:25AM +0200, Krzysztof Kozlowski wrote:
>>>>> On 10/06/2024 17:08, Benjamin Mugnier wrote:
>>>>>> As the driver has been renamed from 'st-vgxy61' to 'vgxy61', its
>>>>>> compatible string has been updated to reflect this change. Therefore old
>>>>>> device trees will not work anymore.
>>>>>> Add the old driver name as another compatible name to handle the
>>>>>> retro compatibility.
>>>>>>
>>>>>> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
>>>>>> ---
>>>>>>  drivers/media/i2c/vgxy61.c | 5 +++++
>>>>>>  1 file changed, 5 insertions(+)
>>>>>>
>>>>>> diff --git a/drivers/media/i2c/vgxy61.c b/drivers/media/i2c/vgxy61.c
>>>>>> index 30378e962016..ca3b43608dad 100644
>>>>>> --- a/drivers/media/i2c/vgxy61.c
>>>>>> +++ b/drivers/media/i2c/vgxy61.c
>>>>>> @@ -1867,6 +1867,11 @@ static void vgxy61_remove(struct i2c_client *client)
>>>>>>  }
>>>>>>  
>>>>>>  static const struct of_device_id vgxy61_dt_ids[] = {
>>>>>> +	{ .compatible = "st,vgxy61" },
>>>>>> +	/*
>>>>>> +	 * Previously the driver was named 'st-vgxy61' instead of simply
>>>>>> +	 * 'vgxy61', keep it for retrocompatibility purposes.
>>>>>
>>>>> NAK.
>>>>
>>>> Is that because the comment says "driver" rather than "device"?
>>>>
>>
>> You're correct, I'll replace all occurrences for the series.
>>
>>>> Please try to express clearer what you'd expect from the patch author.
>>>
>>> There is almost never a need to rename compatible or add new compatible
>>> matching existing one. There are exceptions, like development or work in
>>> progress with no users at all (and really no users!).
>>>
>>> The commit did not provide any rationale for binding change.
>>>
>>> Additionally, it does not make any sense. There is no point in doing it
>>> at all. No benefit.
>>>
>>
>> Thanks, here is a draft of a new commit message for v2 highlighting the
>> rationale :
>>
>> The previous binding 'st,st-vgxy61' did not reflect the actual device
>> name : vgxy61 (and not st-vgxy61 as ST is the vendor prefix), and was
>> changed to 'st,vgxy61'.
> 
> That's not really a reason to change binding.
> 
>> Still some device trees uses the old binding. This commit adds back the
>> 'st,vgxy61' binding in addition to the new one to ensure retro
>> compatibility.
> 
> "Adds back"? This means it was there but was removed, so please document
> it with commit references.
> 

My bad, patch 1/3 on this series changes the binding, only to be added
back by this one (2/3).
I'll do it the other way around : patch 1/3 will *not* change the
binding, and patch 2/3 will add the new binding instead. Way cleaner.

>>
>> Will this be ok for you ? Tell me your thoughts.
> 
> It seems you are making some changes assuming there is some error to be
> fixed, but there is none. Compatible is just some unique string, so the
> original compatible, although unfortunate, is okay and must not be
> changed. I already explained that adding new compatibles for such cases
> is only for exceptions. Is this exception? No. You provided no rationale
> to make it an exception.

Thank you. I think I failed to provide some details :

The change is motivated by a will of consistency in naming.
As you correctly mentioned in the vd56g3 series [1], bindings should be
'vendor,device'. This will be changed for the vd56g3 series v3 by
Sylvain, but the vgxy61 binding is already badly named.
We will then have these 2 bindings in the wild : st,vd56g3 and
st,st-vgxy61, for very similar sensors. Hence the will to add a
st,vgxy61 binding for consistency.
This also prepares the ground for new camera sensor drivers we plan to
submit later on, and that will respect the st,device binding naming scheme.

Is it the correct way to go ?

I will add something along these lines to the commit message.


[1] https://lkml.org/lkml/2024/5/27/670

> 
> Best regards,
> Krzysztof
> 

-- 
Regards,

Benjamin

Re: [PATCH 2/3] media: vgxy61: Add legacy compatible string

[Krzysztof Kozlowski]

On 11/06/2024 15:07, Benjamin Mugnier wrote:
> 
>>>
>>> Will this be ok for you ? Tell me your thoughts.
>>
>> It seems you are making some changes assuming there is some error to be
>> fixed, but there is none. Compatible is just some unique string, so the
>> original compatible, although unfortunate, is okay and must not be
>> changed. I already explained that adding new compatibles for such cases
>> is only for exceptions. Is this exception? No. You provided no rationale
>> to make it an exception.
> 
> Thank you. I think I failed to provide some details :
> 
> The change is motivated by a will of consistency in naming.

Consistency is a preference and not really a reason here. Could be named
"st,yellow-elephant" and it would be kind of fine...

> As you correctly mentioned in the vd56g3 series [1], bindings should be
> 'vendor,device'. This will be changed for the vd56g3 series v3 by

Yeah, but that ship has sailed. Where is the answer about all the users?
You pick pieces of my arguments and ignore some parts of it.

None of this is suitable for exception. Style or preference is not
argument for exception.

> Sylvain, but the vgxy61 binding is already badly named.
> We will then have these 2 bindings in the wild : st,vd56g3 and
> st,st-vgxy61, for very similar sensors. Hence the will to add a
> st,vgxy61 binding for consistency.

Nope.

> This also prepares the ground for new camera sensor drivers we plan to
> submit later on, and that will respect the st,device binding naming scheme.

Nope

> 
> Is it the correct way to go ?

Nope, sorry.

I already said this several times in this email thread - answers here
and in other emails. Now, again.

When I said about exceptions, I really meant exceptions, e.g. something
is broken or something never worked and has to be fixed. Style or
preference is not this case. No point to keep arguing how style is
important for you.


Best regards,
Krzysztof

[PATCH 3/3] media: vgxy61: Add MODULE_ALIAS()

[Benjamin Mugnier]

Preserve user space retro compatibility after the device rename.

Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
---
 drivers/media/i2c/vgxy61.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/i2c/vgxy61.c b/drivers/media/i2c/vgxy61.c
index ca3b43608dad..c85f356946ca 100644
--- a/drivers/media/i2c/vgxy61.c
+++ b/drivers/media/i2c/vgxy61.c
@@ -1898,3 +1898,4 @@ MODULE_AUTHOR("Mickael Guene <mickael.guene@st.com>");
 MODULE_AUTHOR("Sylvain Petinot <sylvain.petinot@foss.st.com>");
 MODULE_DESCRIPTION("VGXY61 camera subdev driver");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:st-vgxy61");
-- 
2.25.1

Re: [PATCH 3/3] media: vgxy61: Add MODULE_ALIAS()

[Krzysztof Kozlowski]

On 10/06/2024 17:08, Benjamin Mugnier wrote:
> Preserve user space retro compatibility after the device rename.
> 
> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
> ---
>  drivers/media/i2c/vgxy61.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/i2c/vgxy61.c b/drivers/media/i2c/vgxy61.c
> index ca3b43608dad..c85f356946ca 100644
> --- a/drivers/media/i2c/vgxy61.c
> +++ b/drivers/media/i2c/vgxy61.c
> @@ -1898,3 +1898,4 @@ MODULE_AUTHOR("Mickael Guene <mickael.guene@st.com>");
>  MODULE_AUTHOR("Sylvain Petinot <sylvain.petinot@foss.st.com>");
>  MODULE_DESCRIPTION("VGXY61 camera subdev driver");
>  MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:st-vgxy61");

Why? Isn't this autoloated by OF alias? There was never here platform
alias so no functionality is lost.

NAK

Best regards,
Krzysztof

Re: [PATCH 3/3] media: vgxy61: Add MODULE_ALIAS()

[Sakari Ailus]

Hi Benjamin,

On Mon, Jun 10, 2024 at 05:08:15PM +0200, Benjamin Mugnier wrote:
> Preserve user space retro compatibility after the device rename.
> 
> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
> ---
>  drivers/media/i2c/vgxy61.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/i2c/vgxy61.c b/drivers/media/i2c/vgxy61.c
> index ca3b43608dad..c85f356946ca 100644
> --- a/drivers/media/i2c/vgxy61.c
> +++ b/drivers/media/i2c/vgxy61.c
> @@ -1898,3 +1898,4 @@ MODULE_AUTHOR("Mickael Guene <mickael.guene@st.com>");
>  MODULE_AUTHOR("Sylvain Petinot <sylvain.petinot@foss.st.com>");
>  MODULE_DESCRIPTION("VGXY61 camera subdev driver");
>  MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:st-vgxy61");

Perhaps just "st-vgxy61" so that the module still loads if someone loads it
explicitly? That's what you'd want, right, as the old compatible string
will remain?

-- 
Kind regards,

Sakari Ailus

Re: [PATCH 3/3] media: vgxy61: Add MODULE_ALIAS()

[Benjamin Mugnier]

Hi Sakari,

On 6/11/24 10:21, Sakari Ailus wrote:
> Hi Benjamin,
> 
> On Mon, Jun 10, 2024 at 05:08:15PM +0200, Benjamin Mugnier wrote:
>> Preserve user space retro compatibility after the device rename.
>>
>> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
>> ---
>>  drivers/media/i2c/vgxy61.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/media/i2c/vgxy61.c b/drivers/media/i2c/vgxy61.c
>> index ca3b43608dad..c85f356946ca 100644
>> --- a/drivers/media/i2c/vgxy61.c
>> +++ b/drivers/media/i2c/vgxy61.c
>> @@ -1898,3 +1898,4 @@ MODULE_AUTHOR("Mickael Guene <mickael.guene@st.com>");
>>  MODULE_AUTHOR("Sylvain Petinot <sylvain.petinot@foss.st.com>");
>>  MODULE_DESCRIPTION("VGXY61 camera subdev driver");
>>  MODULE_LICENSE("GPL");
>> +MODULE_ALIAS("platform:st-vgxy61");
> 
> Perhaps just "st-vgxy61" so that the module still loads if someone loads it
> explicitly? That's what you'd want, right, as the old compatible string
> will remain?
> 

Yes it is for explicit loading. I'll remove the "platform" prefix.

But maybe I'm overthinking and I could just remove the MODULE_ALIAS()
completely from this series. What do you think ?

-- 
Regards,

Benjamin

Re: [PATCH 3/3] media: vgxy61: Add MODULE_ALIAS()

[Sakari Ailus]

Hi Benjamin,

On Tue, Jun 11, 2024 at 01:57:24PM +0200, Benjamin Mugnier wrote:
> Hi Sakari,
> 
> On 6/11/24 10:21, Sakari Ailus wrote:
> > Hi Benjamin,
> > 
> > On Mon, Jun 10, 2024 at 05:08:15PM +0200, Benjamin Mugnier wrote:
> >> Preserve user space retro compatibility after the device rename.
> >>
> >> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
> >> ---
> >>  drivers/media/i2c/vgxy61.c | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/media/i2c/vgxy61.c b/drivers/media/i2c/vgxy61.c
> >> index ca3b43608dad..c85f356946ca 100644
> >> --- a/drivers/media/i2c/vgxy61.c
> >> +++ b/drivers/media/i2c/vgxy61.c
> >> @@ -1898,3 +1898,4 @@ MODULE_AUTHOR("Mickael Guene <mickael.guene@st.com>");
> >>  MODULE_AUTHOR("Sylvain Petinot <sylvain.petinot@foss.st.com>");
> >>  MODULE_DESCRIPTION("VGXY61 camera subdev driver");
> >>  MODULE_LICENSE("GPL");
> >> +MODULE_ALIAS("platform:st-vgxy61");
> > 
> > Perhaps just "st-vgxy61" so that the module still loads if someone loads it
> > explicitly? That's what you'd want, right, as the old compatible string
> > will remain?
> > 
> 
> Yes it is for explicit loading. I'll remove the "platform" prefix.
> 
> But maybe I'm overthinking and I could just remove the MODULE_ALIAS()
> completely from this series. What do you think ?

Most of the time the modules are loaded based on devices found, so this
would likely not change things much.

Up to you.

-- 
Kind regards,

Sakari Ailus

Re: [PATCH 3/3] media: vgxy61: Add MODULE_ALIAS()

[Benjamin Mugnier]

On 6/11/24 15:11, Sakari Ailus wrote:
> Hi Benjamin,
> 
> On Tue, Jun 11, 2024 at 01:57:24PM +0200, Benjamin Mugnier wrote:
>> Hi Sakari,
>>
>> On 6/11/24 10:21, Sakari Ailus wrote:
>>> Hi Benjamin,
>>>
>>> On Mon, Jun 10, 2024 at 05:08:15PM +0200, Benjamin Mugnier wrote:
>>>> Preserve user space retro compatibility after the device rename.
>>>>
>>>> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
>>>> ---
>>>>  drivers/media/i2c/vgxy61.c | 1 +
>>>>  1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/media/i2c/vgxy61.c b/drivers/media/i2c/vgxy61.c
>>>> index ca3b43608dad..c85f356946ca 100644
>>>> --- a/drivers/media/i2c/vgxy61.c
>>>> +++ b/drivers/media/i2c/vgxy61.c
>>>> @@ -1898,3 +1898,4 @@ MODULE_AUTHOR("Mickael Guene <mickael.guene@st.com>");
>>>>  MODULE_AUTHOR("Sylvain Petinot <sylvain.petinot@foss.st.com>");
>>>>  MODULE_DESCRIPTION("VGXY61 camera subdev driver");
>>>>  MODULE_LICENSE("GPL");
>>>> +MODULE_ALIAS("platform:st-vgxy61");
>>>
>>> Perhaps just "st-vgxy61" so that the module still loads if someone loads it
>>> explicitly? That's what you'd want, right, as the old compatible string
>>> will remain?
>>>
>>
>> Yes it is for explicit loading. I'll remove the "platform" prefix.
>>
>> But maybe I'm overthinking and I could just remove the MODULE_ALIAS()
>> completely from this series. What do you think ?
> 
> Most of the time the modules are loaded based on devices found, so this
> would likely not change things much.
> 
> Up to you.
> 

Then I'd rather remove it entirely. The less legacy code the better.
Thank you.

-- 
Regards,

Benjamin