From: Krzysztof Kozlowski <krzk@kernel.org>
To: Matthew Gerlach <matthew.gerlach@altera.com>,
dinguyen@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com,
maxime.chevallier@bootlin.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: net: altr,socfpga-stmmac.yaml: add minItems to iommus
Date: Wed, 9 Jul 2025 08:54:24 +0200 [thread overview]
Message-ID: <b752c340-bbb5-479f-bc2c-a9e8541509c3@kernel.org> (raw)
In-Reply-To: <20250707154409.15527-1-matthew.gerlach@altera.com>
On 07/07/2025 17:44, Matthew Gerlach wrote:
> Add missing 'minItems: 1' to iommus property of the Altera SOCFPGA SoC
> implementation of the Synopsys DWMAC.
Why? Explain why you are doing thing, not what you are doing. What is
obvious which makes entire two-line commit msg redundant and useless.
Original binding had no iommus and referenced commit does not explain
why they appeared during conversion in the first place.
>
> Fixes: 6d359cf464f4 ("dt-bindings: net: Convert socfpga-dwmac bindings to yaml")
> Signed-off-by: Matthew Gerlach <matthew.gerlach@altera.com>
> ---
> Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> index c5d8dfe5b801..ec34daff2aa0 100644
> --- a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> +++ b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> @@ -59,6 +59,7 @@ properties:
> - const: ptp_ref
>
> iommus:
> + minItems: 1
> maxItems: 2
Why this has to be flexible on given SoC? This is weird. Same hardware
differs somehow?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-09 6:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-07 15:44 [PATCH] dt-bindings: net: altr,socfpga-stmmac.yaml: add minItems to iommus Matthew Gerlach
2025-07-08 2:34 ` Yanteng Si
2025-07-08 20:02 ` Rob Herring (Arm)
2025-07-09 2:10 ` patchwork-bot+netdevbpf
2025-07-09 6:54 ` Krzysztof Kozlowski [this message]
2025-07-09 22:23 ` Matthew Gerlach
2025-07-12 12:35 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b752c340-bbb5-479f-bc2c-a9e8541509c3@kernel.org \
--to=krzk@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=matthew.gerlach@altera.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).