From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8302A3F4DE7 for ; Wed, 8 Jul 2026 07:45:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783496713; cv=none; b=lZ242os0+gYAio/dDWXgkFW39XNcQaxbTCKn60HRH+5aG89EwXL8gUVzjY9+FrMu789SPIwqHvKV9TxGZtewfvvtvbgE9NH/EWrNWIXu9GcibW7J2SArifIqqFo6RixjA7EAPfI5cyTV9D6ZY3gVDf5JyUZGqmICksAU5gmCg4c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783496713; c=relaxed/simple; bh=Gh0a0KyvZHqcAMLXC9dM3ySw1qVhU7bsFqIhGro8tEg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LE25ajq3ICbvr9k34ehzm4V+ToL6lODc6A4KErk6yBcvHRoVKld7JathZYVUdtvJKmg5hO553Cm5C4BtnxphsvSEFxdiG5mxZ3DtlO23VZfARnMUYFmECyXv+lKIuUOp13RQpXejrQr2lvdP7eJJerPXcdU0FmF2KpktPtiBmGQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wO3epuCC; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wO3epuCC" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-5aeb7ccb9f0so49739e87.0 for ; Wed, 08 Jul 2026 00:45:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1783496705; x=1784101505; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=mkXy4kbxINUY2w5Y8HT7KOs4yBngnLIiuXbssaXGyXo=; b=wO3epuCC/dKgBw7E3cBkDN+xcqu05WVKPzlcxjHxKYDiJoKcsjJMzbrq+6wqIT+dqI 9RBdVZtx9D34XXRazL1gA+R6An40AEGGK1PRWQ/mDjFDHTnTwzmWXAq8WGKtlHLQLHZh fEFN5OB5X+LtX9vSVZKMbLMeRjf+Y+Zb/rX89kv/SNE7SzKW4pkLa7R2Tt0XYPBFF1fX WhQkiOkS6ZfuAJdbKa9OzNcqp45hSNoRtOiQfB67cgiuzh3gUCUjVpukYNfofH7dfjTD SLg6YX6PAtDPnQ3maUvsDamek5JK0e1Th5uGP5SVJd4vImM2Xieze1g/fj7ag2RJMovJ CJrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783496705; x=1784101505; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=mkXy4kbxINUY2w5Y8HT7KOs4yBngnLIiuXbssaXGyXo=; b=gEqKig/wMh1A5UkgzR4q2KtIF0xA7hMXL9IiR+jSi8qQ/GkKMRxAiz51kwQnPhlqaj k9YmjCGW58Lh6b9sz2v43348Wg3xTGq3PoG7Q0Eawm73QhSL4j8xU6CCFlN+8VidnQr1 ujIWoQMadqWs1Tr4i4OuNjrXPB80yilZyvHbeHQd8yzeAqcCeB9ckD9qR+BOTvccN0bk thw2mCvKVIjgW6tTmHRm0v3o2NOhLN7Sj35u2Bk1oyAnfjX71PkgSoj1lD4I62Gqx7Mt AFPaR/1Rl1Oh4ixGhsSC4aV+xSQCQVuwEQ+6oA9oUtzxo9SPW+oITM7sAfOz5bT2ALpw Crgw== X-Forwarded-Encrypted: i=1; AHgh+RrE6JyJZl80FmPoA4dU91bIuMtW7SWDlrUc3pwMNR2BZQhQ1RCQXynbNKtiSQs9EazfXMP7QnXjF0Cq@vger.kernel.org X-Gm-Message-State: AOJu0YwGgW8qZRWcnGXE22m4y3sSRp9yZWVYfxaEd30aob/ozH3E5fvT Jaf9dV5di1S2z2ZOyiycXmTiRi9kQQsU6JTjUhdCzlhCx5p1t4J4MW7UFlrpZ1O4qhc= X-Gm-Gg: AfdE7cn+MLPWZ6eXyAcmL2hK/s0gTaSrcPuDaI4KMaLjpH1oxgTDJWyCQRPXNrg44Va 9fXN8hUbPOxb0vuf6sEfiKSRw46KyWAbvMyzbawS8dwt9HVuDuT9fYAFpQmRZENVKDITazIhUYe aZ3ZOn48q0jsWsjZQPgHdqr2abdyTgyINx2waYxCLG/7yugxYabuxVVvjQZmROh69y4iNhPX+Ur T/n9LocfqQHjW1w9FG9/UwmlDU46Ue7nVWgHxk1AmJuLL9zODGbhYRIFMim9qf+EWGL5j7N50VO hQS2m0/bhGIIfm6B1XbMdJFQCX/wem1HLVAcwiCzNz72COa4MtnrM+Vh7JQYqKJfJX3M0sHpEka knL4kXZsKOHNLHJ6xnpqrN4Yj7GklMbhyRvSb9fY8xMHdQ1VH9iV/plp+ELjc+UaNP+oepDQ71q 8MbcH0K16X71ZIHv6GgddMrBLliQvYpRXPx7AihgvOpbRepkQA2IxvqOxkQpm3njEZPX/5QZK4D 0quJA== X-Received: by 2002:a05:6512:3e05:b0:5ae:b0ea:d32e with SMTP id 2adb3069b0e04-5b0114471b9mr260939e87.2.1783496704298; Wed, 08 Jul 2026 00:45:04 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aed13701a7sm4284357e87.12.2026.07.08.00.45.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jul 2026 00:45:03 -0700 (PDT) Message-ID: Date: Wed, 8 Jul 2026 10:44:53 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 1/2] dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY schema To: Bryan O'Donoghue , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong Cc: Bryan O'Donoghue , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260708-x1e-csi2-phy-v9-0-0210b90c04cf@linaro.org> <20260708-x1e-csi2-phy-v9-1-0210b90c04cf@linaro.org> From: Vladimir Zapolskiy In-Reply-To: <20260708-x1e-csi2-phy-v9-1-0210b90c04cf@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/8/26 02:39, Bryan O'Donoghue wrote: > Add a base schema initially compatible with x1e80100 to describe MIPI CSI2 > PHY devices. > > The hardware can support both CPHY, DPHY and a special split-mode DPHY. > > The schema here defines two ports with three endpoints: > > port@0: Sensor input. > endpoint@0: primary sensor > endpoint@1: optional second sensor, implies DPHY split-mode > > port@1: Controller output. > > The CSIPHY devices have their own pinouts on the SoC as well as their own > individual voltage rails. > > The need to model voltage rails on a per-PHY basis leads us to define > CSIPHY devices as individual nodes. > > Two nice outcomes in terms of schema and DT arise from this change. > > 1. The ability to define on a per-PHY basis voltage rails. > 2. The ability to require those voltage. > > We have had a complete bodge upstream for this where a single set of > voltage rail for all CSIPHYs has been buried inside of CAMSS. > > Much like the I2C bus which is dedicated to Camera sensors - the CCI bus in > CAMSS parlance, the CSIPHY devices should be individually modelled. > > Signed-off-by: Bryan O'Donoghue > --- > .../bindings/phy/qcom,x1e80100-csi2-phy.yaml | 202 +++++++++++++++++++++ > 1 file changed, 202 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml > new file mode 100644 > index 0000000000000..a7fbf6804cd9e > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml > @@ -0,0 +1,202 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/qcom,x1e80100-csi2-phy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm SoC CSI2 PHY > + > +maintainers: > + - Bryan O'Donoghue > + > +description: > + Qualcomm MIPI CSI2 C-PHY/D-PHY combination PHY. Connects MIPI CSI2 sensors > + to Qualcomm's Camera CSI Decoder. The PHY supports both C-PHY and D-PHY > + modes. > + > +properties: > + compatible: > + const: qcom,x1e80100-csi2-phy > + > + reg: > + maxItems: 1 > + > + "#phy-cells": > + const: 1 > + description: > + The single cell specifies the PHY operating mode. Unfortunately my review comment given before was ignored before publishing this version, thus I will repeat. There is a clash between the proposed phy cells value and 'bus-type' property of the media endpoint, the proposed value of phy cells brings no information, and therefore the whole proposed '#phy-cells' prorperty shall be removed. There shall be no third link introduced between CAMSS and CAMSS CSIPHYs. > + > + clocks: > + maxItems: 3 > + > + clock-names: > + items: > + - const: core > + - const: timer > + - const: ahb > + > + interrupts: > + maxItems: 1 > + > + operating-points-v2: true > + > + power-domains: > + items: > + - description: Titan Top GDSC - Titan ISP Block, Global Distributed Switch Controller. > + - description: MMCX voltage rail > + - description: MXC or MXA voltage rail > + > + power-domain-names: > + items: > + - const: top > + - const: mmcx > + - const: mx None of the power domains finds its place in this device tree node, the child device belongs to CAMSS, which already enables these power domains. > + > + vdda-0p8-supply: > + description: Phandle to a 0.8V regulator supply to a PHY. The property name shall be vdda-0p9-supply, the description shall be changed accordingly > + > + vdda-1p2-supply: > + description: Phandle to 1.2V regulator supply to a PHY. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/$defs/port-base > + description: > + Sensor input. Always present. A single sensor is described by a > + single endpoint with one to four data lanes. DPHY split mode, > + where two independent sensors share the same PHY, is described > + by two endpoints; endpoint@0 with exactly two-data lanes and > + endpoint@1 with exactly one data-lane. > + unevaluatedProperties: false > + > + patternProperties: > + "^endpoint(@[0-9a-f]+)?$": This is too wide regexp mask for one or two endpoints only. > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + properties: > + data-lanes: > + minItems: 1 > + maxItems: 4 > + remote-endpoint: true > + required: > + - data-lanes > + - remote-endpoint > + > + allOf: > + - if: > + required: > + - endpoint@1 > + then: > + properties: > + endpoint@0: > + properties: > + data-lanes: > + minItems: 2 > + maxItems: 2 > + endpoint@1: > + properties: > + data-lanes: > + maxItems: 1 > + required: > + - endpoint@0 > + > + port@1: > + $ref: /schemas/graph.yaml#/$defs/port-base > + description: Output to the CAMSS CSID controller. > + unevaluatedProperties: false > + > + patternProperties: > + "^endpoint(@[0-9a-f]+)?$": > + $ref: /schemas/graph.yaml#/$defs/endpoint-base > + unevaluatedProperties: false > + properties: > + remote-endpoint: true > + required: > + - remote-endpoint > + > + required: > + - port@0 > + - port@1 > + > +required: > + - compatible > + - reg > + - "#phy-cells" > + - clocks > + - clock-names > + - interrupts > + - operating-points-v2 > + - power-domains > + - power-domain-names > + - vdda-0p8-supply > + - vdda-1p2-supply > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + #include > + > + phy@ace4000 { > + compatible = "qcom,x1e80100-csi2-phy"; > + reg = <0x0ace4000 0x2000>; > + #phy-cells = <1>; > + > + clocks = <&camcc CAM_CC_CSIPHY0_CLK>, > + <&camcc CAM_CC_CSI0PHYTIMER_CLK>, > + <&camcc CAM_CC_CORE_AHB_CLK>; > + clock-names = "core", > + "timer", > + "ahb"; > + > + interrupts = ; > + > + operating-points-v2 = <&csiphy_opp_table>; > + > + power-domains = <&camcc CAM_CC_TITAN_TOP_GDSC>, > + <&rpmhpd RPMHPD_MMCX>, > + <&rpmhpd RPMHPD_MX>; > + power-domain-names = "top", > + "mmcx", > + "mx"; > + > + vdda-0p8-supply = <&vreg_l2c_0p8>; > + vdda-1p2-supply = <&vreg_l1c_1p2>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + csiphy0_in: endpoint { > + data-lanes = <0 1 2 3>; The previously given review comment about numeration of lanes was not implemented. > + remote-endpoint = <&sensor_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + csiphy0_out: endpoint { > + remote-endpoint = <&csid_in>; > + }; > + }; > + }; > + }; > + > + csiphy_opp_table: opp-table { > + compatible = "operating-points-v2"; > + > + opp-300000000 { > + opp-hz = /bits/ 64 <300000000>; > + required-opps = <&rpmhpd_opp_low_svs_d1>, > + <&rpmhpd_opp_low_svs_d1>; > + }; > + }; > -- Best wishes, Vladimir