From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E6A0C433FE for ; Thu, 28 Apr 2022 07:16:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245091AbiD1HTq (ORCPT ); Thu, 28 Apr 2022 03:19:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245079AbiD1HTp (ORCPT ); Thu, 28 Apr 2022 03:19:45 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADC4D972C6 for ; Thu, 28 Apr 2022 00:16:30 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id z19so4429165edx.9 for ; Thu, 28 Apr 2022 00:16:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=qK/yNrchERZZb5WKsXnjQKVBWPRpxhxKirZegeYDkkY=; b=vJtMFaDNzaFtW99IRYyFTdk1Q8rYW6IgWzug6j118ma2yzmHBEoZiIvjA+nqqYpWTQ Jn8F9zn8piDuH+HVvvDNy9n1snQ3Zs+xiBydHljNiaIbnqk8kbFOE0jRdRmK/FE35t8E FwMLiIdpJsgd6pblclSuZNN8qA/zm0bLgh3FI8opcF/fbId2RbGSF/AZhU+Y01/1Kqkj 8V7lXoleyRtSyGVds/TB01VyhRAALqiMR4zPJ06+KXwLXXWgClKJKlvHm/ahNu2qXB5t B4+IvMdt7au54atFCYPkxViu6/L/e/tVm+btfCw+jvW12VGe5M7Cz3wa/8D2RaJ5SqI9 EYnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=qK/yNrchERZZb5WKsXnjQKVBWPRpxhxKirZegeYDkkY=; b=fLy074Ocbc9U7wR3neNEY9CX0fEI3u2SDYMYkXkt4dedbIB3D2j2yA1D7qqL7bGbcW 8EG6EXeveFLRZx9jaPirmEa/V02XiWjeAJ11AuWCMs4CQe2/QdCzLhYFLqW/yHyn/REs i0XiBLUB3RRPEnnMI9u5yc5aIDOziXA+qFlK6Rm3106grAjd5xfroIrxSm647RwbItEU j7Ti6JVZmsI1fPd4zZ1opxIB18/v7DPiLMcPWuqppihU6pTfq18pqNduk0qzCelA8P1w WCCWkPgTJYY2W9rQz54lF90JBqB5Iz24Pw48Y9XoANUwwG/H014JgtUOn5PT3vEQInN4 bEMw== X-Gm-Message-State: AOAM533dx4g6ro6xiZK0w8eDRKRamLMEc7HTRZ1M/PopSfjNd2dG6Dg3 i4by9oyZ+MF64wB2JP/BOekxEg== X-Google-Smtp-Source: ABdhPJwRIlMZ/N3CaLiouXW/V1Nu5fEPPg34JRXTySZPqf2rTLSJUyAHmbmbfn25DsZhtMrqpgtQAw== X-Received: by 2002:a05:6402:2985:b0:425:d51f:ae4 with SMTP id eq5-20020a056402298500b00425d51f0ae4mr26454621edb.379.1651130189275; Thu, 28 Apr 2022 00:16:29 -0700 (PDT) Received: from [192.168.0.160] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id z14-20020a170906944e00b006f38c33b6e3sm6086651ejx.68.2022.04.28.00.16.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Apr 2022 00:16:27 -0700 (PDT) Message-ID: Date: Thu, 28 Apr 2022 09:16:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] dt-bindings: arm: mediatek: mmsys: refine power and gce properties Content-Language: en-US To: "jason-jh.lin" , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , AngeloGioacchino Del Regno Cc: Fabien Parent , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, CK Hu , Rex-BC Chen , Nancy Lin , Singo Chang , Project_Global_Chrome_Upstream_Group@mediatek.com References: <20220428012715.2619-1-jason-jh.lin@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20220428012715.2619-1-jason-jh.lin@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/04/2022 03:27, jason-jh.lin wrote: > From: "Jason-JH.Lin" > > Power: > Refine description and add item number for power-domains property. > > GCE: > Refine description and add item number for mboxes property and > mediatek,gce-client-reg property. > > Fixes: 1da90b8a7bae ("dt-bindings: arm: mediatek: mmsys: add power and gce properties") > Signed-off-by: Jason-JH.Lin > --- > .../bindings/arm/mediatek/mediatek,mmsys.yaml | 29 +++++++++---------- > 1 file changed, 14 insertions(+), 15 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml > index 6ad023eec193..6722f1b724ef 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml > +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml > @@ -43,28 +43,27 @@ properties: > maxItems: 1 > > power-domains: > + maxItems: 1 > description: > - A phandle and PM domain specifier as defined by bindings > - of the power controller specified by phandle. See > - Documentation/devicetree/bindings/power/power-domain.yaml for details. > + Each mmsys belongs to a power-domains. If mmsys wants to use PM > + interface to control the power controller of mmsys, it should have > + this property. > > mboxes: > + minItems: 1 maxItems, surely you cannot have infinite number of mailboxes to talk with? > description: > - Using mailbox to communicate with GCE, it should have this > - property and list of phandle, mailbox specifiers. See > - Documentation/devicetree/bindings/mailbox/mtk-gce.txt for details. > - $ref: /schemas/types.yaml#/definitions/phandle-array > + If using mailbox to communicate with GCE, it should have this > + property. GCE will help configure the hardware settings for the > + current mmsys data pipeline. > > mediatek,gce-client-reg: > - description: > - The register of client driver can be configured by gce with 4 arguments > - defined in this property, such as phandle of gce, subsys id, > - register offset and size. > - Each subsys id is mapping to a base address of display function blocks > - register which is defined in the gce header > - include/dt-bindings/gce/-gce.h. > - $ref: /schemas/types.yaml#/definitions/phandle-array Why removing ref? Does your binding work after such change? > maxItems: 1 > + items: > + - items: > + - description: phandle to GCE > + - description: subsys id > + - description: register offset > + - description: register size > > "#clock-cells": > const: 1 Best regards, Krzysztof