From: Andrej Picej <andrej.picej@norik.com>
To: Shawn Guo <shawnguo@kernel.org>
Cc: robh+dt@kernel.org, s.hauer@pengutronix.de,
devicetree@vger.kernel.org, festevam@gmail.com,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
y.bas@phytec.com
Subject: Re: [PATCH RESEND 2/2] ARM: dts: imx6qdl: Handle unneeded MFD-subdevices correctly
Date: Thu, 27 Jan 2022 07:29:31 +0100 [thread overview]
Message-ID: <b7ce8b9e-e11e-fe7e-bf20-41cee9ee933b@norik.com> (raw)
In-Reply-To: <20220126092741.GK4686@dragon>
On 26. 01. 22 10:27, Shawn Guo wrote:
> On Thu, Dec 16, 2021 at 12:55:29PM +0100, Andrej Picej wrote:
>> From: Yunus Bas <y.bas@phytec.de>
>>
>> The proper way to handle partly used MFD devices are to describe all MFD
>> subdevices in the devicetree and disable the not used ones. This
>> suppresses any warnings that may arise as a result.
>>
>> Signed-off-by: Yunus Bas <y.bas@phytec.de>
>> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
>
> Use subject prefix like
>
> ARM: dts: imx6qdl-phytec: ...
>
> Shawn
Will send a v2 with this change.
Thanks.
Andrej
>
>> ---
>> arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 5 +++++
>> arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 10 ++++++++++
>> 2 files changed, 15 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
>> index 2ec154756bbc..3590f439adf5 100644
>> --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
>> @@ -213,6 +213,11 @@ pmic_rtc: rtc {
>> da9063_wdog: wdt {
>> compatible = "dlg,da9063-watchdog";
>> };
>> +
>> + onkey {
>> + compatible = "dlg,da9063-onkey";
>> + status = "disabled";
>> + };
>> };
>> };
>>
>> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
>> index 94b254bfd054..28a805384668 100644
>> --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
>> @@ -116,6 +116,16 @@ watchdog {
>> dlg,use-sw-pm;
>> };
>>
>> + thermal {
>> + compatible = "dlg,da9062-thermal";
>> + status = "disabled";
>> + };
>> +
>> + gpio {
>> + compatible = "dlg,da9062-gpio";
>> + status = "disabled";
>> + };
>> +
>> regulators {
>> vdd_arm: buck1 {
>> regulator-name = "vdd_arm";
>> --
>> 2.25.1
>>
next prev parent reply other threads:[~2022-01-27 6:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 11:55 [PATCH RESEND 1/2] ARM: dts: imx6: phyFLEX: add missing pmic mfd subdevices Andrej Picej
2021-12-16 11:55 ` [PATCH RESEND 2/2] ARM: dts: imx6qdl: Handle unneeded MFD-subdevices correctly Andrej Picej
2022-01-26 9:27 ` Shawn Guo
2022-01-27 6:29 ` Andrej Picej [this message]
2022-01-26 9:24 ` [PATCH RESEND 1/2] ARM: dts: imx6: phyFLEX: add missing pmic mfd subdevices Shawn Guo
2022-01-27 6:28 ` Andrej Picej
2022-01-28 3:55 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7ce8b9e-e11e-fe7e-bf20-41cee9ee933b@norik.com \
--to=andrej.picej@norik.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=y.bas@phytec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).