Re: [PATCH 2/2] phy: freescale: add Samsung HDMI PHY

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 26/08/2022 22:20, Lucas Stach wrote:
> This adds the driver for the Samsung HDMI PHY found on the
> i.MX8MP SoC. Based on downstream implementation from
> Sandor Yu <Sandor.yu@nxp.com>.
> 
> Co-developed-by: Marco Felsch <m.felsch@pengutronix.de>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  drivers/phy/freescale/Kconfig                |   6 +
>  drivers/phy/freescale/Makefile               |   1 +
>  drivers/phy/freescale/phy-fsl-samsung-hdmi.c | 699 +++++++++++++++++++
>  3 files changed, 706 insertions(+)
>  create mode 100644 drivers/phy/freescale/phy-fsl-samsung-hdmi.c
> 
> diff --git a/drivers/phy/freescale/Kconfig b/drivers/phy/freescale/Kconfig
> index 853958fb2c06..5c2b73042dfc 100644
> --- a/drivers/phy/freescale/Kconfig
> +++ b/drivers/phy/freescale/Kconfig
> @@ -35,6 +35,12 @@ config PHY_FSL_IMX8M_PCIE
>  	  Enable this to add support for the PCIE PHY as found on
>  	  i.MX8M family of SOCs.
>  
> +config PHY_FSL_SAMSUNG_HDMI_PHY
> +	tristate "Samsung HDMI PHY support"
> +	depends on OF && HAS_IOMEM
> +	help
> +	  Enable this to add support for the Samsung HDMI PHY in i.MX8MP.

Your bindings do not mention that this IP block comes from Samsung, so
please extend the description there.

Also, since this came from blocks used by Samsung, probably it shares a
lot with Samsung Exynos SoC, so it would be nice to Cc maintainers of
DRM DRIVERS FOR EXYNOS for some feedback.

Although existing Samsung HDMI phy driver is tightly coupled with Exynos
DRM drivers, so not really re-usable without huge refactoring. I did not
check the register layout similarities.

Best regards,
Krzysztof