From: Krzysztof Kozlowski <krzk@kernel.org>
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Mikko Perttunen <mperttunen@nvidia.com>,
Sumit Gupta <sumitg@nvidia.com>,
Dmitry Osipenko <digetx@gmail.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH v1 3/5] dt-bindings: memory: Add Tegra114 memory client IDs
Date: Tue, 17 Feb 2026 09:15:28 +0100 [thread overview]
Message-ID: <b7de1799-d113-402d-82ab-06492216ebd8@kernel.org> (raw)
In-Reply-To: <CAPVz0n3OEN2M=wj7cq_-qrYi5VkMUP4RcUB7=sQxnLaGGivKVQ@mail.gmail.com>
On 17/02/2026 09:02, Svyatoslav Ryhel wrote:
> вт, 17 лют. 2026 р. о 09:22 Krzysztof Kozlowski <krzk@kernel.org> пише:
>>
>> On 26/01/2026 20:07, Svyatoslav Ryhel wrote:
>>> Each memory client has unique hardware ID, add these IDs.
>>>
>>> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
>>> Acked-by: Rob Herring (Arm) <robh@kernel.org>
>>> Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
>>> ---
>>> include/dt-bindings/memory/tegra114-mc.h | 67 ++++++++++++++++++++++++
>>
>> This is never a separate commit. Squash with the binding.
>>
>
> Always was and now it suddenly is not? Maybe you should consider
It never was, by the rules. I give this review all the time.
> fixing checkpatch since it complains that binding and header must be 2
> separate commits.
I considered, I guess many considered... but the problem is:
IT DOES NOT SAY THAT. There is no checkpatch warning, at least on recent
tree.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-17 8:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 19:07 [PATCH v1 0/5] Tegra114: implement EMC support Svyatoslav Ryhel
2026-01-26 19:07 ` [PATCH v1 1/5] dt-bindings: memory: Document Tegra114 Memory Controller Svyatoslav Ryhel
2026-01-26 19:07 ` [PATCH v1 2/5] memory: tegra: implement EMEM regs and ICC ops for Tegra114 Svyatoslav Ryhel
2026-01-26 19:07 ` [PATCH v1 3/5] dt-bindings: memory: Add Tegra114 memory client IDs Svyatoslav Ryhel
2026-02-17 7:22 ` Krzysztof Kozlowski
2026-02-17 8:02 ` Svyatoslav Ryhel
2026-02-17 8:15 ` Krzysztof Kozlowski [this message]
2026-02-17 8:24 ` Svyatoslav Ryhel
2026-03-27 23:53 ` Thierry Reding
2026-03-28 11:40 ` Krzysztof Kozlowski
2026-03-28 12:11 ` Krzysztof Kozlowski
2026-01-26 19:07 ` [PATCH v1 4/5] dt-bindings: memory: Document Tegra114 External Memory Controller Svyatoslav Ryhel
2026-01-26 19:07 ` [PATCH v1 5/5] memory: tegra: Add Tegra114 EMC driver Svyatoslav Ryhel
2026-02-17 7:21 ` Krzysztof Kozlowski
2026-02-17 7:51 ` Svyatoslav Ryhel
2026-02-17 8:18 ` Krzysztof Kozlowski
2026-02-17 8:29 ` Svyatoslav Ryhel
2026-02-17 8:33 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7de1799-d113-402d-82ab-06492216ebd8@kernel.org \
--to=krzk@kernel.org \
--cc=clamor95@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=robh@kernel.org \
--cc=sumitg@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox