[PATCH 1/4] dt-bindings: crypto: fsl-imx-sahara: Shorten the title

[PATCH 1/4] dt-bindings: crypto: fsl-imx-sahara: Shorten the title

[Fabio Estevam]

From: Fabio Estevam <festevam@denx.de>

In the title, there is no need to mention "included in some i.MX chips"
as it is too vague.

Remove it to make it simpler. 

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml b/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml
index d531f3af3ea4..c7da09c58eff 100644
--- a/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml
+++ b/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml
@@ -4,7 +4,7 @@
 $id: http://devicetree.org/schemas/crypto/fsl-imx-sahara.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: Freescale SAHARA Cryptographic Accelerator included in some i.MX chips
+title: Freescale SAHARA Cryptographic Accelerator
 
 maintainers:
   - Steffen Trumtrar <s.trumtrar@pengutronix.de>
-- 
2.34.1

[PATCH 2/4] dt-bindings: crypto: fsl-imx-sahara: Remove leading space

[Fabio Estevam]

From: Fabio Estevam <festevam@denx.de>

Remove the leading space in the reg property as this is the standard.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml b/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml
index c7da09c58eff..bad82491cd6a 100644
--- a/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml
+++ b/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml
@@ -32,6 +32,6 @@ examples:
   - |
     crypto@10025000 {
         compatible = "fsl,imx27-sahara";
-        reg = < 0x10025000 0x800>;
+        reg = <0x10025000 0x800>;
         interrupts = <75>;
     };
-- 
2.34.1

[PATCH 3/4] dt-bindings: crypto: fsl-imx-sahara: Document the clocks

[Fabio Estevam]

From: Fabio Estevam <festevam@denx.de>

The Sahara block needs to clocks (ipg and ahb) to operate.

Describe them.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 .../bindings/crypto/fsl-imx-sahara.yaml         | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml b/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml
index bad82491cd6a..9dbfc15510a8 100644
--- a/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml
+++ b/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml
@@ -21,17 +21,34 @@ properties:
   interrupts:
     maxItems: 1
 
+  clocks:
+    items:
+      - description: Sahara IPG clock
+      - description: Sahara AHB clock
+
+  clock-names:
+    items:
+      - const: ipg
+      - const: ahb
+
 required:
   - compatible
   - reg
   - interrupts
+  - clocks
+  - clock-names
 
 additionalProperties: false
 
 examples:
   - |
+    #include <dt-bindings/clock/imx27-clock.h>
+
     crypto@10025000 {
         compatible = "fsl,imx27-sahara";
         reg = <0x10025000 0x800>;
         interrupts = <75>;
+        clocks = <&clks IMX27_CLK_SAHARA_IPG_GATE>,
+                 <&clks IMX27_CLK_SAHARA_AHB_GATE>;
+        clock-names = "ipg", "ahb";
     };
-- 
2.34.1

[PATCH 4/4] dt-bindings: crypto: fsl-imx-sahara: Fix the number of irqs

[Fabio Estevam]

From: Fabio Estevam <festevam@denx.de>

i.MX27 has only one Sahara interrupt. i.MX53 has two.

Describe this difference.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 .../bindings/crypto/fsl-imx-sahara.yaml       | 23 ++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml b/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml
index 9dbfc15510a8..9d1d9c8f0955 100644
--- a/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml
+++ b/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml
@@ -19,7 +19,10 @@ properties:
     maxItems: 1
 
   interrupts:
-    maxItems: 1
+    items:
+      - description: SAHARA Interrupt for Host 0
+      - description: SAHARA Interrupt for Host 1
+    minItems: 1
 
   clocks:
     items:
@@ -40,6 +43,24 @@ required:
 
 additionalProperties: false
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx53-sahara
+    then:
+      properties:
+        interrupts:
+          minItems: 2
+          maxItems: 2
+    else:
+      properties:
+        interrupts:
+          minItems: 1
+          maxItems: 1
+
 examples:
   - |
     #include <dt-bindings/clock/imx27-clock.h>
-- 
2.34.1

Re: [PATCH 2/4] dt-bindings: crypto: fsl-imx-sahara: Remove leading space

[Krzysztof Kozlowski]

On 25/09/2023 00:31, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Remove the leading space in the reg property as this is the standard.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Squash this and previous. Such trivial cleanups, without any impact, do
not make any sense on their own.

Best regards,
Krzysztof

Re: [PATCH 3/4] dt-bindings: crypto: fsl-imx-sahara: Document the clocks

[Krzysztof Kozlowski]

On 25/09/2023 00:31, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> The Sahara block needs to clocks (ipg and ahb) to operate.
> 
> Describe them.

"Describe the clocks (ipg and ahb) needed by Sahara block to operate".
One line, instead of three.


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 4/4] dt-bindings: crypto: fsl-imx-sahara: Fix the number of irqs

[Krzysztof Kozlowski]

On 25/09/2023 00:31, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> i.MX27 has only one Sahara interrupt. i.MX53 has two.
> 
> Describe this difference.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  .../bindings/crypto/fsl-imx-sahara.yaml       | 23 ++++++++++++++++++-
>  1 file changed, 22 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml b/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml
> index 9dbfc15510a8..9d1d9c8f0955 100644
> --- a/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml
> +++ b/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml
> @@ -19,7 +19,10 @@ properties:
>      maxItems: 1
>  
>    interrupts:
> -    maxItems: 1
> +    items:
> +      - description: SAHARA Interrupt for Host 0
> +      - description: SAHARA Interrupt for Host 1
> +    minItems: 1
>  
>    clocks:
>      items:
> @@ -40,6 +43,24 @@ required:
>  
>  additionalProperties: false
>  
> +allOf:

This goes before additionalProperties:.

> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - fsl,imx53-sahara
> +    then:
> +      properties:
> +        interrupts:
> +          minItems: 2
> +          maxItems: 2
> +    else:
> +      properties:
> +        interrupts:
> +          minItems: 1

maxItems is enough.


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof