Devicetree
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Dmitry Yashin <dmt.yashin@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: rockchip: add Forlinx OK3568-C
Date: Wed, 30 Sep 2026 21:19:01 +0200	[thread overview]
Message-ID: <b81186ad-1da0-4c20-8b4a-aabdb7abb396@lunn.ch> (raw)
In-Reply-To: <20260930-ok3568-c-v1-3-a0ffd55f5c95@gmail.com>

> +&gmac0 {
> +	clock_in_out = "output";
> +	phy-handle = <&rgmii_phy0>;
> +	/* Use rgmii-rxid mode to disable rx delay inside Soc */
> +	phy-mode = "rgmii-rxid";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&gmac0_miim
> +		     &gmac0_tx_bus2
> +		     &gmac0_rx_bus2
> +		     &gmac0_rgmii_clk
> +		     &gmac0_rgmii_bus
> +		     &gmac0_clkinout
> +		     &eth0_pins>;
> +	tx_delay = <0x36>;
> +	status = "okay";
> +};
> +
> +&gmac1 {
> +	clock_in_out = "output";
> +	phy-handle = <&rgmii_phy1>;
> +	/* Use rgmii-rxid mode to disable rx delay inside Soc */
> +	phy-mode = "rgmii-rxid";

Yet another rockchip board which gets RGMII delays wrong.

https://elixir.bootlin.com/linux/v6.15/source/Documentation/devicetree/bindings/net/ethernet-controller.yaml#L287

	Andrew

  parent reply	other threads:[~2026-09-30 19:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-30  9:29 [PATCH 0/4] arm64: dts: rockchip: add Forlinx OK3568-C Dmitry Yashin
2026-09-30  9:29 ` [PATCH 1/4] dt-bindings: arm: rockchip: add Forlinx FET3568-C Dmitry Yashin
2026-10-01  8:32   ` Krzysztof Kozlowski
2026-09-30  9:29 ` [PATCH 2/4] arm64: dts: " Dmitry Yashin
2026-09-30  9:46   ` sashiko-bot
2026-09-30  9:29 ` [PATCH 3/4] arm64: dts: rockchip: add Forlinx OK3568-C Dmitry Yashin
2026-09-30  9:55   ` sashiko-bot
2026-09-30 19:19   ` Andrew Lunn [this message]
2026-09-30  9:29 ` [PATCH 4/4] arm64: dts: rockchip: add FIT-PCIE-SATA overlay Dmitry Yashin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b81186ad-1da0-4c20-8b4a-aabdb7abb396@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmt.yashin@gmail.com \
    --cc=heiko@sntech.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox