From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rajendra Nayak <quic_rjendra@quicinc.com>,
agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, konrad.dybcio@linaro.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dianders@chromium.org,
mka@chromium.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom: Document the sc7280 CRD Pro boards
Date: Fri, 18 Nov 2022 15:15:28 +0100 [thread overview]
Message-ID: <b818219f-ab28-5bed-e2a2-1884a6dbe061@linaro.org> (raw)
In-Reply-To: <e93a61ce-4c7b-ecb2-7b82-1bde388ec6bb@linaro.org>
On 18/11/2022 15:13, Krzysztof Kozlowski wrote:
> On 18/11/2022 08:30, Rajendra Nayak wrote:
>> Add compatibles for the Pro SKU of the sc7280 CRD boards
>>
>> Signed-off-by: Rajendra Nayak <quic_rjendra@quicinc.com>
>> ---
>> Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index 463509f0f23a..2550ab251f7b 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -613,6 +613,11 @@ properties:
>> - const: google,hoglin
>> - const: qcom,sc7280
>>
>> + - description: Qualcomm Technologies, Inc. sc7280 CRD Pro platform (newest rev)
>
> Such entry is already documented. I think this is not based on recent
> kernel.
My bad, I missed this is a Pro. Why it is not part of compatible? What
is the difference between hoglin and CRD Pro?
You have plenty of space in commit msg to explain this.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-18 14:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 7:30 [PATCH 1/2] dt-bindings: arm: qcom: Document the sc7280 CRD Pro boards Rajendra Nayak
2022-11-18 7:30 ` [PATCH 2/2] arm64: dts: qcom: sc7280: Add a new herobrine Pro SKU Rajendra Nayak
2022-11-18 15:28 ` Matthias Kaehlcke
2022-11-21 4:37 ` Rajendra Nayak
2022-11-18 14:13 ` [PATCH 1/2] dt-bindings: arm: qcom: Document the sc7280 CRD Pro boards Krzysztof Kozlowski
2022-11-18 14:15 ` Krzysztof Kozlowski [this message]
2022-11-21 4:38 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b818219f-ab28-5bed-e2a2-1884a6dbe061@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=quic_rjendra@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).