From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Meng Li <Meng.Li@windriver.com>,
dinguyen@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [v2 PATCH] arm64: dts: stratix10: add new compatible for Intel SoCFPGA Stratix10 platform
Date: Fri, 21 Jul 2023 10:51:11 +0200 [thread overview]
Message-ID: <b8333812-df9d-368a-939b-3495878a2e5e@linaro.org> (raw)
In-Reply-To: <20230721083821.1820881-1-Meng.Li@windriver.com>
On 21/07/2023 10:38, Meng Li wrote:
> Intel Stratix10 is very the same with Agilex platform, the DWC2 IP on
> the Stratix platform also does not support clock-gating. The commit
> 3d8d3504d233("usb: dwc2: Add platform specific data for Intel's Agilex")
> had fixed this issue. So, add the essential compatible to also use the
> specific data on Stratix10 platform.
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
From where did you get it?
Did you just fake a tag to pass the review?
> Signed-off-by: Meng Li <Meng.Li@windriver.com>
> ---
>
> v2:
> - Add SoC specific compatible as per Krzysztof comment
>
> ---
> arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
> index 41c9eb51d0ee..46691e72f46b 100644
> --- a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
> @@ -491,7 +491,7 @@ usbphy0: usbphy@0 {
> };
>
> usb0: usb@ffb00000 {
> - compatible = "snps,dwc2";
> + compatible = "intel,socfpga-stratix10-hsotg", "intel,socfpga-agilex-hsotg", "snps,dwc2";
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-21 8:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 8:38 [v2 PATCH] arm64: dts: stratix10: add new compatible for Intel SoCFPGA Stratix10 platform Meng Li
2023-07-21 8:51 ` Krzysztof Kozlowski [this message]
2023-07-21 8:53 ` Krzysztof Kozlowski
2023-07-21 9:05 ` Li, Meng
2023-07-21 9:19 ` Krzysztof Kozlowski
2023-07-21 9:21 ` Li, Meng
2023-07-21 9:22 ` Krzysztof Kozlowski
2023-07-21 9:29 ` Li, Meng
2023-07-21 9:35 ` Krzysztof Kozlowski
2023-07-21 9:58 ` Li, Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8333812-df9d-368a-939b-3495878a2e5e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Meng.Li@windriver.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox