From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C06E4177982; Sun, 6 Oct 2024 13:13:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728220432; cv=none; b=MzLvYQRWDHjBdY4gGLQrc8K5aAMOAzLv05Lr26MhIT8V5l9uu87eHMwWooaEV4VZ5t2kcArlZY6vq/WH+8pd+ng56H/gWWCizAt1/4ERgInXFRgEXZDOsF9Vl7fFmcS8m+0ZZ9zmELu8ooMbdLb4sn2ZeoVJ1AC9ERjyl27XDrI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728220432; c=relaxed/simple; bh=khsVM2k1ZTcKI00Tfb38pPI+E8XA6tqg9PgEMpsgDOw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qix6Uu+WnG7LBzzu8SeUidkx9NuuldX9IkA8x0hBJXocaHKBth72leO6Wws9DssEaQMaBhJS1JnZMMGVdIW1XpMRn7JF4f+LTmaLfh+N5AH+X9RyW998moy64BSsashCK2Bjz5/YJVzehVgtXYySt+7st/5SBGFWgf14Mb/y37Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=U6J41iP4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="U6J41iP4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61FAAC4CEC5; Sun, 6 Oct 2024 13:13:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728220432; bh=khsVM2k1ZTcKI00Tfb38pPI+E8XA6tqg9PgEMpsgDOw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=U6J41iP4cBmcBH/lySmBjh7RYoj0h1+7+JyNjKXcNXuwwpOsBnaFUsYhStBWx5m2k 6bLJOGK4fgJEMJet/1JWtSm1cgkNTluuH+idKN8VZxgtudSsODDFZ2Sbib97nGkZP5 9MBRANZk53w8RrMXMnCKsInEkh5eYecC/tMhJtys9mboc4raJZyVFyEv9w73b+qMhX aT6tgmIC0kRpM7YSUblAoqn5xF7LArt2fJ7qYaA/lk6JzTSICwuGnurZBfnr2LDglc Ny5VRcrg2tBNTrey/H1pGi9jcTI/67zaleczFqspjBzIriklyIpgptNqzTbXwBGuIx v9+2UVsqsfT6A== Message-ID: Date: Sun, 6 Oct 2024 15:13:43 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] dt-bindings: clock: imx8m-anatop: support spread spectrum clocking To: Dario Binacchi Cc: linux-kernel@vger.kernel.org, linux-amarula@amarulasolutions.com, Conor Dooley , Fabio Estevam , Krzysztof Kozlowski , Michael Turquette , Peng Fan , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , Stephen Boyd , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org References: <20240928083804.1073942-1-dario.binacchi@amarulasolutions.com> <20240928083804.1073942-2-dario.binacchi@amarulasolutions.com> <566859c1-a397-4465-987e-0682b07a703e@kernel.org> <6c3e6071-822f-4230-b76b-276330de07ef@kernel.org> <82db5037-bbd3-4005-bde9-02df1bf4c475@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 05/10/2024 10:57, Dario Binacchi wrote: > On Thu, Oct 3, 2024 at 12:46 PM Krzysztof Kozlowski wrote: >> >> On 01/10/2024 08:29, Dario Binacchi wrote: >>> On Mon, Sep 30, 2024 at 8:45 AM Krzysztof Kozlowski wrote: >>>> >>>> On 29/09/2024 22:00, Dario Binacchi wrote: >>>>>> >>>>>> >>>>>>> + properties: >>>>>>> + compatible: >>>>>>> + contains: >>>>>>> + enum: >>>>>>> + - fsl,imx8mm-anatop >>>>>>> + >>>>>>> +then: >>>>>>> + properties: >>>>>>> + fsl,ssc-clocks: >>>>>> >>>>>> Nope. Properties must be defined in top-level. >>>>>> >>>>>>> + $ref: /schemas/types.yaml#/definitions/phandle-array >>>>>>> + description: >>>>>>> + The phandles to the PLLs with spread spectrum clock generation >>>>>>> + hardware capability. >>>>>> >>>>>> These should be clocks. >>>>> >>>>> Sorry, but I can't understand what you're asking me. >>>>> Could you kindly explain it to me in more detail? >>>> >>>> You added new property instead of using existing one for this purpose: >>>> 'clocks'. >>> >>>> >>>> >>>> >>>> Best regards, >>>> Krzysztof >>>> >>> >>> I added this new property specifically for managing spread-spectrum. >>> Indeed, not all clocks/PLLs >>> managed by the node/peripheral support spread-spectrum, and the added >>> properties specify >>> parameters for enabling and tuning SSC for each individual PLL based >>> on the index of each list. >>> If I were to use the 'clocks' property and add a clock to this list >>> that does not support SSC, IMHO >>> the pairings would be less clear. >> >> You duplicate property with argument "pairings shall match". Well, I am >> not happy with the duplication. Clocks have specific order, thus it is >> explicit which one needs tuning. Your other properties can match them as >> well, just index from clocks is offset... > > Just to check if I understood correctly what you are suggesting before > submitting version 3 of the patch. > Something, for example, like: > > clocks = <&clk, IMX8MP_AUDIO_PLL1>, <&clk, IMX8MP_AUDIO_PLL2>, <&clk > IMX8MP_VIDEO_PLL1>; > fsl,ssc-modfreq-hz = <0, 3517>, <2, 6818>; Hm, what is 0? If clock index, then no, it's redundant. The first item in cannot point to other clock. Also, what exactly are you setting here and why assigned-clock-rates are not working? Best regards, Krzysztof